Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp1906074rwa; Sun, 21 Aug 2022 20:55:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR5qYTBCmUCiD7+xGvYzp5DjwbYcQESLzJ0w41IXZeQ88JLzSCqLj9nlDynT2Y2G2/gbnMEt X-Received: by 2002:a05:6402:51c6:b0:43d:dd3a:196e with SMTP id r6-20020a05640251c600b0043ddd3a196emr14693765edd.213.1661140511995; Sun, 21 Aug 2022 20:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661140511; cv=none; d=google.com; s=arc-20160816; b=MGCeyRbbc7n1nENIhQNnP69EX2AKeUBOihmoXo40gFYwmJ7dhZ1WIBAXvOgLMJI0Zv p32U02fBUHwfmLeF5vUEXCsKgogx+6MsgrYrDdKjwHm4/ZtuV9QfWi+6v4f3G50ZKST6 AJh8vsF3FJNZxdEwg2sDKJVkuknxhPvuMO8QYrbTj8ocWL6cV8oI/hdsKm/l/vhJbkNr RtW+x6dMns5iLXR1VSeSF3l4bH9QDbohCvNHmTYYxQwVc5qsF00aPZkvIz+Qax1z9O/9 zwzo6pJDsMPjHZr0lofaL+1lmrYnpcb0U/zW24v/gDgPitjYEj2PlJkqzn0HCa9/7plA DUaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=VKTUo2W4RNc2LDslDMcLOnHhdlFBjvbL0BUKEgnwbho=; b=Dd0ZiRkm7vOlN/RqL37S/Hri8Gm+6ztQW5E1LoGZgHBYks/0ajHbPsqPczU96FnHdP Q+MQV3s4Xa/aJH8h0WzDb2HOD5lzYt7cmugdtNk87+Ak1eW+xgTlpDc74iR7wq7mXvmn 0Sxvr74Q/bOy60xJVqXi2fWGwyefK5mFvI1PfpMtwU0R7Iu7WhPIgiTMN8/CU3DyDYmX ZffEdg/9Bx6ClbzNLmlSlMAvOBZDMb4a1AfG/ZPZxnqpu2fSmfkagGxcLwTXm0XbeorR mpw7q8EnRt2vi4JrTz0K0+8aMOHZz/bHpIltj02o3asz3bKppTvnntUxgFS4I475EJtq qDmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Je1l+Xpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji13-20020a170907980d00b00730a11988dcsi9936805ejc.562.2022.08.21.20.54.17; Sun, 21 Aug 2022 20:55:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Je1l+Xpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbiHVDkc (ORCPT + 99 others); Sun, 21 Aug 2022 23:40:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232442AbiHVDk2 (ORCPT ); Sun, 21 Aug 2022 23:40:28 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 602F5248E5 for ; Sun, 21 Aug 2022 20:40:27 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4M9ymm08WXz4wgn; Mon, 22 Aug 2022 13:40:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1661139625; bh=VKTUo2W4RNc2LDslDMcLOnHhdlFBjvbL0BUKEgnwbho=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Je1l+Xpf0IQX7/cqLqeVKhTFzln629PFhZPHnimgYEZfZglpmJOAXo6zZ3qqLhZaf pTCMCKJNyh1BWnCZeF0hO5SpcKNefkyzqjvwSQSbB0Q9p4wyY4mxq13vFYf00xpcbr xzuVuyPEnHozay6S9HX2w6LkAycpVJvPeR7oLAITkfkdIucCbL9dApvTjnXqw0Xk73 7cI6LYa6l3ecozrENJFNG4Kt7ornODrTsmYmlmdbec7ns7F8/FpSHkUiBLALBeb+7m 8ZXm3JZUDtz306E+p2oj6x37piBTa3oKoIdFKPIktfSUup6WZ2toUR+qoAlwz7y2Qs AO9ZaxnMzKH8g== From: Michael Ellerman To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Randy Dunlap , "Gautham R . Shenoy" , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, amd-gfx@lists.freedesktop.org, Felix Kuehling , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "Pan, Xinhui" Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules In-Reply-To: <20220819210112.7924-1-rdunlap@infradead.org> References: <20220819210112.7924-1-rdunlap@infradead.org> Date: Mon, 22 Aug 2022 13:40:23 +1000 Message-ID: <87o7wdkkt4.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap writes: > Fix build error when CONFIG_DRM_AMDGPU=m: > > ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > by exporting 'cpu_smallcore_map' just as other per_cpu > symbols are exported. > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). > This is an inline function on powerpc which references > cpu_smallcore_map. > > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"") > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core") That 2nd commit is not in mainline, only linux-next. I don't mind merging this fix preemptively, but is that SHA stable? cheers