Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 08:07:39 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jack Wang <jinpu.wang@ionos.com>
Cc:     linux-kernel@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check
 for dma_map_sg
Message-ID: <YwMPG38aLAKjO/69@kili>
References: <20220819060801.10443-1-jinpu.wang@ionos.com>
 <20220819060801.10443-2-jinpu.wang@ionos.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220819060801.10443-2-jinpu.wang@ionos.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mx0gWM+uxA592n1uX0BkwNdfrvOGaEFt60d0wOuJY7obNxZka7yJYPivG49N?=
 =?us-ascii?Q?o9vDb8EPYnyySueoaRopXnAZkZAql8aizFx67zzDxbXzvri9HkIcduudtv0e?=
 =?us-ascii?Q?sp0tEdthP0QLj+4t4eetpCl6qmu1TXABUPKdzPGygLVpBuiDpPsTW+w3yuJs?=
 =?us-ascii?Q?chQRq2qbsmzW8jOsf9m6cOdQORJvYBOfEL/0ktzv515ayY9ySLesyfZOPo28?=
 =?us-ascii?Q?Gqzgj0cO/3O8Jwdop1UwzjBBznOGAftChmeE+88kD/4WqM4XMnViC4aPUO90?=
 =?us-ascii?Q?/V7zHBSUeInERuhnIpQRRqIMaPPDcNH2MwKeUBndJfpZ9pBNey4Enw6PyhUs?=
 =?us-ascii?Q?9cHW/e60dx17ElcGn+TReJYC7jatK9ERLtk7n5SFegZI3y9pWMK9jCCxiJhw?=
 =?us-ascii?Q?MdHAVs1qOmgxE9WigamhnChuTgfG/fyOmYknM6XQGFZ/3Wt1bv9fLCF9xmYx?=
 =?us-ascii?Q?VJZnd2HXKOQ5uZQW9W8JeCXB9AOFS1GQ5wFOAr/K4uuIRqB83db5gMkmeiIA?=
 =?us-ascii?Q?FN19a4VzPAcM45cyCGCQbCpy9QZ3RVNEzDRF3ALuPkAAQYhxXtB2EqWZox/t?=
 =?us-ascii?Q?GWRgH9cKObewwxqwHnJ6HQ34bBBrvtTg9zNHnpjNnR0Yk/1YGDuMxTcoc6+B?=
 =?us-ascii?Q?FxxHrR71j88PUl9rTPaJYzfBng6igIRlAXse+om8wfh4M2N6/rCIQKjgubpp?=
 =?us-ascii?Q?+7i2/+lzwjMb39Wi6x/fLj8Y+eA5rAKn8yazQH9zDa1KuDbxOWTheuXP08zS?=
 =?us-ascii?Q?AyzrZCLjaNhzVX9QnzpBbb9JoFPj3sp2RkyJHspF1YBYCCXRr3MNIKCUWB9m?=
 =?us-ascii?Q?isMZ98GJZEUuRVCozkyuRk3iX9vxO9AXYemnoDxISJ/dWQ1TVEcW5u9IMI1s?=
 =?us-ascii?Q?027e24nCKrtYilLXyR/WMEmwZQk+j6qshHl8BnBBBT4r/b40vLitDrY03Uxf?=
 =?us-ascii?Q?D8RcAlpREaKNU6bCWf76VS3MMLjQZ8cW0G9pjABzeGojCNPhVmfKfXf2R4qV?=
 =?us-ascii?Q?nR5LSmA78T1N1SzlA7WpQLa5v7TugZw5UPJcDt4rvUVt5A8cv920CehM2qxD?=
 =?us-ascii?Q?LNBRNNaEKIlW/QRTQBj7TAq7eFdMldicFfP1hVRz/nD+HtX+pnKxAcUWZEeb?=
 =?us-ascii?Q?ThY3J74XZE+7xRT+4lcom1XXaZFOUACgAfXVgxy705d2m0PmAvuGWGhN3yIm?=
 =?us-ascii?Q?i2gwqpkAuAQd7rSjwZj4vhS7FGoQxoJfOs/S7g+0YlnDn0OoUGiFAAc77Ws/?=
 =?us-ascii?Q?I5UCivntDMevt1xaGj5J/ZG4XagSLZUTPUKhysc+l6Mjs34XTFL0bFQNJruT?=
 =?us-ascii?Q?TCPPacIN0zW/N0vZDW/lEK5YUm5ahB9ngq8jXMNquAGtnbar+5Bsp5/u9L7c?=
 =?us-ascii?Q?lZ6LerzQPkJeE7yfvOGBFlvEXdNEqhznHJK5yxSzqGw8J0aMVuqi7gtOFncl?=
 =?us-ascii?Q?JZOufmcsuJ4CQQTUDTMU16AaHBbC5clQU8opS8RqaoifVd2LwYF6AKulru1z?=
 =?us-ascii?Q?ZU81Cb4vUVqELplMAMIJpipKKRlFZYkVQmkkc6zLeDRcpzROwnhqbQ1r6SX2?=
 =?us-ascii?Q?yfbdXgp5/EGEsC6z2pFLFP7ozF/Cps53UO1D5Vwv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2babcedb-8b06-40ec-1572-08da83fc4338
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 05:07:51.1436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EmKsmLcfnPME+TWiPjTAAvdRD2u4g1xmS+IY15o1QtNlf3uzZq5sIlOXXasiIdY9iLJU//Hbbv02NGXSCSeg9vGlqc8KwsbqT9mqTfUxCHk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB4101
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_02,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=905
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208220023
X-Proofpoint-ORIG-GUID: 0Bg4JIuoFZwhnw6Y3BeuIaoNSzbboe_X
X-Proofpoint-GUID: 0Bg4JIuoFZwhnw6Y3BeuIaoNSzbboe_X
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 19, 2022 at 08:07:43AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error, fix the error check, and return -EIO
> to caller.
> 
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>

This needs a Fixes tag.

Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager")

regards,
dan carpenter