Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 05:55:58 +0000
From:   Tzung-Bi Shih <tzungbi@kernel.org>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     Evan Green <evgreen@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Rajat Jain <rajatja@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        Tinghan Shen <tinghan.shen@mediatek.com>,
        chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Expose suspend_timeout_ms
 in debugfs
Message-ID: <YwMabj1HazWxJEAr@google.com>
References: <20220818082827.v2.1.Idd188ff3f9caddebc17ac357a13005f93333c21f@changeid>
 <CACeCKafyHSTiyyjA=yjSXsTub4kKECfe9gp=y10LCYYx0nGKqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACeCKafyHSTiyyjA=yjSXsTub4kKECfe9gp=y10LCYYx0nGKqg@mail.gmail.com>
Precedence: bulk

On Thu, Aug 18, 2022 at 10:24:23AM -0700, Prashant Malani wrote:
> On Thu, Aug 18, 2022 at 8:29 AM Evan Green <evgreen@chromium.org> wrote:
> > diff --git a/Documentation/ABI/testing/debugfs-cros-ec b/Documentation/ABI/testing/debugfs-cros-ec
> > index 1fe0add99a2a99..9f79c641b2d09f 100644
> > --- a/Documentation/ABI/testing/debugfs-cros-ec
> > +++ b/Documentation/ABI/testing/debugfs-cros-ec
> > @@ -54,3 +54,25 @@ Description:
> >                 this feature.
> >
> >                 Output will be in the format: "0x%08x\n".
> > +
> > +What:          /sys/kernel/debug/<cros-ec-device>/suspend_timeout_ms
> > +Date:          August 2022
> > +KernelVersion: 6.1
> > +Description:
> > +               Some ECs have a feature where they will track transitions to the
> > +               a hardware-controlled sleep line, such as Intel's SLP_S0 line,
> > +               in order to detect cases where a system failed to go into deep
> > +               sleep states. The suspend_timeout file controls the amount of
> s/suspend_timeout/suspend_timeout_ms

Please also fix it in code.