Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220816093644.764259-1-judyhsiao@chromium.org> <CAD=FV=XLsBcbrjb0DwG+Yhia_hk4kcKT2S0_vMT=k3cWxh=NRg@mail.gmail.com>
In-Reply-To: <CAD=FV=XLsBcbrjb0DwG+Yhia_hk4kcKT2S0_vMT=k3cWxh=NRg@mail.gmail.com>
From:   Judy Hsiao <judyhsiao@chromium.org>
Date:   Mon, 22 Aug 2022 14:31:37 +0800
Message-ID: <CAJXt+b8uS_s3VOrRdPwYHx0mAtBCd=qOGQp2SWq_-EAt9nYRkw@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Use "PP1800_L2C" as the DMIC
 power source.
To:     Doug Anderson <dianders@chromium.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Srini Kandagatla <srinivas.kandagatla@linaro.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Jimmy Cheng-Yi Chiang <cychiang@google.com>,
        Judy Hsiao <judyhsiao@google.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,
> In v1, Stephen pointed out that the subject and description of your
> patch talk about adjusting the supply. However, your patch _also_
> adjusts the audio routing.
Thanks for your comment.
The audio routing part change is to use the vdd-micb-supply regulator setting.
And the vdd-micb-supply set the MIC power source as PP1800_L2C.
 +                       "VA DMIC0", "vdd-micb",
 +                       "VA DMIC1", "vdd-micb",
 +                       "VA DMIC2", "vdd-micb",
 +                       "VA DMIC3", "vdd-micb",
Let me update the commit message again to make it more clear.
Thanks!

> It feels like the audio routing should be done in a separate patch and
> that patch.
>
> -Doug