Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 09:42:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Huang Rui <ray.huang@amd.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        Tim Huang <Tim.Huang@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139
 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs'
 could be null (see line 139)
Message-ID: <202208190418.1Y3QCIis-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EKLUFLxmxr98k4ZCSfAforhNHByDWFzrHeqt06tijkGzTP+YVh1qzmG00ovn?=
 =?us-ascii?Q?wpA6NWZzftaoBpzyEmyocV6v34IMPUjG8NkGKGfpTlAm7H4AFv2A84IEOo/N?=
 =?us-ascii?Q?t9qEfRenLHOsi2jUNhHVzMynZ9WPfYwf/v4jqQhBcIhwUW2Je7aKOJVtXpwN?=
 =?us-ascii?Q?Wko99j5Cc6mTlO/ivlgmFiuFOFqem73TjMA/H0gvCm6mCwPo3gB//7e60f8e?=
 =?us-ascii?Q?yE3w9Z/RxpRct4APoSr5zH6zb6T+lfQIfXaCK/1Maf5oPkQOj78LJCfEbuZc?=
 =?us-ascii?Q?BXvl/kUGJPmLjMVf3Y8cBPFbcEDwx3okb7sNPsDPmmraF0LN7CGCBTCdOTQ9?=
 =?us-ascii?Q?S9D35kLv9/k+qnWn3EOpZuR/LnWo+f9UV2rGnnGOzDlRm2L0TurXiIs8Al44?=
 =?us-ascii?Q?PBRfY5bTNdNVGHsSCpDWvrwxvSoW+jTcrpUDcNIhvVo51qXHPOHzP9jrr85E?=
 =?us-ascii?Q?7pzwgyK3kj5ji+/4CrxBKP52d3sVvm+7lx0Ra5RyWXBAul3Fln7Q1OQq0Is+?=
 =?us-ascii?Q?YxdhGxVV1vzYSAPiKVYxg4qfVse6r8Nj/Wzm+FRLNlfIYYzk2fqhbxMhKTQB?=
 =?us-ascii?Q?mLPKDL3TZDtBYHSNdyrJJKz9vsAw577NYYMAyTeE55FELRtQYaxSc0RUykkx?=
 =?us-ascii?Q?/OT7MNzk9aF3g9mX3wQ6mqE6I2ALPyB6+A3KRdKGUrXd9HbY7tlGTcEXHIB+?=
 =?us-ascii?Q?tQZPNOY0ycz5trBgU16Z34t7Rrish6PaBubgPPytoCXu2Fy7EP4q5WfbJRim?=
 =?us-ascii?Q?uF3CNuR9hXVclPx11Zx8FQ+mDPBvFMtl5xAARg1PICeOSqIrUngV5lz6dP8K?=
 =?us-ascii?Q?0du/NBh2Qm637D+t+R3GzJSm1V8TnxDt4yYk1EpCBn9EQsCMoUBORlow1s+N?=
 =?us-ascii?Q?N7nK1lzzHK/FQhlqbP5R+CMZZ7gD3j924e+gLZd2tdtHUxC3iixPTGs6PsNQ?=
 =?us-ascii?Q?lhi9iLreEGYvkC5UjGveEY4fshFz++FeIkBTpzOK6dzizkOSuQvLfM4JnoVr?=
 =?us-ascii?Q?EC0uze9k8tJELWwc0Qm2DtC4Y5nt/JLBmLFu8m0n/RJA7WHTVTXc44lH6gPr?=
 =?us-ascii?Q?Zte2LowZKssxY6ogXh7n6i5sk2/ejgg4zLWmT0noV7R5CpgqLjy/z0U+RXw4?=
 =?us-ascii?Q?39UM6FIm41hdFt7ZPNut3BQOwzZ1gZEcUHkg2zNYKEFmPM1S7rAZQHHDghw9?=
 =?us-ascii?Q?mNLuG0o3UgWR9Ad/1MTPh6zeczNmETzIVW98ITF7k7LSg4MYvJMzQWVdM2xM?=
 =?us-ascii?Q?P/w2l0sVtLvEtzAcaNXJw66obnH8/Vkpuz0NZ+1+1C4sBWt6azaJmARIC4Na?=
 =?us-ascii?Q?vuO9gJPoH7OTlfFwK6Wt7ubF16gCQPY8kkIZCjXWtBHMLc9Z0/QpbHlh1E6x?=
 =?us-ascii?Q?S0FFniRB/Rb+s8fosrbHrdtfSc8N+/7r1ofs2/TpkjFMsyhLhqxKAosSzbw9?=
 =?us-ascii?Q?TPvXsyOB3QBqGRMW4s6MeyGt09rRAzxW/XfcMBPLsdCBqzUQOk/eewK28DU5?=
 =?us-ascii?Q?vvYMNa7S++IfnorKUF7oeN6tJIRayTyZtpBarG8wzzxThjBuSsC7rhpSq8bl?=
 =?us-ascii?Q?egTqFTXsAb8uSGZc9bjdNpJS3G7tMqq4au21DIa0?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d22557a6-9daa-4d02-07b4-08da84099192
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 06:43:06.2091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kaRBWQjkjjbAKIMfCjEnRqVeT+im8Y8GLACl8YAkLW9K7qcFZ4JoqGKnfOSWo2DXr6w4MwTL6VtHX9fPYdZ33Ul7T43x/FvEoO76KWe3p/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3110
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_02,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208220029
X-Proofpoint-ORIG-GUID: PqQXiczszyLI_fHLpGpwdlsSUkmy_F55
X-Proofpoint-GUID: PqQXiczszyLI_fHLpGpwdlsSUkmy_F55
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   573ae4f13f630d6660008f1974c0a8a29c30e18a
commit: 7101ab97e3b00ec1c68d09826bb0521d17783673 drm/amdgpu/pm: implement the SMU_MSG_EnableGfxImu function
config: ia64-randconfig-m031-20220814 (https://download.01.org/0day-ci/archive/20220819/202208190418.1Y3QCIis-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs' could be null (see line 139)

vim +139 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c

7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  137  int smu_set_gfx_power_up_by_imu(struct smu_context *smu)
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  138  {
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18 @139  	if (!smu->ppt_funcs && !smu->ppt_funcs->set_gfx_power_up_by_imu)
                                                                                             ^^^^^^^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be ||.  If smu->ppt_funcs is NULL the code will crash.

7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  140  		return -EOPNOTSUPP;
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  141  
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  142  	return smu->ppt_funcs->set_gfx_power_up_by_imu(smu);
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c  Huang Rui  2022-05-18  143  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp