Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fd6b2e3a-2cb3-5ba2-f376-8c3c5f8e8306@suse.cz>
Date:   Mon, 22 Aug 2022 09:00:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH] page_ext: move up page_ext_init() to catch early page
 allocation if DEFERRED_STRUCT_PAGE_INIT is n
To:     lizhe.67@bytedance.com, mhocko@suse.com
Cc:     Jason@zx2c4.com, akpm@linux-foundation.org, keescook@chromium.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        lizefan.x@bytedance.com, mark-pk.tsai@mediatek.com,
        mhiramat@kernel.org, rostedt@goodmis.org, yuanzhu@bytedance.com
References: <Yv3r6Y1vh+6AbY4+@dhcp22.suse.cz>
 <20220820010257.11488-1-lizhe.67@bytedance.com>
Content-Language: en-US
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20220820010257.11488-1-lizhe.67@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/20/22 03:02, lizhe.67@bytedance.com wrote:
> On 2022-08-18 7:36 UTC, mhocko@suse.com wrote:
>>> From: Li Zhe <lizhe.67@bytedance.com>
>>> 
>>> In 'commit 2f1ee0913ce5 ("Revert "mm: use early_pfn_to_nid in page_ext_init"")',
>>> we call page_ext_init() after page_alloc_init_late() to avoid some panic
>>> problem. It seems that we cannot track early page allocations in current
>>> kernel even if page structure has been initialized early.
>>> 
>>> This patch move up page_ext_init() to catch early page allocations when
>>> DEFERRED_STRUCT_PAGE_INIT is n. After this patch, we only need to turn
>>> DEFERRED_STRUCT_PAGE_INIT to n then we are able to analyze the early page
>>> allocations. This is useful especially when we find that the free memory
>>> value is not the same right after different kernel booting.
>>
>>is this actually useful in practice? I mean who is going to disable
>>DEFERRED_STRUCT_PAGE_INIT and recompile the kernel for debugging early
>>allocations?
> 
> Yes it is useful. We use this method to catch the difference of early
> page allocations between two kernel.
> 
>> I do see how debugging those early allocations might be useful but that
>> would require a boot time option to be practical IMHO. Would it make
>> sense to add a early_page_ext parameter which would essentially disable
>> the deferred ipage initialization. That should be quite trivial to
>> achieve (just hook into defer_init AFAICS).
> 
> It is a good idea. A cmdline parameter is a flexible and dynamic method for
> us to decide whether to defer page's and page_ext's initilization. For
> comparison, this patch provides a static method to decide whether to defer
> page's and page_ext's initilization. They are not conflicting. My next
> work is trying to achieve your idea.

As we already have to pass page_owner=on parameter to enable the page
allocation tracking in the first place, maybe that alone could also disable
deffered init, and no need for another parameter?

> --
> Li Zhe