Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef5e2424-a5c3-4032-71ec-9884d38ec190@wolfvision.net>
Date:   Mon, 22 Aug 2022 09:27:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/3] Add support for the RK356x variant of the Inno CSI
 DPHY
Content-Language: en-US
To:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Liang Chen <cl@rock-chips.com>
References: <20220720091527.1270365-1-michael.riesch@wolfvision.net>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20220720091527.1270365-1-michael.riesch@wolfvision.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWNjWTZmeTJEL1ZVM0dMYzgxZW5hblNMb1RVQUlvdndaYWxZaTUySGZFdTkz?=
 =?utf-8?B?K0tWSk5SOXh3dnJqa0MvRGhIN05rM2JTd0hCRDBYZUczNitsZzV3NkI1MktL?=
 =?utf-8?B?d1g0VlM4RFRyU1RsM1pBdkFYbGRmQ0pjcTVuVStoUloxSnNhRi9qN3RMYUJI?=
 =?utf-8?B?aWtxT1Bad204eWt5VTdGOVozZUdJRWpoT2FkUjc4MnZXUTllUTRMZVlQclg2?=
 =?utf-8?B?UWFJdEhaTElKOEkzZVdGYTFZTDZOUnpjeUNVeExpK3hVTEtSb1ZXamUxNXdN?=
 =?utf-8?B?bE1XazRlRnc3V2k5OXBHMFgybHVMekk4YlpZVVVSQWdIanZNaWEyVFhMSzZw?=
 =?utf-8?B?TVFjbmN4KzlLV1RQOGNoNEJ3MFMxZXQ1eURWODlQclVmN0w2ZjdaQzFhNDdi?=
 =?utf-8?B?cGhvd0JSaXpwdWRIZnMrOXB1R0pxajZwaUFNOWs5bDA5SjZYWFA2MWxRZTFN?=
 =?utf-8?B?dzhDbDdGNDlnT0tpWS9zUm10UlJ3Ukp4Y0IwOFBIWGltNkxxOUJkejZZS1V6?=
 =?utf-8?B?bDhXWUlYTWpVejdKOWdoVWlSSEVwaXV1V2x6eExHK05XOXhyTEtScHNyUzhK?=
 =?utf-8?B?ZTg4NWRQdGltdWIvQWtFSXFHbVFpaDg1U0J2amxNODkyNko4L2c1cEhNcWVF?=
 =?utf-8?B?VFJyNDBZZDdsZjRYV0NXKzMxb3Vkc1JvWHoxS1FqSGpGTy95TVR4RS84YzBk?=
 =?utf-8?B?cWNrSWVnUGswalZWbVJ4Sk1lenhvYU0zY1llSUl4aXhwcDJpTWZxOHlraW9J?=
 =?utf-8?B?ai9BVTFNbUVmSjRkOXhLT3E0dUFWb0syQThzVHVzSVZ3SFpNNzhUREttMFI2?=
 =?utf-8?B?NzJCQmFWUGpDbktMRWZoOGt3dWVFbUIyM1J3NlVqZnVoWmlVaEpQUmp6Nldn?=
 =?utf-8?B?c09KWElwMmdWNTR4K2tmclJrYnZLUituRW1RVFk0b0poSXZKNVhDMHp3N05T?=
 =?utf-8?B?V2xBL3VSRFBmTjhnWjB2dEJ1MVB0cG5RZmpGYW40OUt1YUhmaFBjeGpKb0Yw?=
 =?utf-8?B?ZTdWWUxQUWpOb3gwRG5pQjlDTi9hOGRpYUlaTjkxTWVoaEVCSUx4K3BjbER0?=
 =?utf-8?B?ZkRxUDJkcGE2T2RmUjl3L0tXUDdUT1VibzQxWVJxOEtHZDM2aVRpYjFVbEhF?=
 =?utf-8?B?b1Yyd005OXRjQThnajFBby8vNDlHMEVwNWhKLzdGbE1LdDNtSUVvem1qV2Y0?=
 =?utf-8?B?UG1kUTNod00rblJZckwyQTRqazhRczVHQ1BMc0tPcE0wa2hlVStudGxFajFu?=
 =?utf-8?B?V0t3WTlvaFBna29McDhyb0JYcSszUHBNWmgzUmNTNGFOd3RNakR6aS90cW1y?=
 =?utf-8?B?aktJUTF3a0ppZ3ZjcXlkdlRleHhRTE1qMTB4ekYwczFJaU9FeWVEL1E2aWlZ?=
 =?utf-8?B?WHh6ODR3Qm5xY05sWlNBbkhmT1lwLzFoZjVrcTc4TCtqOWRpL2hieFJ1cFFr?=
 =?utf-8?B?ZjY0M2EwL0VqN0x4djRwc3kyNUhQek16bFB6T2FtNktUR0VVTmhwQnRRa2J1?=
 =?utf-8?B?WDZQOWhsSk9IanhUTWRVOFA2TmVaaHM0K29KUkE5VVE2dTZweDVjblNoaVVK?=
 =?utf-8?B?cS9Lc0hGRXc0QlhYTkNQK3ZGc0R3ajdoKzQ1Q1hkSXp6aW0wMEhnMWNGb1dI?=
 =?utf-8?B?bDFEV0ZST3NYNW42TGlaamc5bzA1T01yN3FVbFBFKzd0djhzUGR1QVdtVHM2?=
 =?utf-8?B?UFpDSldyRmtyZ21JNE1tMkhnVDI0ZkxhVTNPNlBsK3EzNnRmTUliTUExMXp4?=
 =?utf-8?B?QmNuVkt3SFhjb3pkclozN3pSZ1NPM2V0T0swM0Q2VlFnTDFoSXJqWlRhR0lR?=
 =?utf-8?B?d0dIWW80WCsrVi8vWnZnQVJFeUwzaWF6bXlTV0JkT0NkeEthSTNNai9WNmt6?=
 =?utf-8?B?OE1JNVdaZ0JMRHg2OXRmdDI0dUV6VEUva21vOHVlMkFoeFYvZ2xkdE1uRW15?=
 =?utf-8?B?UVJLSjZQWkY3WUF2dCtKeXc1dEZ1L3l3czliblVKZHBKU09wKzMxOGpLcnds?=
 =?utf-8?B?eGVrNUV4eWx4NU1WdlBNTXZHTU5zaExwUGxZNW9LWVpicG9XdWZjam85cS9F?=
 =?utf-8?B?U1V6T3hZbzlaMFc2N1RwV0kzT252T3RyZTJxeUxQSXI0anhIQzYzdXdFdFkr?=
 =?utf-8?B?WjlBYnZ2dmNVYTZMb3FWczJ2dzVUL3E0aXEwa054NkNYdXNITUFlZ0NtZ21H?=
 =?utf-8?B?Z3hCTzNLZ0dwc1lOQkU2Z3N5K1prdUsrMHBtK3dTN1k2RXN0MWtLS2Zxb3Rz?=
 =?utf-8?B?UC9VMXg3ZG1OV0hnTHN1Q3JvQmZnPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 42100465-a58d-428b-387d-08da840fd47f
X-MS-Exchange-CrossTenant-AuthSource: AM4PR0802MB2131.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 07:27:55.3642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sg233yJZYNs7AAUrbiUXVT5elfedHm+qJw2y88E0o5oOn0cTl5be7x9d0ZOnUeySRw9coc76y7yMi8hBJQOjjg5RMWtLfncrGmm73dp2MDg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5174
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/20/22 11:15, Michael Riesch wrote:
> Hi all,
> 
> This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
> can be found in Rockchip RK356x SoCs.
> 
> Please note that only the basic operating mode is supported, in which all four
> CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
> lanes to ISP and two lanes to VICAP) is not supported.
> 
> This has been tested on a Radxa ROCK3 Model A board together with an IMX219
> camera sensor and a patched version of the rkisp1 driver (with support for the
> RK356x variant V2.1 added in a very crude way).
> 
> Looking forward to your comments!
> 
> Best regards,
> Michael
> 
> Michael Riesch (3):
>   dt-bindings: phy: add compatible for rk356x to rockchip-inno-csi-dphy
>   phy: rockchip: add support for the rk356x variant to
>     rockchip-inno-csidphy
>   arm64: dts: rockchip: add csi dphy node to rk356x
> 
>  .../bindings/phy/rockchip-inno-csi-dphy.yaml  |  1 +
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 12 ++++++++++
>  .../phy/rockchip/phy-rockchip-inno-csidphy.c  | 24 +++++++++++++++++++
>  3 files changed, 37 insertions(+)
> 

Gentle ping on this one. I am aware of course that it is still vacation
season and the merge window was there as well, but it would be nice to
have some feedback.

Thanks and best regards,
Michael