Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 10:33:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     lkp@intel.com, Larry.Finger@lwfinger.net,
        gregkh@linuxfoundation.org, hdegoede@redhat.com,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/8] staging: rtl8723bs: remove function
 rtw_odm_dbg_comp_msg
Message-ID: <20220822073352.GA2695@kadam>
References: <cover.1660916523.git.namcaov@gmail.com>
 <7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1t23li77Rllk2wfQ0RH+n57/3Z/tLzKdlC91zMhtR7+vvR8lNVVH+Y3IK12g?=
 =?us-ascii?Q?3z6yG/J7Br1hBTnL+OKNmfiIfwZX94wC1GVkC3MEGlo/vVjzqYdhcLkYucAK?=
 =?us-ascii?Q?OQrxQEW1lnPOs9lEGLWRJ+Hf0oqpMkFTaZDEima7MPdL4fdFKK4a86s89/Eq?=
 =?us-ascii?Q?qH/hAIoSED8+sbfJDRH+2+AIFsKNhIvXJpY90m1CID7xt0mRKzchWWI4Jc8C?=
 =?us-ascii?Q?B6i+z7UvNj1RwHxuwco43Rvkr634aWcqOfOE7CxCEqzrSyYosiPKUILhGs9q?=
 =?us-ascii?Q?CyhOv9nw6pdNKuF4ULlYX4sMR6reNQ9aH63UcuOYvAitJaku3AxsGC7ZbIPj?=
 =?us-ascii?Q?FdX/UVIkYN29Vql3PkaUzZI50MsFqnq5Ex6naTLDAEcm6FxM738pHLHeltoY?=
 =?us-ascii?Q?wmQ9kCPSg3aY9t/Ux2C4WUavEZ19q8uArhF3fKCRh9S9sCGdZuRl6hTywZbH?=
 =?us-ascii?Q?KaXT59IObmm0nevP5zROYpv86uENFXmpdijufWyOn8RSVXXO3GLI6U6y9PQS?=
 =?us-ascii?Q?TCrtFm/S/CCLqXAyorIJuSwKsC98jnv5Au2fwT9e69iF7rSf/eCPkNdt2jtk?=
 =?us-ascii?Q?gD9+wU6ZmnKit9JfEEOtwy6lbITagDT9HngyWx0ThkKfZ0orXNnR7grE3w/s?=
 =?us-ascii?Q?y79t+FSgW5PQzJJizp0RAq+w5yCEO7qt0aYzf2CnhVPoQfB5XrcfM3aI8Ibd?=
 =?us-ascii?Q?c4t06kcIbD2DTH8yoTZOisvRHL7cSku4zy+JYmnrMLsPjxueytgb0F7tgSEn?=
 =?us-ascii?Q?YQONPxHE93jvoyIsumYysyqblslKV81YwXGdkJfsFG6BWSVxBHsi2GZi12sa?=
 =?us-ascii?Q?ADaEQFBrkPTMCDZJxoA09hxOOwo9FxLiw+gtW03B5cR6qfeZnIpWfYoqyXE0?=
 =?us-ascii?Q?X4tQQ6/xzbf7waMq+f/pEtm1lvXe6s5zgbZtL88Qa2I24NbIsHNOmy484UcT?=
 =?us-ascii?Q?enbXY9PM8+VXRb5TCbcOUV6QiU7c9QqXcMy/LIyKuYF62b3oRR6EeRA6wuy2?=
 =?us-ascii?Q?CjRSzJRJ983JiwYxmylef6vqzYPHdvlhLbVEqujoxD7t1k1WDl6eTuR1BXRR?=
 =?us-ascii?Q?dIxKTKD3q63n6rotsTn44GvUvopgUzfCIMtLDEL13b8xNc5YQSJda2AFUVbw?=
 =?us-ascii?Q?OXOS8sWbcrKQ0Ivk/Iaxxd9eVQK38jvtKUasFyFs3QigqhgjjiU3+Qe6Lp3L?=
 =?us-ascii?Q?juNo7oOsGWqMoH1rxcZxkbcNLL9sViIQw8R0YlujCva2ejOBIwd5LmrR+Vv7?=
 =?us-ascii?Q?6ADTuQy7gsqQyARPBZE+T6qHjp/omLjsX8jTk6CPQkh2a7VTFEGycqm87M3n?=
 =?us-ascii?Q?h49q58QiNfRnGxMpnNDOEUYrlpAqAVE/slL67nOZUbe0oN+Omy6grDnLbzcJ?=
 =?us-ascii?Q?b98CDU78qnaC4gfpsWeGIoe+Jku5Ne0nVQKO04bKJ5Nf1g8A0YUT74B/OVBl?=
 =?us-ascii?Q?e79LB1umoLgjmHF+7kH0vEjJwAMc1vzu1OXVPdcu8RQMKqvOnfW0ufZNkxnW?=
 =?us-ascii?Q?TxoJT1yy9zTP9EfnJ/FYx/1+sBv92By4oFJrX6EpicVoiIsJx45ndg4KnyVV?=
 =?us-ascii?Q?3FwiF64KIjrXj5bAo/2ANFWOhSm7PvexqllhU+IZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7c1930-cd44-4f55-4f48-08da8410b496
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 07:34:11.6844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /e7/pnyJ0gVlmUHOtNsk6UmeATeJghA+X91/lJSuAU8UdRByk60jYrr9NMuz82CbwRSTmHCt+VSkrwAzJu8jnLHAy+4udTkltsWHdeYFXQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5552
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_04,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=892
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208220031
X-Proofpoint-GUID: b3cV_Q00HKDU9m6FCMKlyWF5-c3z1wrm
X-Proofpoint-ORIG-GUID: b3cV_Q00HKDU9m6FCMKlyWF5-c3z1wrm
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> because this function is not used.
> 
> Signed-off-by: Nam Cao <namcaov@gmail.com>

This patch is fine, but in the future can you please treat the subject
as separate from the commit message.  "because it is not used" is a
sucky commit message.  What is not used?  What are you doing to it?  It
doesn't start with a capital letter.

Here is how your email looks like on lore.

https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/

Try to find the subject in the middle of the block of text.  People are
often only going to read the body of the email.

[PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()

The rtw_odm_dbg_comp_msg() function is not used.  Delete it.

Signed-off-by:

regards,
dan carpenter