Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1660916523.git.namcaov@gmail.com> <7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com>
 <20220822073352.GA2695@kadam>
In-Reply-To: <20220822073352.GA2695@kadam>
From:   Nam Cao <namcaov@gmail.com>
Date:   Mon, 22 Aug 2022 09:47:30 +0200
Message-ID: <CA+sZ8B-HzLbLdBP5dMQg3j-201Ca6QxjiRjO=20hMADbMCgEOA@mail.gmail.com>
Subject: Re: [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     lkp@intel.com, Larry.Finger@lwfinger.net,
        gregkh@linuxfoundation.org, hdegoede@redhat.com,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thank you so much for letting me know. I will try to make it more readable in
the future.

Best regards,
Nam

On Mon, Aug 22, 2022 at 9:34 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> > because this function is not used.
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
>
> This patch is fine, but in the future can you please treat the subject
> as separate from the commit message.  "because it is not used" is a
> sucky commit message.  What is not used?  What are you doing to it?  It
> doesn't start with a capital letter.
>
> Here is how your email looks like on lore.
>
> https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/
>
> Try to find the subject in the middle of the block of text.  People are
> often only going to read the body of the email.
>
> [PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()
>
> The rtw_odm_dbg_comp_msg() function is not used.  Delete it.
>
> Signed-off-by:
>
> regards,
> dan carpenter
>