Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 11:29:00 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:1948
 dpu_hw_catalog_init() warn: possible memory leak of 'dpu_cfg'
Message-ID: <202208211344.YIwVJkR3-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OOphC4BDFnZfcjDKRRBtJOZDMv6w8ALrVdH8zhKqwdeYi5ARoLQ7Tq1dwW4/?=
 =?us-ascii?Q?EQV/jPs/7PoOO2WrHR+2MTx78rA+bdc55tau15KX/VwCmd8kV/vLBurasyyM?=
 =?us-ascii?Q?qUnL9FtJoBEfYonaFjQJ0iberNVB6O4dlo/KvR3iId044aEgkXDMsZksNfOj?=
 =?us-ascii?Q?DluJl5X/wiTGyUG8sLwBkc6w9hPKftgxL5dfa/Gh0hcc1wA3Xmi/QbSLSuis?=
 =?us-ascii?Q?42SVB98Nyaa5pMeUULCnNAzBs9ljz9npX2qvX2HCbtv1SZoQXW7MoPWBZPzt?=
 =?us-ascii?Q?BMS8icCNNzIBfTDGA6Flnaj2oHvQnWcI3YaD/5o9WofOlMOplxubbvdlU1Bp?=
 =?us-ascii?Q?TtqTNHRXPYPPTPJqVK4ho8eDu9FdDaX3fW9jdlq2kKmmnzjUshBTZOfeDgk6?=
 =?us-ascii?Q?kr4Y7XIreluSFPU27PDfthFHmEPZkRRezGUwMkuwQwWk3GupZiMxajQU4sMq?=
 =?us-ascii?Q?lSQX01w86vrbPeLu9sL9p5SHsIPXSahErAlpquJ699gUlQopQSbE/lNZ6Shq?=
 =?us-ascii?Q?SGdMj7g8CTCtNM1BleeEqWDZ9sZsFL2FIpZfctpBaL/iMrW42KSRT6ehljKk?=
 =?us-ascii?Q?FcXyRHgxnym808tVyDyrAjo29a1jPmDOT/kfumgJAkujNX2EG4K+N4j5ACDB?=
 =?us-ascii?Q?tRHx2Xu6jrDD0Xy8DhI5Kdn41Zh3GxMLfDnLLZyg6fpncI3z7QK8EfgOqntk?=
 =?us-ascii?Q?nnacbbQsFJgGOYq6MLx5qe8uhh8xJVzmvq7ESAV+cy0wZwFH6YG7zqMEgxNU?=
 =?us-ascii?Q?DWNw6IDq6tAC5e++z3fnnUgSIoqmBg4ymqIKgQwO4Z4c42fV4DhH+2HM6keq?=
 =?us-ascii?Q?4Ek2tLnLrohNHjjEziAB0atbFpdAmM7M8PIRcjVwkE5hToteiMs+mDTW43O7?=
 =?us-ascii?Q?v+A/zWjaTbyX3wEUSApjXzhV/Rahv8DZh9o/aAaTnzc/14HULxoEBy5i1oqO?=
 =?us-ascii?Q?AlSXEfQ/S332ZYIYcj2+XVEyPSUA7foomQBsEqiRmHX8ZEM+PCNbYn7+k/VA?=
 =?us-ascii?Q?+je/zPt7IZGvJh0/Jepig6ofty7QHNL/Fan6i+OuAaPoL9YQMNZ0iyC0DXE7?=
 =?us-ascii?Q?EEAvP7IZ+JAtQSRPyODcxCP7/qAXWtqxFO6KqbKtlh5F73uqYFAL8drekILe?=
 =?us-ascii?Q?fmTC/j/ExaQwOjilERJBZ+JrrdiAuY9w8CUjLVd7SqPO12/fyH1650uyD8TR?=
 =?us-ascii?Q?livXS6pj4VkCGy4pU/+uJXn78iVW/VE0YPvyITZ37HiJagZmTH9gsBV5kaDN?=
 =?us-ascii?Q?4Yczcb8stSA8MKZ/TLEBcm/71C9fu3BItZVSFNCtdJeW5LVfJOMK5oRCeOHY?=
 =?us-ascii?Q?jfU/aqT1wC/ePwqT+rPkHOiu7L6KfUR0Ogfq86/Dfh4t+Zi0FuWls17jxKq0?=
 =?us-ascii?Q?fQPmynpaJzOi4NuubMkD7pZD+l4Cx2OvwlQUT9YFpPxl6TvDb1l8oPkiFMxr?=
 =?us-ascii?Q?pjDdgorzHPaEc2vSc6qQ/ZOAPgQ7YVKlJcAfEM3fn04JA25jeSPuR9G/QoH9?=
 =?us-ascii?Q?riBRcj7ekd9W/LgkBYnWkKB1nN7s3Cepcyl2SSyPHoMQacyC39keHiFzEwOk?=
 =?us-ascii?Q?kmS9q6lOewUeojgMvg2kLN+Wac9Xaj5cz2t3VJzFoQinHrNvROPgTBqdnDZt?=
 =?us-ascii?Q?JA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18525894-5981-43fe-58c8-08da841868ad
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 08:29:19.8025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Cz5Th664SOn47KDJFk9hvZGU3TeI3lOnS9i3qCxJb+MTyd0hjVnYtzee+kYkuQYx6IQqhX+kTYJyBc5K7xi8T2pSzjdSx4arAVkYntiU3w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4903
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_04,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208220035
X-Proofpoint-GUID: o3rb_rq3K-4N6PAYjkCSiqh9VUgoz7QO
X-Proofpoint-ORIG-GUID: o3rb_rq3K-4N6PAYjkCSiqh9VUgoz7QO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: de7d480f5e8ca6eace02a725abdadb9ea13294ef drm/msm/dpu: make dpu hardware catalog static const
config: microblaze-randconfig-m041-20220820 (https://download.01.org/0day-ci/archive/20220821/202208211344.YIwVJkR3-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:1948 dpu_hw_catalog_init() warn: possible memory leak of 'dpu_cfg'

Old smatch warnings:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:1953 dpu_hw_catalog_init() warn: possible memory leak of 'dpu_cfg'

vim +/dpu_cfg +1948 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

de7d480f5e8ca6 Dmitry Baryshkov  2022-06-02  1937  const struct dpu_mdss_cfg *dpu_hw_catalog_init(u32 hw_rev)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1938  {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1939  	int i;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1940  	struct dpu_mdss_cfg *dpu_cfg;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1941  
de7d480f5e8ca6 Dmitry Baryshkov  2022-06-02  1942  	dpu_cfg = kzalloc(sizeof(*dpu_cfg), GFP_KERNEL);

This allocation is never used

25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1943  	if (!dpu_cfg)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1944  		return ERR_PTR(-ENOMEM);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1945  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1946  	for (i = 0; i < ARRAY_SIZE(cfg_handler); i++) {
de7d480f5e8ca6 Dmitry Baryshkov  2022-06-02  1947  		if (cfg_handler[i].hw_rev == hw_rev)
de7d480f5e8ca6 Dmitry Baryshkov  2022-06-02 @1948  			return cfg_handler[i].dpu_cfg;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1949  	}
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1950  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1951  	DPU_ERROR("unsupported chipset id:%X\n", hw_rev);
3208496720a180 Dmitry Baryshkov  2022-06-02  1952  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1953  	return ERR_PTR(-ENODEV);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  1954  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp