Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2087293rwa; Mon, 22 Aug 2022 01:40:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR4N3v4Lu4E34DPhSTtv09P/Ot9Lt7lDKB9VnsLGQ3mzmrPyB6KAGfO0ttp6oy2aPIMs0gRE X-Received: by 2002:a62:1441:0:b0:536:ac1:504b with SMTP id 62-20020a621441000000b005360ac1504bmr15612982pfu.71.1661157599923; Mon, 22 Aug 2022 01:39:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661157599; cv=none; d=google.com; s=arc-20160816; b=nW8TmIvQJtqG2iQ+FAQoPMYQM2cSqr94eoBfZYuqTGPOOO128rgMaUodEYz5C8LYX9 H6Tx+DfiBMyPVjmGspV+3gYMINaJ3uPwKu2nhkcxIuo9gqr9+9wsArSVCWqYzDpVms+M cNPAvvGIzyL2xzYgd1X0JHLXhiyc5Dw1Uw/CDB+pp3Thfhi+bUCsIfQxivPSXgVRDCtm r669GqSdNeuHZlUw9WjFeedNbsJYXO3KuA5vtFauoXHi/nVKlcH73H0rJUTHbSb3n4/K hxeg81YeRNLU0lrc46nB+sSI4+dv45ezxbSwXqAeLwR1dKyIyKHmTZxp2bLc3p9s8yUV xp9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=Fy/d/XAb6vTN4trgjkzV7eMaGE/wqYSvDDnSrzB5bmU=; b=xuC3a+8muYwxv3ljhp6oE1336MBFjKnQb+fAExGE9Ty8erybAs23BrvTNOCs3/JegE 14AjRMo/FnPLXno/uk6U02xx7BbIvrAFBjH0HeH62rC4eYU9kfKAmAWOd15hmhU7iijW TIPOaN9qxF/AMiXdQdspNF7lBEqgPxHV8I++b0/BsO7IaRTAogtMHp+vLHOHNHYjpbKp khxEF0ULmANus5dBOLtUkL9iHJ6OusC3HIOl/ZBvQjaTes5yv/vMtMYAiU8Nz10G6Hv1 q7z5nLT0fEs7twJUQzJ3Px7amXimQQtE7779/qY/3MjBPBG8XCqwC2wc37/z5eqUs51N oPNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YGWt3q6Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a056a00248100b0052c78eecaffsi13189703pfv.174.2022.08.22.01.39.49; Mon, 22 Aug 2022 01:39:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YGWt3q6Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233586AbiHVICW (ORCPT + 99 others); Mon, 22 Aug 2022 04:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233536AbiHVICA (ORCPT ); Mon, 22 Aug 2022 04:02:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FCC02B19D for ; Mon, 22 Aug 2022 01:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661155318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fy/d/XAb6vTN4trgjkzV7eMaGE/wqYSvDDnSrzB5bmU=; b=YGWt3q6YkPiVMsXOEqGJGtvwO19XKI4qhNgmrP57i76ujq3lknkw0v1DvSJqvr7XKmWKWJ brv5H2q2NekC9QDPLyDM4Joh6iOQtis1FDhSwTVosJKeQEGjNg217TfuhHlp/47BEqqWDM zNg3xO1Sy0Y8/GG/R3iyxPcK/3x0WoM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-Kl5qBtN1OLq5FGkeuJ_I-A-1; Mon, 22 Aug 2022 04:01:55 -0400 X-MC-Unique: Kl5qBtN1OLq5FGkeuJ_I-A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE4D685A585; Mon, 22 Aug 2022 08:01:53 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.199]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62394141511A; Mon, 22 Aug 2022 08:01:48 +0000 (UTC) From: Florian Weimer To: Menglong Dong Cc: Segher Boessenkool , Nick Desaulniers , kuba@kernel.org, miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com, luiz.von.dentz@intel.com, vasily.averin@linux.dev, jk@codeconstruct.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel test robot , linux-toolchains Subject: Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc References: <20220816032846.2579217-1-imagedong@tencent.com> <20220818165838.GM25951@gate.crashing.org> <20220819152157.GO25951@gate.crashing.org> Date: Mon, 22 Aug 2022 10:01:46 +0200 In-Reply-To: (Menglong Dong's message of "Sat, 20 Aug 2022 19:00:41 +0800") Message-ID: <871qt86711.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Menglong Dong: > /* > * Used by functions that use '__builtin_return_address'. These function > * don't want to be splited or made inline, which can make > * the '__builtin_return_address' got unexpected address. > */ > #define __fix_address noinline __noclone You need something on the function *declaration* as well, to inhibit sibcalls. Thanks, Florian