Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2143117rwa; Mon, 22 Aug 2022 02:58:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR6oMbrv6BzljkWsdhPQdKLiA8mlIJGUb9Y7NN38dXOrKGATLnMGm/Pm8+KmoW5VFcPTtvwI X-Received: by 2002:a05:6402:3711:b0:445:e264:beed with SMTP id ek17-20020a056402371100b00445e264beedmr15707073edb.136.1661162289215; Mon, 22 Aug 2022 02:58:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661162289; cv=none; d=google.com; s=arc-20160816; b=zI+8OIZChKcBaSXtIqG4XSNJP3aundauAQg404kaNc4pfFmv//zzkQ07s8jkPbF1i8 GM/GrweySGiYtpYoyCTEhOUopvnni2hxlF0OsB71OEoXvH4agOkXrUVpmFlS1hJT7bfr 6eAcaxqXySfCfxOH062iGGIHf1VfnVz4N9QcKc7Cr9XYUc91/8GMjkDr3qbC8ydf9DOQ N3B9w3G20dCMSRa/EWtJ2H6DElBV/dgq7lwCiXY5W5mY0KUsKnnf6YvSfnRSG/x8MZEe vZcUXt8eWGYL7zHwBkMfzq1v308XYmThEBE50CJd2V7wRJUvcWWcevyAumhVrjgM30UH DgOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=ixrzf48o81ZG4Mo8flPV032r4wlVh+vKK+0eiWqJd9A=; b=bx1+IRvp7Ro0xktCmOenGjJ1uCPOzy1caulrHHc5EQSOtS/SZnJ/g1d8mqYM3jKCNW RfN1b7Wc4rxVkFKHixY95neEkg2jx5XPEoGeeVexPQ7o//9jGixDf8Ip9lJNjUNw3W/S r5jZd7/OD8L3yp7ycAWl+5Y2L6rOOtI8EOapvmWjlPWhGy4kJBdqndPpNY05ji+gj+l3 xEPbwVpKcwZeygn6pnXwBv65ujle+6q0xIDXy0mo6bKs2F5gqNlqko4z1NLdeHBbHdL5 SU217aqjjlFRnzxIVJLs/bPO15ejOgIMW4TLsN486A4Ow2qrJ0TedHgL1JQ5Otegy0/3 UREA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U4BOBx2l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020a05640235d500b0044688da9bfesi5706576edc.225.2022.08.22.02.57.44; Mon, 22 Aug 2022 02:58:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U4BOBx2l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234435AbiHVJWp (ORCPT + 99 others); Mon, 22 Aug 2022 05:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234395AbiHVJWR (ORCPT ); Mon, 22 Aug 2022 05:22:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BED1131EF7 for ; Mon, 22 Aug 2022 02:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661160101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ixrzf48o81ZG4Mo8flPV032r4wlVh+vKK+0eiWqJd9A=; b=U4BOBx2lsABi5vsn8R70AaQ0rqLByxOnxLdaXFf2fWIGT1RPgEQ8nNOc2jkhelG7pqSprq hEMRSL9cDZKFaWjcKl8xYvy6GTeiNeGq+jaOX8rfZer3Hc4Oz2DOXqV296MmbjZf97pwpu qRJX4l+N3nDPJnhf7yJ0QvzsNUGWMhU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-X6vpEYv1Mlq9hFQ5ng612w-1; Mon, 22 Aug 2022 05:21:36 -0400 X-MC-Unique: X6vpEYv1Mlq9hFQ5ng612w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6DF5299E746; Mon, 22 Aug 2022 09:21:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id D640DC15BBD; Mon, 22 Aug 2022 09:21:33 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <924818.1661158094@warthog.procyon.org.uk> References: <924818.1661158094@warthog.procyon.org.uk> <20220821125751.4185-1-yin31149@gmail.com> <000000000000ce327f05d537ebf7@google.com> To: Hawkins Jiawei Cc: dhowells@redhat.com, syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com, Marc Dionne , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel-mentees@lists.linuxfoundation.org, paskripkin@gmail.com, skhan@linuxfoundation.org, 18801353760@163.com Subject: Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <992102.1661160093.1@warthog.procyon.org.uk> Date: Mon, 22 Aug 2022 10:21:33 +0100 Message-ID: <992103.1661160093@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually, there's another bug here too: if rxrpc_wait_for_tx_window() drops the call mutex then it needs to reload the pending packet state in rxrpc_send_data() as it may have raced with another sendmsg(). David