Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 09:43:31 +0000
From:   Charles Keepax <ckeepax@opensource.cirrus.com>
To:     Paul Cercueil <paul@crapouillou.net>
CC:     Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 18/30] mfd: wm8994: Remove #ifdef guards for PM
 related functions
Message-ID: <20220822094331.GK92394@ediswmail.ad.cirrus.com>
References: <20220808174107.38676-1-paul@crapouillou.net>
 <20220808174107.38676-19-paul@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220808174107.38676-19-paul@crapouillou.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Mon, Aug 08, 2022 at 07:40:55PM +0200, Paul Cercueil wrote:
> Use the new RUNTIME_PM_OPS() and pm_ptr() macros to handle the
> .runtime_suspend/.runtime_resume callbacks.
> 
> These macros allow the suspend and resume functions to be automatically
> dropped by the compiler when CONFIG_PM is disabled, without having
> to use #ifdef guards.
> 
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
> 
> Note that this driver should probably use the new
> DEFINE_RUNTIME_DEV_PM_OPS() macro instead, which will provide
> .suspend/.resume callbacks, pointing to pm_runtime_force_suspend() and
> pm_runtime_force_resume() respectively; unless those callbacks really
> aren't needed.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles