Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2173531rwa; Mon, 22 Aug 2022 03:34:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR62m0Otqt5ewSYDYg/caMvYISLGtwyVacYDBbi8xnNofLOdJ+bFdz9xlnrLmm6dCzkFKcZp X-Received: by 2002:a17:907:97d5:b0:730:9eac:d965 with SMTP id js21-20020a17090797d500b007309eacd965mr12147866ejc.353.1661164441227; Mon, 22 Aug 2022 03:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661164441; cv=none; d=google.com; s=arc-20160816; b=i2IUdds02hh6zhgR+lD0YqpoqSwD1vwnmmQZFdqpplxuQS75YIxpgF+5BQ+n8AUn8J nv7hlMYCCs1FbwqvdvtwQbSqhMuOP7NUC72shwpWBwQ0gAjRFdd4DDXfKVvkDrcGQ/lr Bs/m/+9+5r61uTPbTP5wfcmJkI9D0HaVdLVvrjfqBv+O8q9QECaQyitfqqQNhN+f0hnF Y60yneoAK/ZLCSke1z5mgfYXYHRvnkYmtjBCoyj87uvfmacZZh/fZ9W9HPhu4qeTa6om igvQ/3VRAe2HdCLAMu6X3kpZ7tVUw4A/P46p+cIFJdRRz2/iwb/XpNmSCaI84K8PW+tJ 77QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=r0riuf1Dq5JdI/JpJqMvdRvNYSOaGKhjL+NT9Kkteg0=; b=0gWysqEclfMqdntoEIQAcQxSk1UB6Fb5FEAm5rVgXLEvOad9ACT15/5Er34/rxCNkz vWc6IuvGO0kFidnpO3JXQ4jdpH0+yJMj7Kv6rH6CDwzGjq9SuS5AvZ2cZpf+D68zhBLk Zax1VM1Qa9yP0hdNrr1CYPCC85Myj4z1TGCyZ2TRORZmuZeR15x5aABd4RcGjvZay7W7 das3mQlJg+cwnUgUVPtl/EMK62hOoX4LBWjCxCksfR2oW0SHdjJF5zz5I7N4uw3d2opw AaROEoARrBEc4XOEB7Jsw4mKSECJebZwgRnjhxemhEjffjcpxSH+hyaamEsnbzgOhC51 /Kmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a056402254b00b0043e42b0f87asi9922134edb.306.2022.08.22.03.33.35; Mon, 22 Aug 2022 03:34:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbiHVJUM (ORCPT + 99 others); Mon, 22 Aug 2022 05:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234063AbiHVJTt (ORCPT ); Mon, 22 Aug 2022 05:19:49 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE1C2BB08; Mon, 22 Aug 2022 02:19:47 -0700 (PDT) Received: from droid11-sz.amlogic.com (10.28.8.21) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2507.6; Mon, 22 Aug 2022 17:19:43 +0800 From: Liang Yang To: Miquel Raynal , CC: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: [PATCH RESEND v8 0/5] fix the meson NFC clock Date: Mon, 22 Aug 2022 17:18:32 +0800 Message-ID: <20220822091838.18528-1-liang.yang@amlogic.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.28.8.21] X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK' which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is the divider and bit6~7 is the mux for fix pll and xtal. At the beginning, a common MMC and NAND sub-clock was discussed and planed to be implemented as NFC clock provider, but now this series of patches of a common MMC and NAND sub-clock are never being accepted and the current binding was never valid. the reasons are: 1. EMMC and NAND, which are mutually exclusive anyway 2. coupling the EMMC and NAND. 3. it seems that a common MMC and NAND sub-clock is over engineered. and let us see the link for more information: https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com so The meson nfc can't work now, let us rework the clock. Changes since v7 [8] - use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of ARCH_MESON || COMPILE_TEST || COMMON_CLK. - collect the review and ack Changes since v6 [7] - use COMMON_CLK instead of !HAVE_LEGACY_CLK Changes since v5 [6] - add change log for patch 3/5 - add patch 5/5 to fix the reporting error of test robot Changes since v4 [5] - split the dt binding patch into two patches, one for fixing, clock, the other for coverting to yaml - split the nfc driver patch into two patches, one for fixing clock, the other for refining the get nfc resource. Changes since v3 [4] - use devm_platform_ioremap_resource_byname - dt_binding_check for mtd/amlogic,meson-nand.yaml Changes since v2 [3] - use fw_name from dts, instead the wrong way using __clk_get_name - reg resource size change to 0x800 - use reg-names Changes since v1 [2] - use clk_parent_data instead of parent_names - define a reg resource instead of sd_emmc_c_clkc [1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com [2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com [3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com [4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/ [5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/ [6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/ [7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/ Liang Yang (5): dt-bindings: nand: meson: fix meson nfc clock mtd: rawnand: meson: fix the clock mtd: rawnand: meson: refine resource getting in probe dt-bindings: nand: meson: convert txt to yaml mtd: rawnand: meson: not support legacy clock .../bindings/mtd/amlogic,meson-nand.txt | 60 ------------- .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++ drivers/mtd/nand/raw/Kconfig | 2 +- drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++--------- 4 files changed, 131 insertions(+), 105 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml -- 2.34.1