Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 13:18:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Xavier Roumegue <xavier.roumegue@oss.nxp.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-media@vger.kernel.org
Subject: Re: [PATCH] media: dw100: Fix an error handling path in dw100_probe()
Message-ID: <20220822101851.GC2695@kadam>
References: <7213b90d0d872be154cff81aec1ad8a4a77116af.1661161223.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7213b90d0d872be154cff81aec1ad8a4a77116af.1661161223.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WfD0zhfYr3b4WUp1XuBh/6snlAuFx7ryk8EA3MXg7+gZ5/NOAMblHFck4bpw?=
 =?us-ascii?Q?znJlNMaKu+xeeGYxXR9eJWRlwcADars3Dw0OwCn+2iRf/sJMh4MbqLTdcuGb?=
 =?us-ascii?Q?bNgmysc9M5RK47gq1KnK6Fk07RgshdPbVqmERxQIEvGMixX+xOQ4xpNPbSgG?=
 =?us-ascii?Q?dGTPntltOr9E6G5WQ+1ufw9FQctHOMObtR8h/vtyxPhp9PAU7rx2/elmQRbG?=
 =?us-ascii?Q?xZhv/qe+R9AFfLghJSlksiA/eMLutPp8HuY2hYS0DnV4uDA9x6n0db66bwvh?=
 =?us-ascii?Q?NPvRiWyrQ7PWdY2EVDvsVFaa3q9tt3HEdBbSDg/yRshj7UYSKKULM37HaB3J?=
 =?us-ascii?Q?zp1Kvx5LyKF1A7l2nJVbcFwl2hQ41Q9HcHQfKkkXERcYbcXJNxAGfvA2G3RN?=
 =?us-ascii?Q?bEdV6nqlmiaAwGsVIKx3ao/v4QZF6t6zM2uMBMsZG5mHeShJ0oYiiV/VmKRp?=
 =?us-ascii?Q?/D4T1FeAGHDD9Ps9Ozq1tnGLYesRaRd0hiBERm7ypu6iwauqeiwun5AUqdOO?=
 =?us-ascii?Q?cOrU9UHHCBBiyl75SRY6JoB7C6/2hCmXpYD9R++eZ2V2u9tWb6x6GvxxWWf6?=
 =?us-ascii?Q?9q+NJlvKZsVmM2cOBVlYS2jWPKnPDkDZqGG4Vb6Dx3mNy7rzmwWoG+GlRnc5?=
 =?us-ascii?Q?1SkCNLFX8pjUNUC1yvX2iZT/jaNXAX2pOL9BRABH7t76/k9cVTACehuT2Blt?=
 =?us-ascii?Q?bKH6H2edpINywiqj4aSE9sTKMiOWCMLeHqkRfHXNm6Z+7E/p9vHPz+5lWdLj?=
 =?us-ascii?Q?BtighyCZKOc43u1KyamA3NMiM2MTq5gn/HoyzrgWG5Y5fFWB1h+t24etlkh7?=
 =?us-ascii?Q?rSQI3OBfSjsy+HoDoeJiLajRyRU7CNd5xUhR7Ik0/XZbtmBW9Kfy46ylkt9w?=
 =?us-ascii?Q?Vgrr9XvkmaybEExgwhsV3sKrtlZXryocamNfOXQdluPYEjWY7jSodKBUaSpQ?=
 =?us-ascii?Q?0jdi1otTQVbciAZxkqiizk+SVeMpKYXTtSSeGFuMpKDk8X7Q3pyTprjq/QV8?=
 =?us-ascii?Q?qqzIRvbaHBbZEraOSNgsmUIyk+SV7S95zZa5kMzkaQzOkKeQ8tBmGlQ2bgU9?=
 =?us-ascii?Q?3LmVOc5Icf3PA+19tZsglwydBLYWldueMliPak2rOgZB0huj3CtbKtSzB+L2?=
 =?us-ascii?Q?LR+KLADgvdQbiFjYpyDKHVfL0IQlDeHlTCo11eZUZe1DIU/9nXj2u1LX/TGZ?=
 =?us-ascii?Q?X5yD+lS2a2UYBjqaLGQ/x8uEDirwkuBq0Sgd4KMn2IHtuKdxGuDOEeFYPURv?=
 =?us-ascii?Q?vjiSwgzvI7FWPDgC7kZCzWUYYK90JWYhjLfHbEb1JshFkbAmxv7essGAnWAV?=
 =?us-ascii?Q?I8aNl35m50fGWoQMoM4+6Re2VgNQsIaN1SAiZrC0hsXASzvz60OzroiYzhkl?=
 =?us-ascii?Q?9tDp4PokqjpSbZg5K/EX0hkFbfiQ0KgmUYmC4I3Sxhb+u9mZwm8aIt1Z8xNH?=
 =?us-ascii?Q?WpWR95KZ8zFuRZvKJLkxdy4W8okGaiAl9Dy6BJStZkyFOgbGYLgOZZw/R2I8?=
 =?us-ascii?Q?1PmP+4iheVJ/F2I7UD1iAVkosjjP/t69NgsFV9qHgW4mkCAiF3ngfJYA8R2G?=
 =?us-ascii?Q?KLLCPbOPsAt2DdcJk6dNRrwRFGa0PfrpuPfcrz9taz4KO1jP/GMCkzzQaRXo?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0410e9-a8a8-4ea5-2b6c-08da8427c211
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 10:19:13.6153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /FI0PgwLZDgTQ7ofD5zk1iWbtNIgUmlfPb2w/BqaVInSv3JrDhpkyRCREwxsiP5rgVrw2ImgxJJiQpzWK1QJLELyI7wg51MyKCQvA/O75vQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2800
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_05,2022-08-22_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=838
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208220044
X-Proofpoint-GUID: glA-sPgh26c6f1BbPFgO4FInJzamh5QM
X-Proofpoint-ORIG-GUID: glA-sPgh26c6f1BbPFgO4FInJzamh5QM
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2022 at 11:40:43AM +0200, Christophe JAILLET wrote:
> After a successful call to media_device_init() it is safer to call
> media_device_init().

s/media_device_init/media_device_cleanup/.

regards,
dan carpenter