Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2201420rwa; Mon, 22 Aug 2022 04:07:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6RcNVRRWp5t/+GoGfEUPkRjsZEDq/0dF5WcTuj4mChdWbpkYjRxePawh6Erg1ZQQixPeKo X-Received: by 2002:a17:90a:604e:b0:1fa:c865:eabb with SMTP id h14-20020a17090a604e00b001fac865eabbmr22831837pjm.46.1661166424627; Mon, 22 Aug 2022 04:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661166424; cv=none; d=google.com; s=arc-20160816; b=DiUyp55HdmQxTjC4WfM4cdXnNEtpT8beIw2syxfKRK+l6cDei5cmAATXvmFK+7SVY2 Ax3c4+apCQ9g/6flLvAj1kOjxzfbgKOMuH2wPkR623yaxxa/33cP8ShKIxxtU7xg9pU6 YJI0Y72A+S0bc4vsas+VFgdVs50CqTvGmd6uR3K22+3/ykqj+7GxKp+f2RSMI1AZGwKD 56u6RkEy4p6sX+45VIc/cW0t148vSj2Hrx/mkswxAW1AdWWY1XDLJXPTlgS+uda2oaxD 65YDrkx1Wr7KxtBeYUSwsXemZcoXe829J9m9U78e7D3EKFSiX7mkHYlmNN454YDcPr9N F2TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PacggfOBJQr3sT5A1i3fwwgjluBqV9yQKM0NY8LqnPY=; b=CI6kROugUoQNzQMItxPrF+IXdUPciba3QjhBV6Ajiavp+B7xmKfa3Z/5wD2BKQAvBj CTBXBte6TF7SUq/y1f8XmV4XLx9wjkHF6EPtdAun1LFbeZBXVGH4nbcWFKRQuUHikTxl w5BHZMuD/VEMhxxLExZkWnRw/Ww1Tx4zAOR0sa5TYc3PaEvgItDiGh9+p7MndwK68TIW ZipGjyOqmqQXhXhhk7TvYHTUJ+BIxcj1ST4nYIgOVOPQMvUBYmuXwt0gatiDU8TfaLIG 8a4wNeWanWOVzrfku2tzPGuwQfnqifJoRGzeyIit6uUiTffqlHfwGURc+omYQbh5EY+v e1Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p4-20020a056a000a0400b0052f31dfc830si11361486pfh.211.2022.08.22.04.06.53; Mon, 22 Aug 2022 04:07:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234379AbiHVLEX (ORCPT + 99 others); Mon, 22 Aug 2022 07:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230297AbiHVLEV (ORCPT ); Mon, 22 Aug 2022 07:04:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C06FE27B11 for ; Mon, 22 Aug 2022 04:04:19 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ5Dx-0005Qj-4p; Mon, 22 Aug 2022 13:04:05 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oQ5Dw-001HmQ-5b; Mon, 22 Aug 2022 13:04:04 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oQ5Ds-009gzH-EK; Mon, 22 Aug 2022 13:04:00 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v2 08/17] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Date: Mon, 22 Aug 2022 13:03:49 +0200 Message-Id: <20220822110358.2310055-9-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220822110358.2310055-1-o.rempel@pengutronix.de> References: <20220822110358.2310055-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This issue was detected after adding regmap register access validation. KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103". So, avoid writing to it. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz9477.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 13c4ded84b1db..62a03b3b918df 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -193,6 +193,11 @@ int ksz9477_reset_switch(struct ksz_device *dev) ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32); + /* KSZ9893 compatible chips do not support refclk configuration */ + if (dev->chip_id == KSZ9893_CHIP_ID || + dev->chip_id == KSZ8563_CHIP_ID) + return 0; + data8 = SW_ENABLE_REFCLKO; if (dev->synclko_disable) data8 = 0; -- 2.30.2