Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2202171rwa; Mon, 22 Aug 2022 04:07:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR6HNFaxBOVGalHb27cQpp8njkjSvzbddcw15qVTwZUTW8bLkr/6MxayEcQffwaF896LOhq+ X-Received: by 2002:a17:90b:1bce:b0:1fa:ecc3:9068 with SMTP id oa14-20020a17090b1bce00b001faecc39068mr16278344pjb.116.1661166465212; Mon, 22 Aug 2022 04:07:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661166465; cv=none; d=google.com; s=arc-20160816; b=LG2IlZLdBoIXa3VhCgZZ5cBRmqM9dsR3zStAmSkvjT7tQkgiZhPpEF10hYlTgnYoXb Wzh93/gZ1p/Y0I8VZ6zJUB0u5ueBa3zCHr97HVe40SuOyMXhkVP0cVvj3z92tJti7LfS Dwt9kqwfBYcsNuPRTU8whtgymcE6xLPEQWUkF34fmFZuVqKFEK/CdkVnENSuhd0ub9FL R9SbzO35IGX/ouTGQZSZsxm75GYSkY/N3fMqc0s+cZjsbIu/b7RiUH47iIOS5QOlWJkA TRCsfvQf+GNNyckfryySaZrcV2Xo8IJvFeCoGldgOMJEj1gjZyk+90ij2JJSFBDG7wb2 jArQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1KdZSk9aaJoPL4zR/npxrOaO915XAOR5HgL01wpuwE0=; b=qOk+kh3mA2YuHwp3L3LcFwn1drNz0y1bI/bJn0kFhDMRQB/o+/4mX30q6BaQacjXLt jPCLdT88IHbrQck73QeJI8Z+r3vPnxRHxLWYfOoiq7FXwuNuJ7EDqwjmT7NlKUd6yjRZ 2MsK6xYpCQtKxSJiB3ypXQVq2c2MK42dU76Vn/OxmP4Z2k4yYmLkdxqxBmF/b7A77nQI /KtXLyWiv0oPXg7niIKpYFwaSKlmlrhmqrBLcgyvg8w96wT5LdH8vASl8rm0d0G3CMrE VBUeuFNhiNU9FBbA7Eq5B+tvBjMCIQb5I8iL4FH+GtOPLxGPHkIZq5d6Iadt/6SaT/Bq WnqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m6-20020a170902f64600b0016d74515d06si10288180plg.614.2022.08.22.04.07.34; Mon, 22 Aug 2022 04:07:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234679AbiHVLFI (ORCPT + 99 others); Mon, 22 Aug 2022 07:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234284AbiHVLEX (ORCPT ); Mon, 22 Aug 2022 07:04:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C22D275F7 for ; Mon, 22 Aug 2022 04:04:20 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ5Dw-0005PT-TV; Mon, 22 Aug 2022 13:04:04 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oQ5Dv-001HmB-NY; Mon, 22 Aug 2022 13:04:03 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oQ5Ds-009gzi-Ft; Mon, 22 Aug 2022 13:04:00 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v2 11/17] net: dsa: microchip: ksz9477: remove MII_CTRL1000 check from ksz9477_w_phy() Date: Mon, 22 Aug 2022 13:03:52 +0200 Message-Id: <20220822110358.2310055-12-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220822110358.2310055-1-o.rempel@pengutronix.de> References: <20220822110358.2310055-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The reason why PHYlib may access MII_CTRL1000 on the chip without GBit support is only if chip provides wrong information about extended caps register. This issue is now handled by ksz9477_r_phy_quirks() With proper regmap_ranges provided for all chips we will be able to catch this kind of bugs any way. So, remove this sanity check. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz9477.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 62a03b3b918df..cb5bd0ceb8df4 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -342,10 +342,6 @@ int ksz9477_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val) if (addr >= dev->phy_port_cnt) return 0; - /* No gigabit support. Do not write to this register. */ - if (!(dev->features & GBIT_SUPPORT) && reg == MII_CTRL1000) - return -ENXIO; - return ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val); } -- 2.30.2