Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2203422rwa; Mon, 22 Aug 2022 04:08:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR6kIC4hgXFn8EBaoa4WCn2ZQVEgO7gqPh+vVJ4OxWY1Q6ZHHqwj3jCU4Cfl+GrlPh5fex0v X-Received: by 2002:a17:90a:318f:b0:1fa:a374:f565 with SMTP id j15-20020a17090a318f00b001faa374f565mr27948100pjb.146.1661166539205; Mon, 22 Aug 2022 04:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661166539; cv=none; d=google.com; s=arc-20160816; b=IuTsm3yO+6on6Wr1d3dQj/97bVBJwZ4uCDEPYPacjPRB7ecF2nONSrnCwo5Es/cuLA sxjZiQFUExhrsZngjLCK+n1oJ3VES46g3v4qRAWcIp9Ldxjcl3Ae3lE9BpBFoX0ve02i V8DwN/AyXC5ZbtLNkCy0gSXhmVKqYMEJM90p//WxI6LKRuC3TDHvuPG+aM4I5CVVCSJx 8f779mTB4/TXu4AYFLJE3DeyjVD30aBWF5MbeBetDFccKPqekwFdzHVNn7xU9N0Fv0HG yMQ14MEjwQooUxlybuhK/6ez4v6GckaBjevpafMVyGwsNgpgmhGpdHKvcE8bV40AzEXA fL5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QAi1zcc1d74cMmvUKhZXVkfu75OUIceK1ITcSonc13o=; b=hWWsohJd9r4Trq3KLbdkTZiZrSMyQvj9Bx6dWIDM66KkIOrj1RoFWcCC2khXd7eoRg HdGmIqDCXCxZrx79+PCtzeCmSTMvBUFUAG5gBeA7L3Hdz9LyUH7FC9f0AVQmZptxnJOe TeuHj5+iAF2CwcPkSLlWJZw/aA73Z5OtJ6ThRvRu5N7dkaBxSSYOP1LVzTlPBZEohDy3 ePZEm0i9WSRjBYZWZYy3QRmSgQJUnXbix28Rn6/zN0uibtwwaGnsTY57bNRyGviS1ctN SyNB9hpFCjml5UpuQi59UTjf4y1/8RxiwCnXsEED8LNJGwQIUaDOZbpZMAISd8Jgdnko IlfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o16-20020a17090aac1000b001f302511306si14190982pjq.86.2022.08.22.04.08.45; Mon, 22 Aug 2022 04:08:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbiHVLFE (ORCPT + 99 others); Mon, 22 Aug 2022 07:05:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233981AbiHVLEW (ORCPT ); Mon, 22 Aug 2022 07:04:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8460827CD4 for ; Mon, 22 Aug 2022 04:04:20 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ5Dx-0005S0-Fs; Mon, 22 Aug 2022 13:04:05 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oQ5Dw-001Hme-MC; Mon, 22 Aug 2022 13:04:04 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oQ5Ds-009gyq-Ce; Mon, 22 Aug 2022 13:04:00 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v2 05/17] net: dsa: microchip: forward error value on all ksz_pread/ksz_pwrite functions Date: Mon, 22 Aug 2022 13:03:46 +0200 Message-Id: <20220822110358.2310055-6-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220822110358.2310055-1-o.rempel@pengutronix.de> References: <20220822110358.2310055-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ksz_read*/ksz_write* are able to return errors, so forward it. Signed-off-by: Oleksij Rempel Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz_common.h | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/microchip/ksz_common.h index baaeb60533faf..be0e5d6ef2bf0 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -393,40 +393,42 @@ static inline int ksz_write64(struct ksz_device *dev, u32 reg, u64 value) return regmap_bulk_write(dev->regmap[2], reg, val, 2); } -static inline void ksz_pread8(struct ksz_device *dev, int port, int offset, +static inline int ksz_pread8(struct ksz_device *dev, int port, int offset, u8 *data) { - ksz_read8(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_read8(dev, dev->dev_ops->get_port_addr(port, offset), data); } -static inline void ksz_pread16(struct ksz_device *dev, int port, int offset, +static inline int ksz_pread16(struct ksz_device *dev, int port, int offset, u16 *data) { - ksz_read16(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_read16(dev, dev->dev_ops->get_port_addr(port, offset), data); } -static inline void ksz_pread32(struct ksz_device *dev, int port, int offset, +static inline int ksz_pread32(struct ksz_device *dev, int port, int offset, u32 *data) { - ksz_read32(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_read32(dev, dev->dev_ops->get_port_addr(port, offset), data); } -static inline void ksz_pwrite8(struct ksz_device *dev, int port, int offset, +static inline int ksz_pwrite8(struct ksz_device *dev, int port, int offset, u8 data) { - ksz_write8(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_write8(dev, dev->dev_ops->get_port_addr(port, offset), data); } -static inline void ksz_pwrite16(struct ksz_device *dev, int port, int offset, +static inline int ksz_pwrite16(struct ksz_device *dev, int port, int offset, u16 data) { - ksz_write16(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_write16(dev, dev->dev_ops->get_port_addr(port, offset), + data); } -static inline void ksz_pwrite32(struct ksz_device *dev, int port, int offset, +static inline int ksz_pwrite32(struct ksz_device *dev, int port, int offset, u32 data) { - ksz_write32(dev, dev->dev_ops->get_port_addr(port, offset), data); + return ksz_write32(dev, dev->dev_ops->get_port_addr(port, offset), + data); } static inline void ksz_prmw8(struct ksz_device *dev, int port, int offset, -- 2.30.2