Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2233343rwa; Mon, 22 Aug 2022 04:39:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR4pZHN5wjWeWntjs2+Gy9KHqI2cBTIK8hk5ctf7sPyyCroFHwRy2+iq486cMk2xbZCyHI41 X-Received: by 2002:a17:906:8cb0:b0:739:4c35:75d8 with SMTP id qr48-20020a1709068cb000b007394c3575d8mr12206955ejc.711.1661168389536; Mon, 22 Aug 2022 04:39:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661168389; cv=none; d=google.com; s=arc-20160816; b=P7zlezzYDgYPL4Y4Au+VgdMkdtYDaXOTbi8gvuc3gPawVy3C0xnB3ywbvHd6FwqAAq cmPkT87fO0x/eVdgT49ZIWx7ehld6cpTGyd5LGjO+kQvJAXdPBl5Lh6NBG99AnaBdDj2 GfBPDbP+daH8ZujQwJ0gEEzSiOki/zbFzxDsgDgVQdr014Ao+2vUkvtHo/hE74ijNgav jrvsiOPrd4IigTe+LuNfPevyi7oYPBd0Ozr9+PyDbSr5TDPvVhDJynKoMezuiQR98fs7 5GKhS1eeAmeYTCzCSo7+Fd9vYPe5HJaEx1ABEDkQ40efblHil1MXYgMCt7DrdyHRhgRJ dJIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ktMzlSFdVQYUGp03litM44l4Gx4FNd+6ZShF2nft75g=; b=Wvvahxa/vNelGqUWWJIJvQGQUyMM8ULvMKb5+sYFF9oFcvg/eB9JLG5bYuRs3WtEdN YRL1he6KldUsaCgc7bdiV0w43purmLoJ3HSmVv+dCEOsYx7iG2glvqFrZCfJnfxLdWSm uddlHzxXC4j5WXh5JFx5CF88myd3vW16yl0pUVuS0AQeDjyACXV/Ap3miUdV+/DuhEmI qMqAbot02Eo4vtcMXMYy6KuIOTI+Dox07VXPbA6ro+3PrLypiTzZg8x3Yk2sdonBIshq L3vgD2mSI8SB+9Ned/N2uxLwEGjNIMH5HV3sjbr0DVU/K6PicWtZ0m+GgFSiHpSaGCSL IZVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ljTOP2NO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd11-20020a170907968b00b0073d7884a3c8si3545703ejc.594.2022.08.22.04.39.22; Mon, 22 Aug 2022 04:39:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ljTOP2NO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233993AbiHVLVV (ORCPT + 99 others); Mon, 22 Aug 2022 07:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233910AbiHVLVR (ORCPT ); Mon, 22 Aug 2022 07:21:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05B281F63E; Mon, 22 Aug 2022 04:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ktMzlSFdVQYUGp03litM44l4Gx4FNd+6ZShF2nft75g=; b=ljTOP2NOOOEPk/1TF0QWa2ajJK KqVDEbmCr3KQ/zmtQkDGm+QLYYN700ufnjfEvy1vtpoJ4aVO/lgj72RIHglIaG925iWDmeOjw3dKV czsJEaLgSURBV5wXu11GNsq/cyf4fehp4tVZce8bAqBR2CAwf6z35O0JglOYWn5R/jhd5UDHOoHgb Y2cfZz3F+KsGqv4Q4FR7ewbMpiTTX0ulhL4skI3GErKOcf0l/8usRywD9U9tl7oQsoQoAtvEPS+W6 GeeraySviOpmiP/U4zpRidJB9qXKKrL/8KB2RW1gBml8txR18tMwhdxARX18wedHD0OKaP1CQVC0A BSGHMG1w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ5UQ-0087Er-3k; Mon, 22 Aug 2022 11:21:06 +0000 Date: Mon, 22 Aug 2022 04:21:06 -0700 From: Christoph Hellwig To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com, jean-philippe@linaro.org, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h Message-ID: References: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 70393fbb57ed..79cb6eb560a8 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -1059,4 +1059,40 @@ void iommu_debugfs_setup(void); > static inline void iommu_debugfs_setup(void) {} > #endif > > +#ifdef CONFIG_IOMMU_DMA > +#include I don't think msi.h is actually needed here. Just make the struct msi_desc and struct msi_msg forward declarations unconditional and we should be fine.