Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 13:48:52 +0200
From:   Alexander Gordeev <agordeev@linux.ibm.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-kernel@vger.kernel.org, Stefan Haberland <sth@linux.ibm.com>,
        Jan Hoeppner <hoeppner@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Alexandra Winter <wintera@linux.ibm.com>,
        Wenjia Zhang <wenjia@linux.ibm.com>,
        Steffen Maier <maier@linux.ibm.com>,
        Benjamin Block <bblock@linux.ibm.com>,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] s390: move from strlcpy with unused retval to strscpy
Message-ID: <YwNtJAQlJVycijou@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com>
References: <20220818210102.7301-1-wsa+renesas@sang-engineering.com>
 <YwM4y78boN4s1VNo@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com>
 <YwNAW2Zp6o7Z//Y2@shikoro>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YwNAW2Zp6o7Z//Y2@shikoro>
Precedence: bulk

On Mon, Aug 22, 2022 at 10:37:47AM +0200, Wolfram Sang wrote:
> Hi Alexander,
> 
> > Could you please explain why you skipped strlcpy() usage in
> > drivers/s390/char/diag_ftp.c and drivers/s390/char/sclp_ftp.c?
> 
> Sure. It is a bit hidden in $subject, but the key is to convert strlcpy
> instances for now which do not check the return value. This is the
> low-hanging fruit.
> 
> Converting the other uses checking the return value needs to be done
> manually and much more carfully. I wanted to this as a second step, but
> if you prefer to have everything converted in one go, I can give your
> subsystem a priority boost. Would you prefer that?

A follow-up patch is also fine.

I guess, you also wanted a fix for arch/s390/kvm/tests/instr_icpt/main.c
in this series.

> Thanks and happy hacking,
> 
>    Wolfram

Thanks!