Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 04/16] hwmon: (mr75203) add Moortec PVT controller
 reset-control-skip property
Message-ID: <9757d669-c205-4ccd-78e0-3af6941d3177@amazon.com>
Date:   Mon, 22 Aug 2022 14:54:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>
CC:     <jdelvare@suse.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <talel@amazon.com>,
        <hhhawa@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
        <ronenk@amazon.com>, <itamark@amazon.com>, <shellykz@amazon.com>,
        <shorer@amazon.com>, <amitlavi@amazon.com>, <almogbs@amazon.com>,
        <dwmw@amazon.co.uk>, <rtanwar@maxlinear.com>,
        "Farber, Eliav" <farbere@amazon.com>
References: <20220817054321.6519-1-farbere@amazon.com>
 <20220817054321.6519-5-farbere@amazon.com>
 <20220818195742.GA3287145@roeck-us.net>
From:   "Farber, Eliav" <farbere@amazon.com>
In-Reply-To: <20220818195742.GA3287145@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/18/2022 11:01 PM, Guenter Roeck wrote:
> On Wed, Aug 17, 2022 at 05:43:09AM +0000, Eliav Farber wrote:
>> Adding a "reset-control-skip" bool property to the mr75203 node will
>> avoid looking up and obtaining a reference to a reset controller.
>>
>
> This seems overly complex. WHy not just declare the "resets"
> property optional ? 
Fixed. I declared "resets" property  as optional, and modified the driver
to support it being optional instead of the change I did.
Will be part of next version.

--
Thanks, Eliav