Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2368336rwa; Mon, 22 Aug 2022 06:44:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR4nIlpt0a1Cu7MMNp4gC0aQba6nCTtZrLVhEcDXDCFKpnLUPfPFa4k5q2JZXtZWejsQSeSc X-Received: by 2002:a05:6402:40c9:b0:446:e1dc:5c3d with SMTP id z9-20020a05640240c900b00446e1dc5c3dmr2195539edb.270.1661175851114; Mon, 22 Aug 2022 06:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661175851; cv=none; d=google.com; s=arc-20160816; b=eC5Qv1TzpZHpVjPpsDdiNi1vNBOhvNB930I000t1MAAmPIgjYtDxSSIt3frmR+A87o Ec7H4trPUkNciZ+nkAB9v9Zy6KwSAj3wxZhGBesQGgQrdfhVlcd/IWkU7+ZZ/ASrgfNG bw+yFgsXxbRoKEB9DaLwDvpCGIX2n4syy7BYRlHIbVpRnx4NElxpa1GtPZzwPFwgajV9 mz4OWnJdp+FTdU6rqqUhhVpTr44dkMx+KgLqfS4B7aez6sdTWy7d3X8Cnf3qY/54n0+E tmQ/YsyIuDNM/Yj3XFyBni44LXwLAn+bgJ/Mszw/6Kl4Z57uauxbpxHNUplI6Lz9jMA3 4egg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=w6hGV6FGXoT8ySnMA+O8i+m5wa23h/k+vPv/Pe1ggaw=; b=BA6uF/0nvP9gRMWVgYBKeNgsWPt2Da0JTsjTw2DWA1co1jH9CccqTwjIwDV7igNUjV 2bmGTJV33IrCxYwC25lKxHdhe9q8WxTcB+JEUy4zeM0Wlp77fCyfP2gQNXI9vaf8dN1o B/oqmPNuZtLTMFqpgxM7HQnWFB9YduExF50K6yItxbnRcRjb9gCFAhG5t7mPDpL2vC1l AqeUgG/aaGIpD2M9LFuus2MNVly0b+sSmUG5+/pohYm5blCcyBNQJAVy+8KPHpAKuiJF h+MLuQbiSed6Vl9lbEY9Qz9o0uLdUDrthsKVmBbmwh2aXKosFuJaGlj3kUvjzeti0xf/ IF9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt8-20020a170907728800b007313bdfb98bsi9515247ejc.18.2022.08.22.06.43.45; Mon, 22 Aug 2022 06:44:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235094AbiHVN2Z (ORCPT + 99 others); Mon, 22 Aug 2022 09:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235004AbiHVN2S (ORCPT ); Mon, 22 Aug 2022 09:28:18 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1227CFDA; Mon, 22 Aug 2022 06:28:17 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C40D51A1E03; Mon, 22 Aug 2022 15:28:15 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 8A05D1A1DAB; Mon, 22 Aug 2022 15:28:15 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id DE6E91820F5A; Mon, 22 Aug 2022 21:28:13 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, vkoul@kernel.org, marcel.ziswiler@toradex.com, kishon@ti.com Cc: hongxing.zhu@nxp.com, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and phy_power_on() Date: Mon, 22 Aug 2022 21:10:55 +0800 Message-Id: <1661173856-1192-2-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1661173856-1192-1-git-send-email-hongxing.zhu@nxp.com> References: <1661173856-1192-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Refer to phy_core driver, phy_init() must be called before phy_power_on(). Fix the wrong order of phy_init() and phy_power_on() here. Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") Signed-off-by: Richard Zhu --- drivers/pci/controller/dwc/pci-imx6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 6e5debdbc55b..b5f0de455a7b 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -935,7 +935,7 @@ static int imx6_pcie_host_init(struct dw_pcie_rp *pp) } if (imx6_pcie->phy) { - ret = phy_power_on(imx6_pcie->phy); + ret = phy_init(imx6_pcie->phy); if (ret) { dev_err(dev, "pcie PHY power up failed\n"); goto err_clk_disable; @@ -949,7 +949,7 @@ static int imx6_pcie_host_init(struct dw_pcie_rp *pp) } if (imx6_pcie->phy) { - ret = phy_init(imx6_pcie->phy); + ret = phy_power_on(imx6_pcie->phy); if (ret) { dev_err(dev, "waiting for PHY ready timeout!\n"); goto err_phy_off; @@ -961,7 +961,7 @@ static int imx6_pcie_host_init(struct dw_pcie_rp *pp) err_phy_off: if (imx6_pcie->phy) - phy_power_off(imx6_pcie->phy); + phy_exit(imx6_pcie->phy); err_clk_disable: imx6_pcie_clk_disable(imx6_pcie); err_reg_disable: -- 2.25.1