Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2371855rwa; Mon, 22 Aug 2022 06:47:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR7iKDjmRTINIyZo6dqqPNiVjttHqhp740IFOOOkdyUlooZRANzCKsxcKwTp/4L6jjHc00mb X-Received: by 2002:a17:906:cc0f:b0:73d:6715:f82 with SMTP id ml15-20020a170906cc0f00b0073d67150f82mr6710819ejb.270.1661176031334; Mon, 22 Aug 2022 06:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661176031; cv=none; d=google.com; s=arc-20160816; b=RRAipn5RVQERfJPMzn/A/2KmkqlicBYogh/V/Ek8YXX8LW+W0897vuNbuqS323GGPl c7WjHZcAxMliJwbNQROdZbdl5mpXsr4JPOJ6w/tn7A3kFVGrWFf7RSDY6ZI6gia9lz0S sc0rnF5UzwgN7Tp+z3cOMbpJyYrCbf1wE+9eEjEa79gw1AjCQsrnOSVkUXJIDl7q5jRJ Q+Du9omIIncbNEevDMvvzLWYogRHy7/KY7ncm7VtDbat0uwiHL8faG2/ppIPWZZD6k1B JhzaScRgwgyfFN7mPsESX/nCtciKYv3BVRscWmBaM4w34VZGYQrFgGluV9qm1qCBczC1 cLnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:organization:message-id:date:subject:cc:to :from; bh=rCvXYkmhfgsePsol3NkW/UDdGT1fL+k+qNSgbcXmXgw=; b=KLUtZ8e5UrVU5m1CcEMVC8Cz0RLAwukyGCGhveiMVSug+NpQKV2Sd71mgbVxhCbox+ eTZ6c6ckbh9rZb2/3n7H9eCNhAePJ6XjiN71GeCnB7Gv2kVN7SLfGmPCeGDMsp5z+KZZ Bb7ysqdxnH7SFbodiWHO1r/vrIUH2xNXdBqQUUZhVeQxkXQik46PYhcl+D1FAZJUX1AW tS8XKiXBlyJFWMLxWS/dIjctngyXEuQxek1aAsmrIx6VP1Csw27+B66wk5pSFpc2iYSv 7A6tyXdJbQQcoZGF5wzqChWchZ/1Gx4JHcNl0TRnvnSGhdg3LOWV+4b8CrHQjHXQZ/yv AZUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt8-20020a170907728800b007313bdfb98bsi9515247ejc.18.2022.08.22.06.46.45; Mon, 22 Aug 2022 06:47:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235225AbiHVNjE convert rfc822-to-8bit (ORCPT + 99 others); Mon, 22 Aug 2022 09:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234115AbiHVNjD (ORCPT ); Mon, 22 Aug 2022 09:39:03 -0400 Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2523A95BA for ; Mon, 22 Aug 2022 06:39:00 -0700 (PDT) Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 5DDBD601AF; Mon, 22 Aug 2022 15:04:37 +0200 (CEST) From: Rolf Eike Beer To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] mm: pagewalk: fix documentation of PTE hole handling Date: Mon, 22 Aug 2022 15:01:32 +0200 Message-ID: <3695521.kQq0lBPeGt@devpool047> Organization: emlix GmbH In-Reply-To: <3200642.44csPzL39Z@devpool047> References: <3200642.44csPzL39Z@devpool047> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Empty PTEs are passed to the pte_entry callback, not to pte_hole. Signed-off-by: Rolf Eike Beer --- include/linux/pagewalk.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h index ac7b38ad5903..f3fafb731ffd 100644 --- a/include/linux/pagewalk.h +++ b/include/linux/pagewalk.h @@ -15,12 +15,12 @@ struct mm_walk; * this handler is required to be able to handle * pmd_trans_huge() pmds. They may simply choose to * split_huge_page() instead of handling it explicitly. - * @pte_entry: if set, called for each non-empty PTE (lowest-level) - * entry + * @pte_entry: if set, called for each PTE (lowest-level) entry, + * including empty ones * @pte_hole: if set, called for each hole at all levels, - * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD - * 4:PTE. Any folded depths (where PTRS_PER_P?D is equal - * to 1) are skipped. + * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD. + * Any folded depths (where PTRS_PER_P?D is equal to 1) + * are skipped. * @hugetlb_entry: if set, called for each hugetlb entry * @test_walk: caller specific callback function to determine whether * we walk over the current vma or not. Returning 0 means -- 2.37.2 -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source