Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Subject: [PATCH v3 07/10] x86/resctrl: Add sysfs interface files to read/write
 event configuration
From:   Babu Moger <babu.moger@amd.com>
To:     <fenghua.yu@intel.com>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <eranian@google.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <corbet@lwn.net>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <bagasdotme@gmail.com>
Date:   Mon, 22 Aug 2022 08:43:53 -0500
Message-ID: <166117583337.6695.3477964609702763678.stgit@bmoger-ubuntu>
In-Reply-To: <166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu>
References: <166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu>
User-Agent: StGit/1.1.dev103+g5369f4c
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 13:44:21.0259
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dc54aa5f-ab24-46d0-d739-08da84446ade
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT084.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6950
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add two new sysfs files to read/write the event configuration if=0A=
the feature Bandwidth Monitoring Event Configuration (BMEC) is=0A=
supported. The file mbm_local_config is for the configuration=0A=
of the event mbm_local_bytes and the file mbm_total_config is=0A=
for the configuration of mbm_total_bytes.=0A=
=0A=
$ls /sys/fs/resctrl/mon_data/mon_L3_00/mbm_local*=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_local_bytes=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_local_config=0A=
=0A=
$ls /sys/fs/resctrl/mon_data/mon_L3_00/mbm_total*=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_total_bytes=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_total_config=0A=
=0A=
Signed-off-by: Babu Moger <babu.moger@amd.com>=0A=
Reviewed-by: Ingo Molnar <mingo@kernel.org>=0A=
---=0A=
 arch/x86/kernel/cpu/resctrl/internal.h |    3 +++=0A=
 arch/x86/kernel/cpu/resctrl/monitor.c  |    2 ++=0A=
 arch/x86/kernel/cpu/resctrl/rdtgroup.c |   32 ++++++++++++++++++++++++++++=
++++=0A=
 3 files changed, 37 insertions(+)=0A=
=0A=
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/r=
esctrl/internal.h=0A=
index c049a274383c..fc725f5e9024 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/internal.h=0A=
+++ b/arch/x86/kernel/cpu/resctrl/internal.h=0A=
@@ -72,11 +72,13 @@ DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);=0A=
  * struct mon_evt - Entry in the event list of a resource=0A=
  * @evtid:		event id=0A=
  * @name:		name of the event=0A=
+ * @config:	current configuration=0A=
  * @list:		entry in &rdt_resource->evt_list=0A=
  */=0A=
 struct mon_evt {=0A=
 	u32			evtid;=0A=
 	char			*name;=0A=
+	char			*config;=0A=
 	struct list_head	list;=0A=
 };=0A=
 =0A=
@@ -95,6 +97,7 @@ union mon_data_bits {=0A=
 		unsigned int rid	: 10;=0A=
 		unsigned int evtid	: 8;=0A=
 		unsigned int domid	: 14;=0A=
+		unsigned int mon_config : 32;=0A=
 	} u;=0A=
 };=0A=
 =0A=
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/re=
sctrl/monitor.c=0A=
index b9de417dac1c..3f900241dbab 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/monitor.c=0A=
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c=0A=
@@ -656,11 +656,13 @@ static struct mon_evt llc_occupancy_event =3D {=0A=
 static struct mon_evt mbm_total_event =3D {=0A=
 	.name		=3D "mbm_total_bytes",=0A=
 	.evtid		=3D QOS_L3_MBM_TOTAL_EVENT_ID,=0A=
+	.config 	=3D "mbm_total_config",=0A=
 };=0A=
 =0A=
 static struct mon_evt mbm_local_event =3D {=0A=
 	.name		=3D "mbm_local_bytes",=0A=
 	.evtid		=3D QOS_L3_MBM_LOCAL_EVENT_ID,=0A=
+	.config 	=3D "mbm_local_config",=0A=
 };=0A=
 =0A=
 /*=0A=
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/r=
esctrl/rdtgroup.c=0A=
index 855483b297a8..30d2182d4fda 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
@@ -254,6 +254,10 @@ static const struct kernfs_ops kf_mondata_ops =3D {=0A=
 	.seq_show		=3D rdtgroup_mondata_show,=0A=
 };=0A=
 =0A=
+static const struct kernfs_ops kf_mondata_config_ops =3D {=0A=
+	.atomic_write_len       =3D PAGE_SIZE,=0A=
+};=0A=
+=0A=
 static bool is_cpu_list(struct kernfs_open_file *of)=0A=
 {=0A=
 	struct rftype *rft =3D of->kn->priv;=0A=
@@ -2534,6 +2538,25 @@ void rmdir_mondata_subdir_allrdtgrp(struct rdt_resou=
rce *r, unsigned int dom_id)=0A=
 	}=0A=
 }=0A=
 =0A=
+static int mon_config_addfile(struct kernfs_node *parent_kn, const char *n=
ame,=0A=
+			      void *priv)=0A=
+{=0A=
+	struct kernfs_node *kn;=0A=
+	int ret =3D 0;=0A=
+=0A=
+	kn =3D __kernfs_create_file(parent_kn, name, 0644,=0A=
+			GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 0,=0A=
+			&kf_mondata_config_ops, priv, NULL, NULL);=0A=
+	if (IS_ERR(kn))=0A=
+		return PTR_ERR(kn);=0A=
+=0A=
+	ret =3D rdtgroup_kn_set_ugid(kn);=0A=
+	if (ret)=0A=
+		kernfs_remove(kn);=0A=
+=0A=
+	return ret;=0A=
+}=0A=
+=0A=
 static int mkdir_mondata_subdir(struct kernfs_node *parent_kn,=0A=
 				struct rdt_domain *d,=0A=
 				struct rdt_resource *r, struct rdtgroup *prgrp)=0A=
@@ -2568,6 +2591,15 @@ static int mkdir_mondata_subdir(struct kernfs_node *=
parent_kn,=0A=
 		if (ret)=0A=
 			goto out_destroy;=0A=
 =0A=
+		/* Create the sysfs event configuration files */=0A=
+		if (r->mon_configurable &&=0A=
+		    (mevt->evtid =3D=3D QOS_L3_MBM_TOTAL_EVENT_ID ||=0A=
+		     mevt->evtid =3D=3D QOS_L3_MBM_LOCAL_EVENT_ID)) {=0A=
+			ret =3D mon_config_addfile(kn, mevt->config, priv.priv);=0A=
+			if (ret)=0A=
+				goto out_destroy;=0A=
+		}=0A=
+=0A=
 		if (is_mbm_event(mevt->evtid))=0A=
 			mon_event_read(&rr, r, d, prgrp, mevt->evtid, true);=0A=
 	}=0A=
=0A=