Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 15:57:34 +0200
From:   David Disseldorp <ddiss@suse.de>
To:     Stanislav Goriainov <goriainov@ispras.ru>
Cc:     Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] ovl: Fix potential memory leak
Message-ID: <20220822155734.0a188325@echidna.suse.de>
In-Reply-To: <20220822115257.7457-1-goriainov@ispras.ru>
References: <20220822115257.7457-1-goriainov@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 22 Aug 2022 14:52:57 +0300, Stanislav Goriainov wrote:

> ovl: Fix potential memory leak in ovl_lookup()
> 
> If memory for uperredirect was allocated with kstrdup()
> in upperdir != NULL and d.redirect != NULL path,
> it may be lost when upperredirect is reassigned later.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Stanislav Goriainov <goriainov@ispras.ru>
> ---
>  fs/overlayfs/namei.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index 69dc577974f8..226c69812379 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -1085,6 +1085,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
>  			.mnt = ovl_upper_mnt(ofs),
>  		};
>  
> +		kfree(upperredirect);
>  		upperredirect = ovl_get_redirect_xattr(ofs, &upperpath, 0);
>  		if (IS_ERR(upperredirect)) {
>  			err = PTR_ERR(upperredirect);

This probably deserves a:
Fixes: 0a2d0d3f2f291 ("ovl: Check redirect on index as well")

Looks fine otherwise.
Reviewed-by: David Disseldorp <ddiss@suse.de>