Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e15165f60ce801dd502bfe1992ea430fe37c5a91.camel@ndufresne.ca>
Subject: Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Hsia-Jun Li <Randy.Li@synaptics.com>
Cc:     Tomasz Figa <tfiga@chromium.org>, dri-devel@lists.freedesktop.org,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
        mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
        ezequiel@vanguardiasur.com.ar, sakari.ailus@linux.intel.com,
        ribalda@chromium.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        sebastian.hesselbarth@gmail.com, jszhang@kernel.org,
        linux-arm-kernel@lists.infradead.org
Date:   Mon, 22 Aug 2022 10:15:17 -0400
In-Reply-To: <1f926989-eb13-14ee-e30d-ac6d01b86c52@synaptics.com>
References: <20220808162750.828001-1-randy.li@synaptics.com>
         <20220808162750.828001-3-randy.li@synaptics.com>
         <CAAFQd5AKjpJ+fPAeCqdNnJbS4R7SdaHkfyW4qG1xXr-sE801pQ@mail.gmail.com>
         <13d37c15-79f3-4e16-8cf4-fc37846f4a04@synaptics.com>
         <Yv7HnHE7bLmgq5D0@pendragon.ideasonboard.com>
         <6da7faf329128312f0862f555d1a855437ae99f3.camel@ndufresne.ca>
         <50dd9b7a-8f48-0799-57f6-048d20de8dcc@synaptics.com>
         <2662ac698898f71f60b9b7e0ad4703854de1d012.camel@ndufresne.ca>
         <1f926989-eb13-14ee-e30d-ac6d01b86c52@synaptics.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Le samedi 20 ao=C3=BBt 2022 =C3=A0 08:10 +0800, Hsia-Jun Li a =C3=A9crit=C2=
=A0:
>=20
> On 8/20/22 03:17, Nicolas Dufresne wrote:
> > CAUTION: Email originated externally, do not click links or open attach=
ments unless you recognize the sender and know the content is safe.
> >=20
> >=20
> > Le vendredi 19 ao=C3=BBt 2022 =C3=A0 23:44 +0800, Hsia-Jun Li a =C3=A9c=
rit :
> > >=20
> > > On 8/19/22 23:28, Nicolas Dufresne wrote:
> > > > CAUTION: Email originated externally, do not click links or open at=
tachments unless you recognize the sender and know the content is safe.
> > > >=20
> > > >=20
> > > > Le vendredi 19 ao=C3=BBt 2022 =C3=A0 02:13 +0300, Laurent Pinchart =
a =C3=A9crit :
> > > > > On Thu, Aug 18, 2022 at 02:33:42PM +0800, Hsia-Jun Li wrote:
> > > > > > On 8/18/22 14:06, Tomasz Figa wrote:
> > > > > > > On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li <randy.li@synaptic=
s.com> wrote:
> > > > > > > >=20
> > > > > > > > From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>
> > > > > > > >=20
> > > > > > > > The most of detail has been written in the drm.
> > > > >=20
> > > > > This patch still needs a description of the format, which should =
go to
> > > > > Documentation/userspace-api/media/v4l/.
> > > > >=20
> > > > > > > > Please notice that the tiled formats here request
> > > > > > > > one more plane for storing the motion vector metadata.
> > > > > > > > This buffer won't be compressed, so you can't append
> > > > > > > > it to luma or chroma plane.
> > > > > > >=20
> > > > > > > Does the motion vector buffer need to be exposed to userspace=
? Is the
> > > > > > > decoder stateless (requires userspace to specify the referenc=
e frames)
> > > > > > > or stateful (manages the entire decoding process internally)?
> > > > > >=20
> > > > > > No, users don't need to access them at all. Just they need a di=
fferent
> > > > > > dma-heap.
> > > > > >=20
> > > > > > You would only get the stateful version of both encoder and dec=
oder.
> > > > >=20
> > > > > Shouldn't the motion vectors be stored in a separate V4L2 buffer,
> > > > > submitted through a different queue then ?
> > > >=20
> > > > Imho, I believe these should be invisible to users and pooled separ=
ately to
> > > > reduce the overhead. The number of reference is usually lower then =
the number of
> > > > allocated display buffers.
> > > >=20
> > > You can't. The motion vector buffer can't share with the luma and chr=
oma
> > > data planes, nor the data plane for the compression meta data.
> > >=20
> > > You could consider this as a security requirement(the memory region f=
or
> > > the MV could only be accessed by the decoder) or hardware limitation.
> > >=20
> > > It is also not very easy to manage such a large buffer that would cha=
nge
> > > when the resolution changed.
> >=20
> > Your argument are just aiming toward the fact that you should not let t=
he user
> > allocate these in the first place. They should not be bound to the v4l2=
 buffer.
> > Allocate these in your driver, and leave to your user the pixel buffer =
(and
> > compress meta) allocation work.
> >=20
> What I want to say is that userspace could allocate buffers then make=20
> the v4l2 decoder import these buffers, but each planes should come from=
=20
> the right DMA-heaps. Usually the userspace would know better the memory=
=20
> occupation, it would bring some flexibility here.
>=20
> Currently, they are another thing bothers me, I need to allocate a small=
=20
> piece of memory(less than 128KiB) as the compression metadata buffers as=
=20
> I mentioned here. And these pieces of memory should be located in a=20
> small region, or the performance could be badly hurt, besides, we don't=
=20
> support IOMMU for this kind of data.
>=20
> Any idea about assign a small piece of memory from a pre-allocated=20
> memory or select region(I don't think I could reserve them in a=20
> DMA-heap) for a plane in the MMAP type buffer ?

A V4L2 driver should first implement the V4L2 semantic before adding option=
al
use case like buffer importation. For this reason, your V4L2 driver should =
know
all the memory requirements and how to allocate that memory. Later on, your
importing driver will have to validate that the userland did it right at
importation. This is to follow V4L2 semantic and security model. If you mov=
e
simply trust the userland (gralloc), you are not doing it right.

>=20
> Besides, I am not very satisfied with the dynamic resolution change=20
> steps if I understand it correct. Buffers reallocation should happen=20
> when we receive the event not until the drain is done. A resolution=20
> rising is very common when you are playing a network stream, it would be=
=20
> better that the decoder decided how many buffers it need for the=20
> previous sequence while the userspace could reallocate the reset of=20
> buffers in the CAPTURE queue.
> > Other driver handle this just fine, if your v4l2 driver implement the v=
4l2
> > resolution change mechanism, is should be very simple to manage.

This is a limitation of the queue design of V4L2. While streaming the buffe=
rs
associated with the queue must currently be large enough to support the sel=
ected
format. "large enough" in your case is complex, and validation must be
programmed in your driver.

There was discussion on perhaps extending on CREATE_BUFS feature, that let =
you
allocate at run-time for a different format/resolution (no drivers currentl=
y
allow that). The rules around that aren't specified (and will have to be de=
fined
before a driver starts making use of that). Note that to be usable, a
DELETE_BUF(s) ioctl would probably be needed too.

In current state, If your driver can support it, userland does not strictly=
 need
to re-allocate if the resolution is changed to smaller. In most SVC scenari=
os,
the largest resolution is known in advance, so pre-allocation can happen to=
 the
appropriate resolution and queue size. Re-allocation is then rarely trigger=
ed at
run time. Unlike your system, IOMMU system are not as affected by allocatio=
n
latency and manages to do gapless transition despite this inefficiency.

Note that all this is pure recommendation. What I'm seeing here is a pixel
format documented with Android assumptions rather then mainline, and sent
without the associated implementation. This simply raises some question on =
the
viability of the whole. This is not a critic but just some verification tha=
t
ensure you are following the V4L2 spec.

> >=20
> > > > >=20
> > > > > > > > Signed-off-by: Hsia-Jun(Randy) Li <randy.li@synaptics.com>
> > > > > > > > ---
> > > > > > > >     drivers/media/v4l2-core/v4l2-common.c | 1 +
> > > > > > > >     drivers/media/v4l2-core/v4l2-ioctl.c  | 2 ++
> > > > > > > >     include/uapi/linux/videodev2.h        | 2 ++
> > > > > > > >     3 files changed, 5 insertions(+)
> > > > > > > >=20
> > > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/driver=
s/media/v4l2-core/v4l2-common.c
> > > > > > > > index e0fbe6ba4b6c..f645278b3055 100644
> > > > > > > > --- a/drivers/media/v4l2-core/v4l2-common.c
> > > > > > > > +++ b/drivers/media/v4l2-core/v4l2-common.c
> > > > > > > > @@ -314,6 +314,7 @@ const struct v4l2_format_info *v4l2_for=
mat_info(u32 format)
> > > > > > > >                    { .format =3D V4L2_PIX_FMT_SGBRG12,     =
  .pixel_enc =3D V4L2_PIXEL_ENC_BAYER, .mem_planes =3D 1, .comp_planes =3D =
1, .bpp =3D { 2, 0, 0, 0 }, .hdiv =3D 1, .vdiv =3D 1 },
> > > > > > > >                    { .format =3D V4L2_PIX_FMT_SGRBG12,     =
  .pixel_enc =3D V4L2_PIXEL_ENC_BAYER, .mem_planes =3D 1, .comp_planes =3D =
1, .bpp =3D { 2, 0, 0, 0 }, .hdiv =3D 1, .vdiv =3D 1 },
> > > > > > > >                    { .format =3D V4L2_PIX_FMT_SRGGB12,     =
  .pixel_enc =3D V4L2_PIXEL_ENC_BAYER, .mem_planes =3D 1, .comp_planes =3D =
1, .bpp =3D { 2, 0, 0, 0 }, .hdiv =3D 1, .vdiv =3D 1 },
> > > > > > > > +               { .format =3D V4L2_PIX_FMT_NV12M_V4H1C, .pi=
xel_enc =3D V4L2_PIXEL_ENC_YUV, .mem_planes =3D 5, .comp_planes =3D 2, .bpp=
 =3D { 1, 2, 0, 0 }, .hdiv =3D 2, .vdiv =3D 2, .block_w =3D { 128, 128 }, .=
block_h =3D { 128, 128 } },
> > > > > > > >            };
> > > > > > > >            unsigned int i;
> > > > > > > >=20
> > > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers=
/media/v4l2-core/v4l2-ioctl.c
> > > > > > > > index e6fd355a2e92..8f65964aff08 100644
> > > > > > > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > > > > > > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > > > > > > > @@ -1497,6 +1497,8 @@ static void v4l_fill_fmtdesc(struct v=
4l2_fmtdesc *fmt)
> > > > > > > >                    case V4L2_PIX_FMT_MT21C:        descr =
=3D "Mediatek Compressed Format"; break;
> > > > > > > >                    case V4L2_PIX_FMT_QC08C:        descr =
=3D "QCOM Compressed 8-bit Format"; break;
> > > > > > > >                    case V4L2_PIX_FMT_QC10C:        descr =
=3D "QCOM Compressed 10-bit Format"; break;
> > > > > > > > +               case V4L2_PIX_FMT_NV12M_V4H1C:  descr =3D "=
Synaptics Compressed 8-bit tiled Format";break;
> > > > > > > > +               case V4L2_PIX_FMT_NV12M_10_V4H3P8C:     des=
cr =3D "Synaptics Compressed 10-bit tiled Format";break;
> > > > > > > >                    default:
> > > > > > > >                            if (fmt->description[0])
> > > > > > > >                                    return;
> > > > > > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/=
linux/videodev2.h
> > > > > > > > index 01e630f2ec78..7e928cb69e7c 100644
> > > > > > > > --- a/include/uapi/linux/videodev2.h
> > > > > > > > +++ b/include/uapi/linux/videodev2.h
> > > > > > > > @@ -661,6 +661,8 @@ struct v4l2_pix_format {
> > > > > > > >     #define V4L2_PIX_FMT_NV12MT_16X16 v4l2_fourcc('V', 'M',=
 '1', '2') /* 12  Y/CbCr 4:2:0 16x16 tiles */
> > > > > > > >     #define V4L2_PIX_FMT_NV12M_8L128      v4l2_fourcc('N', =
'A', '1', '2') /* Y/CbCr 4:2:0 8x128 tiles */
> > > > > > > >     #define V4L2_PIX_FMT_NV12M_10BE_8L128 v4l2_fourcc_be('N=
', 'T', '1', '2') /* Y/CbCr 4:2:0 10-bit 8x128 tiles */
> > > > > > > > +#define V4L2_PIX_FMT_NV12M_V4H1C v4l2_fourcc('S', 'Y', '1'=
, '2')   /* 12  Y/CbCr 4:2:0 tiles */
> > > > > > > > +#define V4L2_PIX_FMT_NV12M_10_V4H3P8C v4l2_fourcc('S', 'Y'=
, '1', '0')   /* 12  Y/CbCr 4:2:0 10-bits tiles */
> > > > > > > >=20
> > > > > > > >     /* Bayer formats - see https://urldefense.proofpoint.co=
m/v2/url?u=3Dhttp-3A__www.siliconimaging.com_RGB-2520Bayer.htm&d=3DDwIFaQ&c=
=3D7dfBJ8cXbWjhc0BhImu8wVIoUFmBzj1s88r8EGyM0UY&r=3DP4xb2_7biqBxD4LGGPrSV6j-=
jf3C3xlR7PXU-mLTeZE&m=3DlkQiuhx0yMAYHGcW-0WaHlF3e2etMHsu-FoNIBdZILGH6FPigwS=
Amel2vAdcVLkp&s=3DJKsBzpb_3u9xv52MaMuT4U3T1pPqcObYkpHDBxvcx_4&e=3D   */
> > > > > > > >     #define V4L2_PIX_FMT_SBGGR8  v4l2_fourcc('B', 'A', '8',=
 '1') /*  8  BGBG.. GRGR.. */
> > > > >=20
> > > >=20
> > >=20
> >=20
>=20