Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 11:15:24 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Xin Gao <gaoxin@cdjrlc.com>
Cc:     peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
        irogers@google.com, john.garry@huawei.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf metrics: Variable type completion
Message-ID: <YwOPfKRggard+jGh@kernel.org>
References: <20220816173804.7539-1-gaoxin@cdjrlc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220816173804.7539-1-gaoxin@cdjrlc.com>
Precedence: bulk

Em Wed, Aug 17, 2022 at 01:38:04AM +0800, Xin Gao escreveu:
> 'unsigned int' is better than 'unsigned'.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index ee8fcfa115e5..8926de9617ef 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
>  				    struct rblist *new_metric_events,
>  				    struct rblist *old_metric_events)
>  {
> -	unsigned i;
> +	unsigned int i;
>  
>  	for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
>  		struct rb_node *nd;
> -- 
> 2.30.2

-- 

- Arnaldo