Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3da17219-afab-0a1d-88a8-f571f2cde5e4@amd.com>
Date:   Mon, 22 Aug 2022 20:10:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [RFC v2] perf: Rewrite core context handling
To:     peterz@infradead.org
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, alexey.budankov@linux.intel.com,
        ak@linux.intel.com, mark.rutland@arm.com, megha.dey@intel.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        kim.phillips@amd.com, linux-kernel@vger.kernel.org,
        santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20220113134743.1292-1-ravi.bangoria@amd.com>
Content-Language: en-US
In-Reply-To: <20220113134743.1292-1-ravi.bangoria@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTlUb1R3VXl4WmRBMFQ4eXc1NnhtcU4weFc3RHNpMlgrZ0g5YmhtV0cyQ1Vi?=
 =?utf-8?B?Wkl0eHk0dVQxR0hhckpMWjI5WmF5c0JuU3dFRGgxQ3oyZGh6L25wWnlpdExo?=
 =?utf-8?B?Z1BraUVqTVNiamNPRFVJenlicmVkbmN6ZTM4N1N0VXdLeU9VcjAwYjM1SXpt?=
 =?utf-8?B?TVhIc1MwR2tYUmlDeDhXbWhqYldYWlppTnZiMjVlRnZZQnlhaXkwS2NNeUFY?=
 =?utf-8?B?N2Nic2c1TWIrbVl6aUszKzNjK2E4TUg2amRUWXFCRkFoUG5pYTV3YXVmcHIx?=
 =?utf-8?B?V0M2ZmtKZTdqMnFwMzY3cHgrZEpseVpEQjhXNllxZHUvRDJqZXlPRFkzRnds?=
 =?utf-8?B?NnNxV1dWN1JFN1NWbGNQdHBjRE8xQkJtUE5BVkZzSzU3OXBVVUJDTnZObTB4?=
 =?utf-8?B?b0NzNE94U0lKd2JPN3NnSmp1RlljQnpEQ0c2Y0kxWEJnUFVFdlZMckFHdVBR?=
 =?utf-8?B?NGx0am5ud01MbjdQZnYvTG05YVFGWldxOTlkSDEzVElST3dVeEVUeUFET2Ja?=
 =?utf-8?B?UFB2cnJqZHhoNVRwV0gwUCs5UnhxKzBTMjZlV0JqbncrUi9kRXVEZFNZYkls?=
 =?utf-8?B?aFlQVTE4eW42bnpIbXhPd2dxVHZJaHJtUGRabFdoR2F2VFJVeU9wbVlaWnZp?=
 =?utf-8?B?b0FuaktGOWo2ZjZZSUwyeUNRbGpDTTBYK2xPRk9LUEE4cGJMVmJwdm9TT1Z2?=
 =?utf-8?B?RnF2T1VWUFBLbmpXNWRuQkwzRmpoZTNpZ0M4dHdKL3ZWN3BPdmVidXB3eXQ4?=
 =?utf-8?B?eVkvTTRoZ0k2bGhOYkJ3aFlwc05zQjJCUThrWDY1NXJweUJiaHRueGo0aTlh?=
 =?utf-8?B?TjhQMkRDWW1nVzRzd3V3cjdQa0N1RGd3ZHF1QVBGb2VvbHNIeHg1MGJPYnN1?=
 =?utf-8?B?TERjbVZRQ2l4ai9JZ3BJdlAvZ1VvQVJ3ZUtCZk1UbGlxUHN6YW5GeEFyT1VL?=
 =?utf-8?B?b2JoSEVhbmNtOEdlYVprVEd3UWdlaVRFSnpwUUdJaFBzK1MvTmVWTHk3SDFD?=
 =?utf-8?B?NE5yK1VXK1h1czJJczA4V2dmdDA2dnROV2NJZTRQZjkxZ2VMZVlpLzArV0wy?=
 =?utf-8?B?NkVudXh1d3BSV01ISGdMbTgvdDBJYTM0cVU2cWhlT2dKTFNhZGtCT0hiaHha?=
 =?utf-8?B?dUZJeDJHRVFxS2ZEZS96eVYrU2VsMGVXUW1yVTN1OWo3d0RPZ3NRU2tKNE5V?=
 =?utf-8?B?d1E0KzRXN2xxWDgzL3FyMmhHWmhhby9kYTdCZ2sweVNOam4wVm9VRnFIOWJM?=
 =?utf-8?B?MjlwMzEvT0xXR1UvcHo1d3BzQ2xiRnp5Ymo0Q3h5dWJEZlJsa0tjVmFZZHQv?=
 =?utf-8?B?SkV3WVlVUmxTa25zczk2aXhTQm9CMVpnODl3MlkvMHBIZU5sNysyVlh4SzdR?=
 =?utf-8?B?RzFGejd0L1h6bnl2bGpqSDNxYS9ZQXAwaW02eTdaL0tmSEZFNGYwK2lIUkZ2?=
 =?utf-8?B?UndvTFpoT054ZWxyZ0R3MVM2UXpQRjUvamJUK1FNQUVCK1YvbnVWaEdhQnlS?=
 =?utf-8?B?RW5hK2tmb0hLbGhIclJIVkRjcDdLT001V2VIdmZoM0NON05lMTVwaDVKYzJ2?=
 =?utf-8?B?UytLZlN2RVdEQ1ducVNEMlcvNXNRaDBtdmk1QVY3NHZaQzB3QmZ5aVNkQWlV?=
 =?utf-8?B?STJOdmR0amZ5K2h6QjNwTk51VGVWUUlFbWZEdm4wUkJzQ1F5YzI3T290OHE4?=
 =?utf-8?B?cFhTZ2x4ckg4azFyU1VweDk2ajlZRXBJRW1EdmxkRytDRm1VMDVSS3JHUEU1?=
 =?utf-8?B?b055UDdmcDQreklvcy9Ha3lJVnQ4NFJhWkVZZk1SOFI1VE1tL3pubFF3aThN?=
 =?utf-8?B?R2grbTU0dWJDczhiUElodDI2RlNoS1ptWnN5SFV6T1JEN25jOWVEOEtYTEJI?=
 =?utf-8?B?SXFCMXBLVG9TTFFWc3lFRWdYQjNhY09GREgxNjB1TXY1Q3F2b1hLOGpPRXNr?=
 =?utf-8?B?VmhtLzNENnlmOXo5cVBVVGV3M3piVVd0MWRyVW82cGFGQW1NckJKSWtwSi85?=
 =?utf-8?B?VVE0NUFlb0M3WlVwNkF4dmYyaXdUM3daWlM5b3gvWG1jNHZybWxEN2xoRlFm?=
 =?utf-8?B?TXlrdU1VSExZKzNNcnRBR25oZzZIcnBBcDd0RHRSbGYyQlQ4bUFkR2J4RG9s?=
 =?utf-8?Q?yfSXyhCl0YOE+7/iPe4t1RlE9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eef88bc2-fbc4-4510-8b21-08da844c4584
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 14:40:34.9415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XFDdaGEAQtUI08Qk9pHxrAK+6iJAUXfB4C/An05w7ieCxiuUwvhA5qfLUbn/FbKIA1mYXpbjE1ZE/AVg4tKOBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2491
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> @@ -915,7 +925,7 @@ static int perf_cgroup_ensure_storage(struct perf_event *event,
>  		heap_size++;
>  
>  	for_each_possible_cpu(cpu) {
> -		cpuctx = per_cpu_ptr(event->pmu->pmu_cpu_context, cpu);
> +		cpuctx = this_cpu_ptr(&cpu_context);

This should be fixed as well:

s/this_cpu_ptr(&cpu_context)/per_cpu_ptr(&cpu_context, cpu)/

Thanks,
Ravi