To: "Anand Jahagirdar" <anandjigar@gmail.com>
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
       "Andrew Morton" <akpm@linux-foundation.org>, akpm@digeo.com,
       "Daniel Hazelton" <dhazelton@enter.net>,
       "Jens Axboe" <jens.axboe@oracle.com>, "Jiri Kosina" <jikos@jikos.cz>
Subject: Re: Patch related with Fork Bobmbing Attack
References: <25ae38200706120949vaeb8e0ascd182ef2f709d0fc@mail.gmail.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Tue, 12 Jun 2007 10:04:17 -0700
In-Reply-To: <25ae38200706120949vaeb8e0ascd182ef2f709d0fc@mail.gmail.com> (Anand Jahagirdar's message of "Tue, 12 Jun 2007 22:19:49 +0530")
Message-ID: <adalkep85pq.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1051
Lines: 25

 > +	/*
 > +         * following code does not allow Non Root User to cross its process
 > +         * limit. it alerts administrator about fork bombing attack and prevents
 > +         * it.
 > +         */
 >  	if (atomic_read(&p->user->processes) >= p->signal->rlim[RLIMIT_NPROC].rlim_cur) 
 >  		if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_RESOURCE) &&
 > -				p->user != &root_user) 
 > -	
 > +				p->user != &root_user) {
 > +			if (printk_ratelimit())
 > +                                printk(KERN_CRIT"User with uid %d is crossing its process limit\n",p->user->uid);
 >  			goto bad_fork_free;
 > +		}

please run scripts/checkpatch.pl against your patch.  It will point
out numerous problems with the coding style.  Also, I think a space
between KERN_CRIT and " would look better too.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/