Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Liam Howlett <liam.howlett@oracle.com>,
        Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v13 46/70] acct: use VMA iterator instead of linked list
Thread-Topic: [PATCH v13 46/70] acct: use VMA iterator instead of linked list
Thread-Index: AQHYtjjAjWySsyrSK06scBybB6Zi8w==
Date:   Mon, 22 Aug 2022 15:06:26 +0000
Message-ID: <20220822150128.1562046-47-Liam.Howlett@oracle.com>
References: <20220822150128.1562046-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220822150128.1562046-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?B/kGGdvRvcHdUpBZnFUHD1Ym5pS0SKAsp0QJMhhKkIOSFosMGC1vxPLDg+?=
 =?iso-8859-1?Q?cM3Gyck798RF7AldZvLj4HxsZQljYrCkvSt6qWg0chsKMWj4ZBi9KjizH2?=
 =?iso-8859-1?Q?y11M4O04b1pSWxbuTVv+aKN9VEZdy4N+u88WbiXA28jwGd02Ho3152NkFH?=
 =?iso-8859-1?Q?kLRCLQiO06yAx8y9YK1zRleb546uyg3IZu21oQkVyij6mDZspeye0Z3UTN?=
 =?iso-8859-1?Q?qk86dHus0FpLYlQYqVQyQZ09ocnB4x7tYqc3a9+dH7csFO8EVBMTJo7dw0?=
 =?iso-8859-1?Q?krZCVn3lj6TlwLqsej1DOv62T4cR9C1nyZWD78Utwi15RvL6I4wgHPHlwR?=
 =?iso-8859-1?Q?p6HEUJo+UBVMg+jMHkIjbiLMsG5Y877B5FIcRV+78WT8uS5hBvC+AMHop9?=
 =?iso-8859-1?Q?g98dCb0RKU6VNu0ZOGEFnuLoR9rsJz6f5eP7Kk6mqwcyIvSLihgmBvQ9tR?=
 =?iso-8859-1?Q?DhRnJtES55IfmxQ3fe4VDJ/yraDallPx4A3sBm7mOyQmV7sfwFE81a2pta?=
 =?iso-8859-1?Q?KFXBR0vPvQPq+ylu7Zj8OwoPs48zXeOCHXKRpqfAK3ZPDtyl8T71Zs2mbP?=
 =?iso-8859-1?Q?PeK6JXCFExuEinPIl0IyICkSKhLZCjB3cJBxaPMi5jtLUFeTqOKVWsEa7Z?=
 =?iso-8859-1?Q?II5e2mEA5hbihtX3ZuFlzmESJ4L6o11Luyt8UTZWMPu8xm967V2sNmkIsZ?=
 =?iso-8859-1?Q?YBLSkyGr5x+VyK0pPq08ufzGOsslAXrFLW3k+s406xlyRsevxPw8nj2Bid?=
 =?iso-8859-1?Q?3NV7L42JquT90kGSo6hGnG/vMFHou2rwOifEjHkzzZpuWJs56qHN1HtMFs?=
 =?iso-8859-1?Q?b46qAVtRh1wfJKaq6cTBp6U8U6N8tl1o2MC/jWHW3p7Q1i5j+IFFz8aMHy?=
 =?iso-8859-1?Q?3+VhMWkONDESCMRe4O8ua5pcf0S3kKjyKa6vzr+zgTivYuvqrNQ90ri4VA?=
 =?iso-8859-1?Q?y5V+c1sjmCusKIdMDmJN3FaX0LLHAmDx3yDQ0dfycl++bVGp4tQXlznDyj?=
 =?iso-8859-1?Q?pKyIU6JF/p2CsS2BS6pT37956SE4YOLx13TVVQJU9S5ACFapWMm0/3UeDu?=
 =?iso-8859-1?Q?9kw1u23UBUayCHccCzthiOmZpGR+WGrRE40sQrC1x1Nw/ixJ/sQy47VmOu?=
 =?iso-8859-1?Q?nJCCeOlcSiA4J6dk6tA4mhQexB+hLiTnycFue8oX3UB+uiwZah1T08xJHD?=
 =?iso-8859-1?Q?AG0OvGnErafsKDb+n6+Pku5uEKy8mUC+sCBOkmHaMhr+watitKNuWU/Rr1?=
 =?iso-8859-1?Q?Vbk/FhS19xY2LkfGsNxJb/bkIQWJKdugKAHSL8r5begskrzvXX9byB/SDv?=
 =?iso-8859-1?Q?/rLrPY7bRn0PFgkADVyf2e7rv5tarWCWSlIM5K6o/lskKWgGGiplz/UBy7?=
 =?iso-8859-1?Q?X/7FFEqGywAIn4V2TJh/xZCjPLzcVemfSU6fZwD6kJjQKj+x4XssAg9BfV?=
 =?iso-8859-1?Q?4Ok05amXgy6116MvpyXukDHWASQxQxReKxOoIs4MHOza1cya32xPXCJqBZ?=
 =?iso-8859-1?Q?qRbJF8LUVP6Nn6HDago45uGU2rj4OCl+svIKEjK9IrybTOpVV3a01uVbT7?=
 =?iso-8859-1?Q?ZXmJuvKP8SRglU/HLzFfD/IS6vCgwphZSKs3aTvpnyvxXidj+p+lEHhM6+?=
 =?iso-8859-1?Q?uFDkBUAdHHqvi7Rmm70w5HBKIABKs/SSNCp2KcjhhyBcsX9S8UOlEyQQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe533d6c-05af-4aed-f724-08da844fe3f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2022 15:06:26.8787
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fdEjIwhIpNPL4KaRrWlJCQKFcAVvF0xIFQed+ytsMh9DmLdwZd71h+JjmNSWUCYLcwJVGSwX1cSLECpFVQelPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1433
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_09,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208220065
X-Proofpoint-ORIG-GUID: aDmKd0lirHXsKO0q_eDsFKY-_U0-PpGS
X-Proofpoint-GUID: aDmKd0lirHXsKO0q_eDsFKY-_U0-PpGS
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 13706356ec54..62200d799b9b 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -555,15 +555,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.35.1