Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Liam Howlett <liam.howlett@oracle.com>,
        Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v13 49/70] fork: use VMA iterator
Thread-Topic: [PATCH v13 49/70] fork: use VMA iterator
Thread-Index: AQHYtjjALUhylvreZk6n/LUIopz1JQ==
Date:   Mon, 22 Aug 2022 15:06:27 +0000
Message-ID: <20220822150128.1562046-50-Liam.Howlett@oracle.com>
References: <20220822150128.1562046-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220822150128.1562046-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?X6sTFrFi3oqtof3ooPoMVfhMV2I4fd23ok2c433tGH1ps2oFPLQqEbTIl4?=
 =?iso-8859-1?Q?W78vNhlS7afg8j8m72HlCcEFNnXyT8cnJE3WhP1QkvFS+UafoglpcML8Ob?=
 =?iso-8859-1?Q?Zz7xYZS5TNLcDUI23KJ6WSrySE+JTaYpTVs3BI2vyYcuNz6LovUv7IEfsA?=
 =?iso-8859-1?Q?2ByLqFAihVP6nQvTaFJpWxZtR01akzZbvEeovXgH663EOBBFD9+PfHO4az?=
 =?iso-8859-1?Q?7+MHfTuMa4i0lRjoQDVgeoinI6VYIXFtfqlQuTu3wiyiLh2eV5mo7u+den?=
 =?iso-8859-1?Q?g+tyad1TSyKIFVaUthFHKv2fwxK8+5inKzoiodEOm25BCeZptHArXjgtSQ?=
 =?iso-8859-1?Q?6LrqdcXwt5frQXCw4CWnZyPmMlFfuI1nyyTURlvoDH+xsE0ulkAVjbdDxI?=
 =?iso-8859-1?Q?sYLSwqOiUbPi0qfcOMF5AxP40zaJF+0B36+F+9b51yc0OOwQyQADKgdQ2t?=
 =?iso-8859-1?Q?ytamFYVXejrNaGuxxIjdApEZ6Xpt/HxR5catMBb8mC1mhGyoaqXV8KA7pa?=
 =?iso-8859-1?Q?VihFXxBbJosIJGguxY76xcO2ueMacnFLhoxA+x1a+kbPP52PKWhFqQ9Zg3?=
 =?iso-8859-1?Q?m0sLFH38TyCbjZIBkMuia29B9R8xemgFqh+KnHJgcw4RcDnb613ShmWe8c?=
 =?iso-8859-1?Q?Sm79aky1KRjEUeF0ikuH5ml8L6rSJH/S2tIEiCpS3XnBCZuxgQXQNpO/it?=
 =?iso-8859-1?Q?HanfOCtIPZicLS4KZeV/mk1nSNvovl7z2Y9dMpcmMvo4AxkdGADcGAEQMf?=
 =?iso-8859-1?Q?UZylMWau0azQQabcL+hj5w96JeS6JtYWWhYc2YtRwVowwuXNC0y60R/l+7?=
 =?iso-8859-1?Q?1fKqib3xZEl4pYQjVXoGdzjKp2pxl1KYRXjiS5VpZm9T6TaYDIfHfix3zB?=
 =?iso-8859-1?Q?Vg/Az1qNhKa2KiFq5Qc6B6WmoHRwhrYxIGIZuQxEZAcohBCsitWzHWIMmm?=
 =?iso-8859-1?Q?n7NyiVI/i8lU9xB5WU24tNEZsa+ysMmUopWXLcU/N4WJYVGuZzZ2Z3BtRe?=
 =?iso-8859-1?Q?s4UbNlfTQTRY7ZMeWBrOkvjepjvsDpm/2o0xYE0rahBI7sLXVq7dmBfmM1?=
 =?iso-8859-1?Q?Jb4hPI8Z6EQzXxXSW3ciEpUq1a8AZl4zNutQBxrwdmgyEuXC1pVFQ25HFm?=
 =?iso-8859-1?Q?mFNHwaVMMHKrVajK+wM2Ldycm0eiY3eiMSSfGeToep5GvVgc2/DgE5QJQ/?=
 =?iso-8859-1?Q?0z0hge8JDFiVtLwL+bXjlk1SY4oZeutAMrkWQhnxGyBTOOL4CzeV34hJhu?=
 =?iso-8859-1?Q?aJBkQbO9PG8NTgyynJoXZsk5JnwG+TyjjIJy7IAahkEDGjd1wbmoHP90+g?=
 =?iso-8859-1?Q?KR6JnH8vUPpARyx2DXpms2ipKF9ulAxuEY3DFo+0nkcpcHnNDkD0O3F5DD?=
 =?iso-8859-1?Q?pwH5fDppxBu7q6o+6yLmDoixvpQmzACDvbT/WHfxPzDlKbnks0h0iTRQzf?=
 =?iso-8859-1?Q?3agA/WWrLoEDwit3tqw6RZDCXndcpJdRLKnlo7PNVPnnx0TPAI5qnd9XJx?=
 =?iso-8859-1?Q?2C7dGdNQ8+Kvh6OiX8aDi5LICRszuElfHivmLyfeY6FKlYUlD9S+d1ZxD/?=
 =?iso-8859-1?Q?g3NY7bkGp4KaowEK7ZRgEeF/uqEBKk1QO3qist307fPwFSxo8vFu+0MJcZ?=
 =?iso-8859-1?Q?B3Ko/7tf/Jx4YrENOOs9AWmZyZYpMvht4+GdzbLFfxdrM971M59Q84LA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b3c3cb2-6ed1-4d82-fa19-08da844fe4fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2022 15:06:27.9256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DjS05e/IqE21YAKXObFBi4tWxg++qPB0B1Zp1CVJc/plLpzLxvPpLp8vBDeFAgxlt9DT+o8JVtVwkR5oZIv8Mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1433
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_09,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=984 adultscore=0
 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208220065
X-Proofpoint-ORIG-GUID: ZCu96z9geicd3NMvukpyS3bSKp9XWEn0
X-Proofpoint-GUID: ZCu96z9geicd3NMvukpyS3bSKp9XWEn0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list and removing the linked
list will shrink the vm_area_struct.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 kernel/fork.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 430f63cd7a37..49e4ab6f5208 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1301,13 +1301,16 @@ int replace_mm_exe_file(struct mm_struct *mm, struc=
t file *new_exe_file)
 	/* Forbid mm->exe_file change if old file still mapped. */
 	old_exe_file =3D get_mm_exe_file(mm);
 	if (old_exe_file) {
+		VMA_ITERATOR(vmi, mm, 0);
 		mmap_read_lock(mm);
-		for (vma =3D mm->mmap; vma && !ret; vma =3D vma->vm_next) {
+		for_each_vma(vmi, vma) {
 			if (!vma->vm_file)
 				continue;
 			if (path_equal(&vma->vm_file->f_path,
-				       &old_exe_file->f_path))
+				       &old_exe_file->f_path)) {
 				ret =3D -EBUSY;
+				break;
+			}
 		}
 		mmap_read_unlock(mm);
 		fput(old_exe_file);
--=20
2.35.1