Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <319927f9-5265-81fd-2c6b-7c5146d90687@foss.st.com>
Date:   Mon, 22 Aug 2022 18:21:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: (subset) [PATCH v3 0/2] spi: stm32_qspi: use QSPI bus as 8 lines
 communication channel
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
CC:     <christophe.kerello@foss.st.com>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
References: <20220816161344.2599908-1-patrice.chotard@foss.st.com>
 <166118433897.209120.16190099503428270567.b4-ty@kernel.org>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
In-Reply-To: <166118433897.209120.16190099503428270567.b4-ty@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Mark

I just noticed that the cleanup() callback is useless as the gpiod is 
automatically freed by devm.

As you haven't send your pull request, do you accept a fixup patch you will squash 
with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback"
or standalone patch ?

Thanks
Patrice


On 8/22/22 18:05, Mark Brown wrote:
> On Tue, 16 Aug 2022 18:13:42 +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> The goal of this series is to allow to use QSPI bus as a 8 lines communication
>> channel for specific purpose.
>>
>> The QSPI block offers the possibility to communicate with 2 flashes in
>> parrallel using the dual flash mode, 8 data lines are then used.
>> Usage of cs-gpios populated and spi-tx-bus-width / spi-rx-bus-width both set to 8,
>> is needed to enable dual flash mode.
>>
>> [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> 
> Thanks!
> 
> [2/2] spi: stm32_qspi: Add transfer_one_message() spi callback
>       commit: b051161f44d414e736fa2b011245441bae9babd7
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> 
> Thanks,
> Mark