Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79580753-6290-2da4-2949-c408333b8af5@quicinc.com>
Date:   Mon, 22 Aug 2022 08:14:39 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 1/4] soc: qcom: qmi: use const for struct qmi_elem_info
Content-Language: en-US
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20220822151146.30366-1-quic_jjohnson@quicinc.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220822151146.30366-1-quic_jjohnson@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

please ignore this, rookie git send-email mistake

On 8/22/2022 8:11 AM, Jeff Johnson wrote:
> Currently all usage of struct qmi_elem_info, which is used to define
> the QMI message encoding/decoding rules, does not use const. This
> prevents clients from registering const arrays. Since these arrays are
> always pre-defined, they should be const, so add the const qualifier
> to all places in the QMI interface where struct qmi_elem_info is used.
> 
> Once this patch is in place, clients can independently update their
> pre-defined arrays to be const, as demonstrated in the QMI sample
> code.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> 
> v2:
> Added missing const to skip_to_next_elem() return type
> Reported-by: kernel test robot <lkp@intel.com>