Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Linux-MM <linux-mm@kvack.org>, lkml <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        X86 ML <x86@kernel.org>, Christoph Hellwig <hch@lst.de>,
        Kernel Team <Kernel-team@fb.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>, Song Liu <song@kernel.org>
Subject: Re: [RFC 0/5] vmalloc_exec for modules and BPF programs
Thread-Topic: [RFC 0/5] vmalloc_exec for modules and BPF programs
Thread-Index: AQHYs1RC3fzFDgbD7kKge/abI0eC0q27FhIAgAANe4CAAAYdAA==
Date:   Mon, 22 Aug 2022 16:56:47 +0000
Message-ID: <7621DE6E-D71D-45D1-BAFA-46E882451DD9@fb.com>
References: <20220818224218.2399791-1-song@kernel.org>
 <4D089469-B32B-4347-A811-B1E5EE011307@fb.com>
 <YwOwLYUXuSn5acIG@worktop.programming.kicks-ass.net>
In-Reply-To: <YwOwLYUXuSn5acIG@worktop.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SHaRzLcunt/C+RrVVd9tAV6VTw9Ld/wx1pC40w78sGttHa5YRcLtUaMUcIH2?=
 =?us-ascii?Q?LgJq9DMqa9+jAOJyce/8wn0TGyuG1ThpUzmp9KCyi+U2qEmOAadiE3ezGNFp?=
 =?us-ascii?Q?tH1iJ34dO9uwet3qzlURJu9oZS1fjvcny6idIx53uJqAMppYCx0zcmi0Xx/r?=
 =?us-ascii?Q?b7KFTc0MXUTJbgQ30JNzXDVpNeFFdDsfK0VrBwNthRpV6IO4KCqo7/VgIUoI?=
 =?us-ascii?Q?2eVlVFMfoYuFlYyXH/J2Tu5iBNAtQPhGMRpLE2AvFk12IsJEUnCgF7ywffpR?=
 =?us-ascii?Q?86nYKW1kBmhk5zvAlE21A8pTppPfDJKe9FpXNH7YgO4dZnKcgG9uStmddw6T?=
 =?us-ascii?Q?KeeDsOtVlaB+2qQn31f2PECjDxzvo7MPTvSoiSxE5tpM0ysBgoJK+JOaxefG?=
 =?us-ascii?Q?rPsN1FiMRXyp6kK1MUPG9iV3Hu4g4tOmLFKRtqQb3AZg5lvVnNDpUSbSyDJ5?=
 =?us-ascii?Q?WItDUSXpzVOAaEUk0Jzw8vb5wcL+MkIjQtIJblH4W/SDkxntbpYlEiQM48s9?=
 =?us-ascii?Q?0HyG2VQxLaFJmgVhS9zaP+QyBYeGEcix3DB38nIzbPtLZRbVgHBsWiC0/sXT?=
 =?us-ascii?Q?5SicqONohxqqVDrYfNEEPkyGY5ufDfPfCK9/PCpfXqj4kMLjFLDbKuQnD8Vk?=
 =?us-ascii?Q?GKHAn7WyoBxsu6725YPdmU75an+IDNqvKFJlHA5uVONFvIGgZLzL5mAabZTp?=
 =?us-ascii?Q?a+Eof8t2s6jz9IycILvNBYeyhEzBhRx2ZHrWOk/nH6qsffSHaxnwtkjnZEVW?=
 =?us-ascii?Q?mlyO8PiEAAqSls3tT4p9EhL16dc2ucL/i55FuJ0G+q1frR5qYLvvsdCDXRII?=
 =?us-ascii?Q?pUu0B8637ZZBarEX1+mO+CPYkKSZPy5rNUFrL7zDU2WlecQNcgaFRZGtbvuL?=
 =?us-ascii?Q?FtSg553HsY+cQ9BQhRm5GYnvfh2JzdOARAj+fZ555l+qBXRH+2whjLn/S7Cj?=
 =?us-ascii?Q?CU6vxv5DLC05mOfGSG31L/+mWh4NeAMs9oMmOjXmSjlF+ug6Khvuk5o6tEvu?=
 =?us-ascii?Q?kGYJs+Fuk/0JNffByHQO5NYZr7aCyg3kGKlU39chrDLVNqMme2ywhWus4VjF?=
 =?us-ascii?Q?TV2pd4v1KbgI2G0K/oj77uwFFet0TK7eCDz1dMpHnJo9OjAwUakU2irbj43v?=
 =?us-ascii?Q?+tHc9g3ty5pOAE+YrzytUJlHmHDn9HKBSNCxaJHSOPDgEx0U9qJjKWTp2+sE?=
 =?us-ascii?Q?/Dk870eagL/KRhKV+dDW090jQ+YRtrdAI/CfydLCCYW1sDGInA056VHf7MYT?=
 =?us-ascii?Q?f2/omhY8nDurkuM29OiP7P2J5dN4uYLed88YSYQbppacTLACNTkgWXpsPN0m?=
 =?us-ascii?Q?9IbI7dY9ZmxOSGktkLXGpzcy0Csqoa3zi4UApCK69A7MWFpZD73tHgKCZ5Vz?=
 =?us-ascii?Q?5JLl3FN8iT6Wckvbhjjhw2Hr5mAIX4ivPXSqfnVyhEIgCLPs3xjtHmDkkcb8?=
 =?us-ascii?Q?pbnoB+CPstIILqYWRZxRJZx6OTCiRQNAZMASvb8TKyzr8/UUICpWBNmR6cXl?=
 =?us-ascii?Q?t76Kojw3lk2BqwUUi4ydGPCOSRDNdPM1d8Nx1MgnJRCEZUj7l1b3a0mRj/8F?=
 =?us-ascii?Q?HN45AK7RcDh9JVzEftiBUhfVW7TbAqmnGWxOWYl+6D3VAhGvuztSTcZSvCLd?=
 =?us-ascii?Q?PH/3P+xW7ekviIZ1SzrEdmg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C221B4C5E9ED344CBD836B8AB746E7F5@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f34e7c0-7006-4ae2-5308-08da845f4d24
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2022 16:56:47.6707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lYsrhcjKn2DPwdju4NBzFdGVM/Yu7eG6W8ucBLPVmM8ZSmDOKxbMkPfGngl1nbaxnn+SPlkDobz9ZWlkWWPCeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR15MB4425
X-Proofpoint-GUID: UI4NuupBbR88NPda3MtRenMrs1-AU5aK
X-Proofpoint-ORIG-GUID: UI4NuupBbR88NPda3MtRenMrs1-AU5aK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-22_10,2022-08-22_02,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 22, 2022, at 9:34 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Mon, Aug 22, 2022 at 03:46:38PM +0000, Song Liu wrote:
>> Could you please share your feedback on this? 
> 
> I've looked at it all of 5 minutes, so perhaps I've missed something.
> 
> However, I'm a little surprised you went with a second tree instead of
> doing the top-down thing for data. The way you did it makes it hard to
> have guard pages between text and data.

I didn't realize the importance of the guard pages. But it is not too
hard to do it with this approach. For each 2MB text page, we can reserve
4kB on the beginning and end of it. Would this work?

There are a couple benefits from a second tree:

1. It allows text allocations to go below PAGE_SIZE granularity, while 
   data allocations would still use PAGE_SIZE granularity, which is the
   same as current code. 
2. Text allocate requires mapping one vm_struct to many vmap_area. Putting
   text allocations in a separate tree make it easier to handle this. 
   (Well, I haven't finished this logic yet). 
3. A separate tree makes it easier to use text tail page, 
   [_etext, roundup(_etext, PMD_SIZE)], for modules and BPF programs. 

Does this make sense? Do you see other downsides with a second tree?

Thanks,
Song