Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2757626rwa; Mon, 22 Aug 2022 13:11:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR7N2X8eBwcrhfDPySmC1GUvR9b6nYrMJccsUsqILaKgpSv0035W5KEF9m6GsQ7NKI/+SZ2I X-Received: by 2002:a62:e304:0:b0:536:bdec:5800 with SMTP id g4-20020a62e304000000b00536bdec5800mr4589973pfh.49.1661199110215; Mon, 22 Aug 2022 13:11:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661199110; cv=none; d=google.com; s=arc-20160816; b=wE/RYqFmSvBbZ7imT8wXZJwCizy+5BOYJkQu6Jh9JlE6KFG+nVHITMQYYZefa2fbqM uUIti9HAvvOdf4LAWfQcrCrCJe66Cv/GN87vqGIVxMomjtWbhajhNBS4dClhszOzrwwA 6slK6BXMCjAHXQ7O+8CQ5WYkGdKWSyBmLQ3tUmuVcGmAfrhRhcoriT9ZvwSJWmh/aYdj TvN/RDpwd6I7RzU3JECJXvbPVkgUXiGHOg+/1OadC85zYWptRzOPpE7Od5Vg22CmXkQG q6d4HbCVm1FSkZUP+QWPZZzc4Bv7gx1qLG/cJgR09GTjqE4keLlVWzVU8PwwpeObpW8U TgUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=RZpX33SQG/uaVlRMoFcxzWwH5bvWTFtzv9I8YsCSbE4=; b=z8I4pmFMBsREW4oBt7DsxM4Py9qHFQ3ArBnF2q4uV3qShz+fwnQ/nS0rdF0nqO2s42 Bfwb/4DaNSYuAuxdpPGYH6zXD+TShI80J64kk60KbvfaIwQUEE0up33bWIKsrynYYHP9 ErW4ZPc8JoM/3Zbgb0nycq+EVEOAbuPCurOPEh3udJ4vf7HdzSJg5Xgw+IWTC1jvHd9+ 32sMK5vBtvozPD4ozdPPLI2IfbFkF+qHKCgV5kFwuYwjmRDwuB+YT1+4jw8F5ZEQHH1n 9F9WYNJmgdHQ9tlgdC1wpVH7u11dtf9EagZj/QZ4Eg7iuTC83alsqpwiLuPRTECUBlPf GWJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q+VD/QLy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x63-20020a638642000000b00429a4146526si12869462pgd.0.2022.08.22.13.11.37; Mon, 22 Aug 2022 13:11:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q+VD/QLy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbiHVTtW (ORCPT + 99 others); Mon, 22 Aug 2022 15:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237151AbiHVTtP (ORCPT ); Mon, 22 Aug 2022 15:49:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC2D33A3A; Mon, 22 Aug 2022 12:49:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37216B812A3; Mon, 22 Aug 2022 19:49:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23B9AC433C1; Mon, 22 Aug 2022 19:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661197749; bh=RZpX33SQG/uaVlRMoFcxzWwH5bvWTFtzv9I8YsCSbE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q+VD/QLyJ92ZHhvqcfdQKu2Qc5w83Eo+uwDBdycXuPumZoT7FaBfATXrjIOkxM2Jp Wx6elk7eJvxUOiOKtqIRE79BMjJpV87lH8afcA7LBTtZZ0xEyPGKfwZzMIUV9fgiPa BUKxprIFsdAcbJEaoLM4j1+jxlHvN4aWvzFK1njZpPgXtxn0xviCP2FLa8uBQlOrSu 9yJ/SCu9y37LjhjATOF1YrStPG0XHxtd4cfcE0yX3PeCQjH5DNFM37qN7aFF3JxB8X DfSz/+6d0O3+kKuMYCkcYF2AHupnssukCVbYmhGMCqh4SbA7xfkFjWp0VFyc8vsRRg O07nrRcJnJYPA== Date: Mon, 22 Aug 2022 20:14:40 +0100 From: Jonathan Cameron To: "Vaittinen, Matti" Cc: Andy Shevchenko , Matti Vaittinen , Nuno =?UTF-8?B?U8Oh?= , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH v3 07/14] iio: ltc2688: Simplify using devm_regulator_*get_enable() Message-ID: <20220822201419.20149725@jic23-huawei> In-Reply-To: <9482dea1-fd70-00a7-df4c-640772ea53b4@fi.rohmeurope.com> References: <20220820122120.57dddcab@jic23-huawei> <412c5d22-d59b-9191-80dd-e3ca11360bc4@gmail.com> <01fec744-f3d4-b633-d3ce-bcd86a153132@gmail.com> <103abfae-6c0d-9a2e-2d59-0da4c8be3eb4@gmail.com> <9482dea1-fd70-00a7-df4c-640772ea53b4@fi.rohmeurope.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Interesting to see the different mental models used when reading code. Overall I'm fine with either static within function or static outside function depending on author preference + for short cases like this I'm also fine with them on the stack. Obviously can only speak for what I'll take into IIO! Jonathan