Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2775973rwa; Mon, 22 Aug 2022 13:37:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR7td5p6Mp22+u/rWmNP4v1igAxB8u4ksMZRiyDPyB8g4kwgQHYdW/PhCWU9CxGxNqpIAQA+ X-Received: by 2002:a17:907:3f0c:b0:73d:60fc:6594 with SMTP id hq12-20020a1709073f0c00b0073d60fc6594mr9081876ejc.669.1661200639489; Mon, 22 Aug 2022 13:37:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661200639; cv=none; d=google.com; s=arc-20160816; b=CD/XGsvYp98tVB5QV5DsW40XQdbBuFK2fThbj8uYLZs249ke8htauMm6/NEgovTWoT pObYVO1g5Jevju/LepAEhsGy5AFr1DtW7qXOFPAgCtiubZ0hcatFUVLoXzyqtoaZ/0mT QX7NG66VjbwmaY9pWSbRliH4co9L7ev+PzlEDJUd+bAS0KYIT/PQW7k9YYap9PSr4t0Q FpaOsX1meN0GP0Ycpsb9XVcbqUSZkz8W4ifFYllc2+8euE12qF1Ne6tqiZmFGhoj3Lf+ VsGx/V2c+8ek01O2Fmxg3nFks1Z3AL+v63kAMZDfZ0u9vmUI3kPNvZnnbZYMFJ6d8Mwi rVtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gUUJGDZZ7SmwoHkhrT602wMnsCfmfrGrVbXmH2wIM3g=; b=YpPXmGDsbcUdo0PI7XibkUjmdUlpqOst6Z+30Wue6JbsyewXgXEM920FMbTJt5t5Et nTB/xQm03TvK9BZMsJTEcneUirrmqfLTVHnvXP9a08UE0jWs+oSf6I56AZLGhm6XU8sa 9q6Fwa+pA3qX+Dtu+FmWK0Rxn8e+Z/WKYPLhcePBEsRfwnbkovzHCkJ01UU93vnmXxiI 0WtFl57PPKaxhZXoGfv2Zpfl/Fw1jZCP91zxhCpZzEqXaCwpE31gS0mHbALn/57cMFG4 dyS2FDRzsE7gsRw6Ibp/o2ZAV3WqTeK/jnjIAboks+v6MTnZfGeHDA4Ngzld0kwoHETV 0g3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z+tUKeCl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020a05640242d500b00446c417f043si526672edc.6.2022.08.22.13.36.54; Mon, 22 Aug 2022 13:37:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z+tUKeCl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231494AbiHVUcS (ORCPT + 99 others); Mon, 22 Aug 2022 16:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiHVUcQ (ORCPT ); Mon, 22 Aug 2022 16:32:16 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4D352827 for ; Mon, 22 Aug 2022 13:32:15 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id x25so11693308ljm.5 for ; Mon, 22 Aug 2022 13:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=gUUJGDZZ7SmwoHkhrT602wMnsCfmfrGrVbXmH2wIM3g=; b=Z+tUKeClXChR4jRlQGg41fHbT2bJsJZqVxlH7TSDRnIKVcsWoXGws6FK/hz5EGuT4S yPu/tIYvMiV5u9nagc3sJ7K7VFdaJs3UH//tmuGoe95tcbMp5ov4mybmPAqUAwktzqOI V0PJNpbtkpzFVVxtumlOm80eN4+ci0qXNJMp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=gUUJGDZZ7SmwoHkhrT602wMnsCfmfrGrVbXmH2wIM3g=; b=JG3MSxmQE8mV4pq1uywz0vTqmoe/3uApjXhRQ1Q1o2pZd4oHEYF3IxsRoyf4PxLzwy niCmvfzdDynNlTQ/LkLH0/w81Y0lcbl25inFpAGk+LgFDYB3MJWbyH7Qd/p59qA+dKjB LRJiKuR3pjSBs2+p1heelJcQiErmjlkoQHKN2jc9CAxgLFfKPHm+Zm6jtFEnGs/mK9V6 WBrdMm3/Asw1jl2OLkwMZEs3Bsan9r9ZGk+KMGqmjkYcocR2/pikBVZXRZx1dtE76rM+ FvCJRGcv8fCT1E2y/lG/PMAiXVHzbSytoojwoaB1RjMOJpTFe9pPmHTCbgv0hAejUOeq upbg== X-Gm-Message-State: ACgBeo2jUgeOuIvv1YGlNrOAAv+RkCPLy7q0Z4hxyg2fkZrHAVsEDr6U HN4HZDy6dK+WsG4JBuzRA/X/dTlWAs3qJ87vATQ= X-Received: by 2002:a05:651c:221e:b0:25f:f069:1c13 with SMTP id y30-20020a05651c221e00b0025ff0691c13mr6516675ljq.390.1661200333323; Mon, 22 Aug 2022 13:32:13 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id k17-20020a05651239d100b0048d076373d0sm2088004lfu.98.2022.08.22.13.32.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Aug 2022 13:32:12 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id d23so12531815lfl.13 for ; Mon, 22 Aug 2022 13:32:12 -0700 (PDT) X-Received: by 2002:a05:6000:1541:b0:222:cf65:18d7 with SMTP id 1-20020a056000154100b00222cf6518d7mr11504823wry.659.1661200321380; Mon, 22 Aug 2022 13:32:01 -0700 (PDT) MIME-Version: 1.0 References: <20220819221616.2107893-1-saravanak@google.com> <20220819221616.2107893-4-saravanak@google.com> In-Reply-To: <20220819221616.2107893-4-saravanak@google.com> From: Doug Anderson Date: Mon, 22 Aug 2022 13:31:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/4] Revert "PM: domains: Delete usage of driver_deferred_probe_check_state()" To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Joerg Roedel , Will Deacon , Robin Murphy , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peng Fan , Luca Weiss , Colin Foster , Tony Lindgren , Alexander Stein , Naresh Kamboju , Geert Uytterhoeven , Jean-Philippe Brucker , kernel-team@android.com, LKML , Linux PM , iommu@lists.linux.dev, netdev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Aug 19, 2022 at 3:16 PM Saravana Kannan wrote: > > This reverts commit 5a46079a96451cfb15e4f5f01f73f7ba24ef851a. > > Quite a few issues have been reported [1][2][3][4][5][6] on the original > commit. While about half of them have been fixed, I'll need to fix the rest > before driver_deferred_probe_check_state() can be deleted. So, revert the > deletion for now. > > [1] - https://lore.kernel.org/all/DU0PR04MB941735271F45C716342D0410886B9@DU0PR04MB9417.eurprd04.prod.outlook.com/ > [2] - https://lore.kernel.org/all/CM6REZS9Z8AC.2KCR9N3EFLNQR@otso/ > [3] - https://lore.kernel.org/all/CAD=FV=XYVwaXZxqUKAuM5c7NiVjFz5C6m6gAHSJ7rBXBF94_Tg@mail.gmail.com/ > [4] - https://lore.kernel.org/all/Yvpd2pwUJGp7R+YE@euler/ > [5] - https://lore.kernel.org/lkml/20220601070707.3946847-2-saravanak@google.com/ > [6] - https://lore.kernel.org/all/CA+G9fYt_cc5SiNv1Vbse=HYY_+uc+9OYPZuJ-x59bROSaLN6fw@mail.gmail.com/ > > Fixes: 5a46079a9645 ("PM: domains: Delete usage of driver_deferred_probe_check_state()") > Reported-by: Peng Fan > Reported-by: Luca Weiss > Reported-by: Doug Anderson > Reported-by: Colin Foster > Reported-by: Tony Lindgren > Reported-by: Alexander Stein > Reported-by: Naresh Kamboju > Reviewed-by: Tony Lindgren > Tested-by: Tony Lindgren > Signed-off-by: Saravana Kannan > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Douglas Anderson