Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7ac99deb-33a1-ca62-510c-e319c759934d@gmx.de>
Date:   Mon, 22 Aug 2022 22:07:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] video: fbdev: radeon: Clean up some inconsistent
 indenting
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        benh@kernel.crashing.org
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220819110659.110384-1-jiapeng.chong@linux.alibaba.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220819110659.110384-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/19/22 13:06, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/video/fbdev/aty/radeon_base.c:2107 radeon_identify_vram() warn: =
inconsistent indenting.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D1932
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.
Thanks!
Helge

> ---
>  drivers/video/fbdev/aty/radeon_base.c | 46 +++++++++++++--------------
>  1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev=
/aty/radeon_base.c
> index 0a8199985d52..1e6ac7ef3e73 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -2095,34 +2095,34 @@ static void radeon_identify_vram(struct radeonfb=
_info *rinfo)
>  	u32 tmp;
>
>  	/* framebuffer size */
> -        if ((rinfo->family =3D=3D CHIP_FAMILY_RS100) ||
> +	if ((rinfo->family =3D=3D CHIP_FAMILY_RS100) ||
>              (rinfo->family =3D=3D CHIP_FAMILY_RS200) ||
>              (rinfo->family =3D=3D CHIP_FAMILY_RS300) ||
>              (rinfo->family =3D=3D CHIP_FAMILY_RC410) ||
>              (rinfo->family =3D=3D CHIP_FAMILY_RS400) ||
>  	    (rinfo->family =3D=3D CHIP_FAMILY_RS480) ) {
> -          u32 tom =3D INREG(NB_TOM);
> -          tmp =3D ((((tom >> 16) - (tom & 0xffff) + 1) << 6) * 1024);
> -
> - 		radeon_fifo_wait(6);
> -          OUTREG(MC_FB_LOCATION, tom);
> -          OUTREG(DISPLAY_BASE_ADDR, (tom & 0xffff) << 16);
> -          OUTREG(CRTC2_DISPLAY_BASE_ADDR, (tom & 0xffff) << 16);
> -          OUTREG(OV0_BASE_ADDR, (tom & 0xffff) << 16);
> -
> -          /* This is supposed to fix the crtc2 noise problem. */
> -          OUTREG(GRPH2_BUFFER_CNTL, INREG(GRPH2_BUFFER_CNTL) & ~0x7f000=
0);
> -
> -          if ((rinfo->family =3D=3D CHIP_FAMILY_RS100) ||
> -              (rinfo->family =3D=3D CHIP_FAMILY_RS200)) {
> -             /* This is to workaround the asic bug for RMX, some versio=
ns
> -                of BIOS doesn't have this register initialized correctl=
y.
> -             */
> -             OUTREGP(CRTC_MORE_CNTL, CRTC_H_CUTOFF_ACTIVE_EN,
> -                     ~CRTC_H_CUTOFF_ACTIVE_EN);
> -          }
> -        } else {
> -          tmp =3D INREG(CNFG_MEMSIZE);
> +		u32 tom =3D INREG(NB_TOM);
> +
> +		tmp =3D ((((tom >> 16) - (tom & 0xffff) + 1) << 6) * 1024);
> +		radeon_fifo_wait(6);
> +		OUTREG(MC_FB_LOCATION, tom);
> +		OUTREG(DISPLAY_BASE_ADDR, (tom & 0xffff) << 16);
> +		OUTREG(CRTC2_DISPLAY_BASE_ADDR, (tom & 0xffff) << 16);
> +		OUTREG(OV0_BASE_ADDR, (tom & 0xffff) << 16);
> +
> +		/* This is supposed to fix the crtc2 noise problem. */
> +		OUTREG(GRPH2_BUFFER_CNTL, INREG(GRPH2_BUFFER_CNTL) & ~0x7f0000);
> +
> +		if ((rinfo->family =3D=3D CHIP_FAMILY_RS100) ||
> +		    (rinfo->family =3D=3D CHIP_FAMILY_RS200)) {
> +			/* This is to workaround the asic bug for RMX, some versions
> +			 * of BIOS doesn't have this register initialized correctly.
> +			 */
> +			OUTREGP(CRTC_MORE_CNTL, CRTC_H_CUTOFF_ACTIVE_EN,
> +				~CRTC_H_CUTOFF_ACTIVE_EN);
> +		}
> +	} else {
> +		tmp =3D INREG(CNFG_MEMSIZE);
>          }
>
>  	/* mem size is bits [28:0], mask off the rest */