Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3c19a63-d9f8-028b-e59a-e428be1ed8be@gmx.de>
Date:   Mon, 22 Aug 2022 22:11:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH -next] video: fbdev: chipsfb: add missing
 pci_disable_device() in chipsfb_pci_init()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-fbdev@vger.kernel.org
Cc:     mpe@ellerman.id.au, christophe.leroy@csgroup.eu,
        benh@kernel.crashing.org
References: <20220819085752.1909541-1-yangyingliang@huawei.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220819085752.1909541-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

applied.
Thanks!
Helge

> ---
>  drivers/video/fbdev/chipsfb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb=
.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, cons=
t struct pci_device_id *ent)
>   err_release_fb:
>  	framebuffer_release(p);
>   err_disable:
> +	pci_disable_device(dp);
>   err_out:
>  	return rc;
>  }