Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <08c5b818-a030-4c97-80f7-52ee42dc1f79@linux.intel.com>
Date:   Mon, 22 Aug 2022 15:41:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface
 driver
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, Borislav Petkov <bp@alien8.de>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kai Huang <kai.huang@intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org
References: <20220728034420.648314-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20220728034420.648314-2-sathyanarayanan.kuppuswamy@linux.intel.com>
 <Yv5KNyX992ddvVtD@zn.tnic> <20abfa00-b70c-f151-9ee4-5668f09f4ace@intel.com>
 <YwP27a6/9Yq8LBM3@zn.tnic> <be080a46-e6c2-995b-9064-a8506c38bef8@intel.com>
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <be080a46-e6c2-995b-9064-a8506c38bef8@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/22/22 2:44 PM, Dave Hansen wrote:
> On 8/22/22 14:36, Borislav Petkov wrote:
>> Which makes my initial suggestion of calling this whole guest
>> functionality a "tdx" driver not such a bad idea... Depends on
>> whether there will be a split at all or it'll continue gaining more
>> functionality.
> 
> Yep, let's get the crystal ball out.
> 
> TDX folks:
> 
> What other ioctl()s are in the pipeline for the guest side?

In addition to the GetReport support currently implemented, we have
following two attestation related IOCTLs in the pipeline.

1. GetQuote     - Adds support to get signed Quote for the given TDREPORT. This
                  is currently in the review process.
2. VerifyReport - Verifies whether given Reportdata is generated in
                  the current platform. It is only enabled in v1.5 TDX
                  Module specification.

In addition to above, I think there is a possibility to add IOCTL to get
storage keys from the ACPI SVKL table. Storage Volume Key Table (SVKL) is
used by the VBIOS to share keys required to access encrypted drives. Although
we don't have a clear requirement, I suspect that we might add IOCTL for it.

Kirill/Isaku/Kai, If I missed any other IOCTL requirements, please add it.
              
> 
> What ioctl()s are in the pipeline for the host side?  Are they all part
> of /dev/kvm, or are there any TDX-specific "drivers" for the host?
> 
> We want to avoid both:
> 
>  1. A driver called /dev/tdx (or "tdx-guest) which is only and will only
>     ever do TDX guest attestation.

>  2. A driver called /dev/tdx-guest-attest which shares a ton of
>     functionality with some future TDX guest feature like
>     /dev/tdx-guest-snazzy-feature-foo.  Then, a new driver every time
>     a new snazzy TDX feature shows up.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer