Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2954950rwa; Mon, 22 Aug 2022 17:47:21 -0700 (PDT) X-Google-Smtp-Source: AA6agR5tgEK03DpTha7PPtYzYjMtC9HAsQJqQMAk3ElvazarxUEGadUao93QjgHs+OQSVus96mqe X-Received: by 2002:a17:90b:4c52:b0:1f6:3a26:9f08 with SMTP id np18-20020a17090b4c5200b001f63a269f08mr876789pjb.206.1661215641082; Mon, 22 Aug 2022 17:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661215641; cv=none; d=google.com; s=arc-20160816; b=g0L4NumfINe4Hw4TXTl/fiI+5+GER0wWPDgOoHIIrsiccEW+WgRc2hFc7yKfy1OWzA PsPrS6nsA/xnGWh2rJtxLydynzhdOfXOI8wEjUbiBpqwo2cvNN/ChoKgJwYtOEDQDkvU 72qyQsymdYRy4uvpLOFoJrw4e7eAnrSwVg8CIoGbc73xpqBkksS3aG0gyHR1eNkkWf3T cXvkbKR9EhTK7rK938+kChRSIvmdVmhmDUkFOy1g0hu08YnpTjrDRMvHKzXHLizPmEhg 8KCPC9dUWRHNIf4EG2c1PmcHlVr24EXWkSgGqwcscUzzWvHsifwYzvUBi4cxdrBT+ADu QWIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4mQ/RRCqqB3WaViCzYaKNd+wMf81VYa0XotOILtQtk8=; b=F13diSNypVx+HsqIgygKEYwPo4sM0LNEMVzASP7rbwQhAmFGjILiDKnhV+Zh9qlaY6 D5cpBH+ud8ixdyQgTtyLoEeCGAMxU2ad4g4P2pcFC03cuE9RseIdP+7DsfeXIsVIOdsw jrRrYAejxcAhb+4KhP0yUI9H99j3zwB7AiIKfaZRvQxM/ncygyuWpyv7QRMaBPnBQ7Bx 7Y+vHB81dok8Jraehcq1tXAK/stZWLMuxDmoNGeugWj2Rmcy2qo3S6sVczGMkq6i9kpc JV2vZFy6gFh8AWuj+loeZU7xePYHns6DfJrt+7qZCMeRopenNqHk9qrK7YuO6diX5rF/ yvwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=vRwnTZRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e70-20020a636949000000b0042ae0167204si1503346pgc.523.2022.08.22.17.47.10; Mon, 22 Aug 2022 17:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=vRwnTZRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233446AbiHWAI1 (ORCPT + 99 others); Mon, 22 Aug 2022 20:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238677AbiHWAIZ (ORCPT ); Mon, 22 Aug 2022 20:08:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C4EAE44; Mon, 22 Aug 2022 17:08:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58D6FB81992; Tue, 23 Aug 2022 00:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36841C433D6; Tue, 23 Aug 2022 00:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661213301; bh=ql3WhYwvtGyV0nnW4S8Tm+rGjMLwd8ee87bzIsZn2ms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vRwnTZRxoiSrk0tZjUMMz0NWpy3KJjQW1Gzwl4s5BxfTEsZyNaPKh3ddH+egMSRAD 2sR4hnNN+xm0NXU8iGalWA3ooH8VIUWkt4psle8L7uIrU6rbO7bDLYXnhrZRLNscHk bIFHQN8LlfFrHCUIGNFAHen8hRb613xJNDRLoVjU= Date: Mon, 22 Aug 2022 17:08:19 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Subject: Re: [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. Message-Id: <20220822170819.60d888a5d3e23f40fd1b2e16@linux-foundation.org> In-Reply-To: References: <20220628220938.3657876-1-yosryahmed@google.com> <20220628220938.3657876-2-yosryahmed@google.com> <20220817102408.7b048f198a736f053ced2862@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2022 17:04:57 -0700 Yosry Ahmed wrote: > > SecondaryPageTables is too long (unfortunately), it messes up the > > formatting in node_read_meminfo() and meminfo_proc_show(). I would > > prefer "secondary" as well, but I don't know if breaking the format in > > this way is okay. > > Any thoughts here Andrew? Change to SecondaryPageTables anyway? Change > all to use "sec" instead of "secondary"? Leave as-is? Leave as-is, I guess.