Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220805121250.10347-1-johan+linaro@kernel.org>
References: <20220805121250.10347-1-johan+linaro@kernel.org>
Subject: Re: [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Johan Hovold <johan+linaro@kernel.org>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Johan Hovold <johan+linaro@kernel.org>
Date:   Mon, 22 Aug 2022 19:15:25 -0700
User-Agent: alot/0.10
Message-Id: <20220823021528.7291FC433D6@smtp.kernel.org>
Precedence: bulk

Quoting Johan Hovold (2022-08-05 05:12:48)
> The Qualcomm PCIe driver currently does not implement suspend at all so
> we need to mark the GDSCs as always-on to prevent genpd from disabling
> them.
>=20
> Similarly, the Qualcomm dwc3 USB suspend implementation is also
> incomplete and the controller doesn't currently survive a suspend cycle
> unless the GDSC is kept on. Note that this has nothing to with whether
> wakeup is enabled or not (cf. [1]).
>=20
> With these two workarounds, we have somewhat functional suspend on the
> SC8280XP reference design and Lenovo Thinkpad X13s until the missing
> driver support is in place (even USB remote wakeup works with [2]
> applied).

Are these urgently needed for this release or does suspend not really
work yet on sc8280xp? I'm trying to understand if we need to apply
these to the fixes tree (in which case why isn't there a Fixes tag
targetting whatever commit broke suspend) or if they can wait for the
next release and come through clk-next.