Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3029879rwa; Mon, 22 Aug 2022 19:40:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR7EZLYMWJT7pXXzBH0nOABP73X3ND3Y3C+gwj7HobLSnBd19gRPJ9EWr0AbFbVj5/2qNnGQ X-Received: by 2002:a17:90b:4d12:b0:1f5:5af8:c093 with SMTP id mw18-20020a17090b4d1200b001f55af8c093mr1226808pjb.33.1661222447881; Mon, 22 Aug 2022 19:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661222447; cv=none; d=google.com; s=arc-20160816; b=xJpuP6H0hJlXa5nadOLmoNtMTOqOSRX3CP88sPyo2fIWt7lrwDvUNxoYWlPGkeOeq/ VIRXuXc8zh70lH8XZNMWTo7HMo1SR5wZs21fe2FWdNx3YScgVNKc5Urz0uN9cOzBlX/k nc3YYZ2NKTZEarGLiJ7yzaQQh40BaiYFC3/qITQo1dbHs9BbZ6kreZ1tYR21wiwCpDAq Uc5CiJwfSgkDo4xTJsXZUwtTMxTg+IdRs83NVRXZ9l4rad8ULrCCaM3LZZxK0g1tB9RG Qs9tfo8bp6GNx+kQG5HZR7glg5PsrtRcrp8n/u6KVAJF+O/TLkgO2UABGvn6nNrsWXqm WVDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=pfXMxMnVFDAtpIxjbyYv3GCQSGQCRWtAD9VmgmA+ic8=; b=jnDiE4DjdsWygtuG2shvlRNondrTEB+11Wzdcxf+zej9/Vb+S1taBFXKtXwdSf0PYu HmrYF7J0RQDk8Xcgw5KujZWm0tK33Hxm+Z+8HiPQ/wtDpU0WUAa7/bJCq79DPOqAR50a +EOmB7V9vItE35m9pEfyCjzWQ5aU7tA9Y3V8K9PAhLr5tUvzz5LmhZVDJbcunRyDdRDu pKG45TxvInIxOzHybAP5b3Du9WgPxg8FpDU4Qce107d7E8xfAAjUFD3tzsIrzcRt9nxf xC1C1USwmb+tiw/2ixvzd/ymz7chGxs6NZfHgD3Sp2nbBz/DRoCrm9FgJjY1P2wAMFxO QfPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hMv7GoHU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a17090ad58500b001f5438a7ac5si15472668pju.102.2022.08.22.19.40.37; Mon, 22 Aug 2022 19:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hMv7GoHU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238853AbiHWCRi (ORCPT + 99 others); Mon, 22 Aug 2022 22:17:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiHWCRf (ORCPT ); Mon, 22 Aug 2022 22:17:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D35855142F; Mon, 22 Aug 2022 19:17:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F7CCB81979; Tue, 23 Aug 2022 02:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34D04C433D6; Tue, 23 Aug 2022 02:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661221052; bh=pfXMxMnVFDAtpIxjbyYv3GCQSGQCRWtAD9VmgmA+ic8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hMv7GoHUyTXn5fhPoFtX17RfzX2PHj5HRzXBDfMBLXEA/yFvQc1/EBPZj2u3ykG0C Uzj2sdbOulMQphAlPE26I04U8UHD81w4hMxCD8qYpW7wMOnArm9MdUExnwFjphmLUU VS1yCcXdlm3fPx5dAARfcKPKCJWZmDoJz4J7Gpcn6oe8C5F3Jq8LwW4cxN9rpxV4C8 K/Nj1HxEufE+EHubASXnJsxwUBFyVsTrUT/FHMZLeDSz5QEWZhr8WNTTJ6xkErwbey Y3fgT0aAd0q8Xu2xiGYzYHhwds/AScX2+bVtIqvG3QZ0P+4zb9HxlBYaPODkdMtFqf w5KkIfXIqF5Wg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220625083643.4012-1-stefan.wahren@i2se.com> References: <20220625083643.4012-1-stefan.wahren@i2se.com> Subject: Re: [PATCH] clk: bcm: rpi: Fix error handling of raspberrypi_fw_get_rate From: Stephen Boyd Cc: bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Wahren To: Florian Fainelli , Michael Turquette , Stefan Wahren Date: Mon, 22 Aug 2022 19:17:29 -0700 User-Agent: alot/0.10 Message-Id: <20220823021732.34D04C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stefan Wahren (2022-06-25 01:36:43) > The function raspberrypi_fw_get_rate (e.g. used for the recalc_rate > hook) can fail to get the clock rate from the firmware. In this case > we cannot return a signed error value, which would be casted to > unsigned long. Fix this by returning 0 instead. >=20 > Signed-off-by: Stefan Wahren > --- Applied to clk-fixes