Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3107330rwa; Mon, 22 Aug 2022 21:46:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR7DwK2EbpZmX1gAT5OARZEnQivdDGtbeYH6kjY7biWXRiSTQujR3tlhIv2Nj2KQRubn/DDK X-Received: by 2002:a17:907:2ce7:b0:73d:9028:8038 with SMTP id hz7-20020a1709072ce700b0073d90288038mr2951007ejc.273.1661229979110; Mon, 22 Aug 2022 21:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661229979; cv=none; d=google.com; s=arc-20160816; b=yF+k47cF/KUO9ptVO5I2qkPehScOWYYJLPFUxZOezhOKKeAa0I8ZRNlPeU/xWWY+pA DNTWuDjFK/Gz8KGu9mO4yCH9l6zur9a/qlW4pbRNHKEajp/Hi3wFCcmci1UTB8nO2XTh UxRBEuTjTOO7sI9oK0Rg/Wyy7/Z8W51fzPIaVUdqcs9TacVC0l9rExSmxR9RHOZsZcFK cc9XzGlsStfGjOd6WXR9Njeb/c1QQKehtq8wHzDS50b7TtR6gO2jW9OTHsx7vNYlZD2A iR73moFw88fv258pnG7mfkfJe0ktSLkaRsqfHbSKuI+/ntTMJizg54T8yr1ZtQMlxqRC 2eJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LlU3cL8PwMe3vKa0WN5vXQjGFYgXr5Ht0rjCIUUTino=; b=ntnZm4924RqTYvwKZQUJCGzlt9c7lkTNugmIicshtiDYUHSlbUWCs+/xsXlttMWVfQ eaBZHDJ0TBLvNjGZtO56Jy1DT3Hl+KMg+Ukg9GjBqHXue6c4pROBJ9dEz9QbMvfPpzg9 cQ6YE0mNaByKQgCAp6HZMf6ZOGaEwAUUGp+/xZv8CRKwkhFPQ1e2u+m8KG9L3rnHaJv1 7m/HHsMMuzhn76J15hLYD3KGDyeX7R4JSrcTOFgiqYn01aJsGSD1caEGFO6vZ0eJq/aP /NgqsndOUTMzsVElsC6SaTk66WNBwQ/EKtr1D7TlHRT2WvEpCr+qVRbrKloRkPwTLcxN 7g5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gUPx646f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a508d0b000000b00445b1de8270si1187963eds.608.2022.08.22.21.45.53; Mon, 22 Aug 2022 21:46:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gUPx646f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232456AbiHWEnc (ORCPT + 99 others); Tue, 23 Aug 2022 00:43:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbiHWEna (ORCPT ); Tue, 23 Aug 2022 00:43:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68DFEBF63 for ; Mon, 22 Aug 2022 21:43:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41FAA6137C for ; Tue, 23 Aug 2022 04:43:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E6EEC433C1; Tue, 23 Aug 2022 04:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661229805; bh=3+SproVuBpT94Tg43qdo0lGL5IzYEYPl3JCQvNfCEX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gUPx646fuYLdAorPg02kqV3EQDvJw0i5UvMeZn9pxVU5mtOQqbG9sDnVWtAvd+iJM Ec433lF8zvN36zPtjvhB5Zhj2JUFmqIT0+9PFOZAlZeU4MBBhCkNJkkospaRmbqEB0 lyEjOw2Ojo2RoksRqt3El8aihPIGsuFdCoBh7JTuIMIrUKsk8O6l5KfevnSyipwK4V xaFV7lkyKCXtUHtwAWTxqE1tIUmbRx7cINidiL7VRn5gX7ta2Q81OXqgoHRDNT8KxA X7ByqtH/HHhk30hL7onfFB6Go+kjIWOGL7Kr6XVELifaBPDacOac+5vP9MCx0UmGe4 TtZf+IJIi5wuw== Date: Tue, 23 Aug 2022 04:43:22 +0000 From: Tzung-Bi Shih To: Prashant Malani Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, bleung@chromium.org, Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: Re: [PATCH 1/4] platform/chrome: cros_ec_typec: Add bit offset for DP VDO Message-ID: References: <20220819190807.1275937-1-pmalani@chromium.org> <20220819190807.1275937-2-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220819190807.1275937-2-pmalani@chromium.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 07:08:02PM +0000, Prashant Malani wrote: > Use the right macro while constructing the DP_PORT_VDO to ensure the Pin > Assignment offsets are correct. > > Fixes: 1ff5d97f070c ("platform/chrome: cros_ec_typec: Register port altmodes") > Signed-off-by: Prashant Malani I have no idea but use your judgment: Reviewed-by: Tzung-Bi Shih