Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3170497rwa; Mon, 22 Aug 2022 23:19:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR7mmmDtu4DkBcUFN/o9nM37SFISZtJmzQphenHjGvTAxTBVcqrRPPtk/1ZWzrphmfhVUosd X-Received: by 2002:a05:6a00:114c:b0:528:2c7a:6302 with SMTP id b12-20020a056a00114c00b005282c7a6302mr23958398pfm.37.1661235585881; Mon, 22 Aug 2022 23:19:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661235585; cv=none; d=google.com; s=arc-20160816; b=IFO/1zF21wJXpzTi/+4B210xl5pszYQ/AFII28EI3ub9AtVDzAwAVBj8AjPcOM6Zdk eRGGHQ0lhke8RZ+eb9Ya6/FCd25hpdEQCmLJsFhkvjnSZjPxiqX4kZO10PmIJn8OG2W0 H0EyBnVkWyKtUMzw4aPLZ/ZpsVzLEfTGH8tNRKcZqqsOZz1DRwvvo9yfk9CCOyCvG0Um lUfkVEackHsUlM8GBzpGhLGtGSnL5E6VwCEXFUr9o4ISchK+edlbliKPE51xRToDNF5x 3E1PNXFJKuUS2CT2swHR55VFZZjkaMVtn9dMhLXq2FsreS9DA8N4mCMo7qDypKjVD0ak jpSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lE4zJKGK5ufDTdByQbany0NxSjQhvKLLUTqV6VW29nI=; b=0+tNfKqqb2/fvXZOjTJwwVsuLv+hgTvafguYDz6H6XxQvMxvt82uBq60gw9PMtPaEA vL/TX1ullXcw1WMHO/+a4Ot8lW2GYOx0+1zlqxem7Qi9PTmc+2uJvhlMgzISuhqZkN+4 2zaolZnsrLtjUw/0le9M3pKVFogJRUyRGmPSDaQ4LQAVwXvLQLMLgnE9Ce/mNYy9zzoh Ee7UAIDr/adgxmpnvx6PmajF7uxtV8vehCd5gCaFupA37+jSsrc5Vw4R9O8JVXOMxR5k Ho8c/s6ZjRD3xpM5lSaN/b0Ix0CLMhiZO93mPP5kg6dFIyBQOcGEYLTZuyRBzDEeYx7e q6Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cenQlbBw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a170902c94a00b0016cd74e550fsi17211077pla.351.2022.08.22.23.19.34; Mon, 22 Aug 2022 23:19:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cenQlbBw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240332AbiHWFzH (ORCPT + 99 others); Tue, 23 Aug 2022 01:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239864AbiHWFzF (ORCPT ); Tue, 23 Aug 2022 01:55:05 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C64D75072D; Mon, 22 Aug 2022 22:55:04 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id r69so11389107pgr.2; Mon, 22 Aug 2022 22:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=lE4zJKGK5ufDTdByQbany0NxSjQhvKLLUTqV6VW29nI=; b=cenQlbBwYrY/Bcb7h/cEeGbJUnpnDCu1SbkqjuhF+S+0s8AlQoUKudxKXaKMxJTNBK 0o3C6sd+8/fiQAQDOkAiYjte5nZGjp0a+wE/+/GuGI60KQFjvuHvcciQQdQKmvQFJnBM sa4K9sf2MHOg0Oi7WtOkaZMXTMVMTzRRbhZBFMkszMoWh7zoQUN9mXmo33XN71f0I1Qw srfAtqyii0OgXHcZOirjlANsoqfAvqlIiw7sBeUXmt9VENsSR37FjyyFZyQTcRmGZNwI Na9Ob2+/fpFBzdZGVxrv6848dVTZCj7tBbg4cj5RDpbdOJB76plgaC5vtdk/LzVgVesm eHaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=lE4zJKGK5ufDTdByQbany0NxSjQhvKLLUTqV6VW29nI=; b=SycnuLTatJ3GAYrsi3loQaWXZBHKdiO5Q7JF47EPS/RcvldMM5MWHPRbEE1alR2EYi dIPhh15QzowrbeCqgmjf5n9be6z9LSfYUlERUB3UZ33LKqgAKblFuypI90ICt17KcVI1 z7GWzZMUcfBQ6u+daUCX9WqPjLXd9h2QCxNSfo6rbBGIbUh9HS3qVGoZrWUO1obdbaBs 9pRW6wNrW1qaHJTlM8fb7LlnLtKBtFWABmyBMLP1Mfj6PYotVmmkWH/EjwcVwdd98KFZ 2kajD02zef9ye5Jh1SZD6baH5lNkSPVVSlEuuY9yARUpp+ZNB3ksvFa9KSDs2WYUK4Iv R52A== X-Gm-Message-State: ACgBeo1p5RM4LnzkYz0ViUCRO44Zd8Lz21MEfmLTNkMX+H+2H+h0xl1c K0t+nkKx8H2C1MgK2KDmuGBABiwQrNY= X-Received: by 2002:a62:1c56:0:b0:536:4f4b:d99e with SMTP id c83-20020a621c56000000b005364f4bd99emr13850296pfc.64.1661234103876; Mon, 22 Aug 2022 22:55:03 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id s8-20020a63f048000000b004297b8cd589sm8320109pgj.21.2022.08.22.22.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 22:55:03 -0700 (PDT) From: lily To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: viro@zeniv.linux.org.uk, Li Zhong Subject: [PATCH v1] fs/coredump: check return value of dump_emit() Date: Mon, 22 Aug 2022 22:54:37 -0700 Message-Id: <20220823055437.1450407-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check dump_emit() return value to see whether it fails Signed-off-by: Li Zhong --- fs/coredump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/coredump.c b/fs/coredump.c index 9f4aae202109..4f51bdcecc5e 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -762,7 +762,8 @@ void do_coredump(const kernel_siginfo_t *siginfo) */ if (cprm.to_skip) { cprm.to_skip--; - dump_emit(&cprm, "", 1); + if (!dump_emit(&cprm, "", 1)) + goto close_fail; } file_end_write(cprm.file); free_vma_snapshot(&cprm); -- 2.25.1