Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3175038rwa; Mon, 22 Aug 2022 23:26:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7tkZyowPk3mBJ/9z6Q3tulo0qifV0gXkWI1J+XikEfAbX7szpCGQnRJq01p1RJTIECs+No X-Received: by 2002:a17:907:3da2:b0:731:55b2:1c20 with SMTP id he34-20020a1709073da200b0073155b21c20mr14949999ejc.742.1661236015707; Mon, 22 Aug 2022 23:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661236015; cv=none; d=google.com; s=arc-20160816; b=VBR4mD5OIkctombKCozWU7DLTladd3F5c+fp1lN2GhnmNVcrzMhU7P+bV0AV+bWFgE YocVLwnCBDCu7NCJAFNCivjKNQYhUaaKzMUQC3pJNH6Jf7/RT06er4iVZvcIz3cRf7Qz fy7wddDRs+JY9Dx9zbNH2IRbMqrtdd6hxT8nRg2TH/XqLCHjni/K+E9ObllKsw6kwTpP BoG1/N7q29xXcU3pH2fzAo93MIAC8AkqSZwZqvFjFyf6oyUnbSQFOyV/WQ2bm8PNxU7/ wAVIoaZwg9c6s7cHb7Y48BZ/uzKJtWSZ11OoD4GrEutdnoCkk0LCmEtEXEk3kWK4fZNJ n2zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8POHbkQG+M/Sj7nimjAbQ97dHy6N9tzutHO9tUrF1bA=; b=Tb/dliJ+7rihVmz1v9AkvA2ZH3meUKYRz8yjlB6nJpwHuztQQSgSDk6SvoGPmpS42M JyE9LKWUDEV77Fm02MZux8yAPSK+15+tNRtNWVC5Rwz2DnmvDqEXyjCagYlMOFQ0b4Q+ nEOnZ40I+4lVxB7YxG/2OT5ymOY0gevwG5ICv9S7bT0EOIfKxAKsDYdHP5/E4mB2XsGe fseM1HkEVIR8IQXs131gTPO3A4e19r1mP70bIV3mU3CgyS7gPoGCMK3DEWNjUE04iwWm VAfjbcaj5PfmiBvOXnmzEtsEAR7YNJz5jP5A0UfBIH2XFtTfdQWC2oF41Yn0WHqvm7kn sUqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J2weGI5t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw8-20020a170907a0c800b0073cc9ee8b75si9016795ejc.27.2022.08.22.23.26.30; Mon, 22 Aug 2022 23:26:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J2weGI5t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240348AbiHWGWL (ORCPT + 99 others); Tue, 23 Aug 2022 02:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235968AbiHWGWJ (ORCPT ); Tue, 23 Aug 2022 02:22:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 225704B0DE; Mon, 22 Aug 2022 23:22:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D801AB816BF; Tue, 23 Aug 2022 06:22:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F17BC433C1; Tue, 23 Aug 2022 06:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661235726; bh=aGhwHLFCPyXlbGMjDTQLolc0eTz1F05VuSaLLqTjayg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J2weGI5tHBAlVRTBCsIZlHSXtkLBb+UPjKkvzn1y7nzwyd2yGxDW5BeiGdjGNqKkM fD8c/wJlSGQJeDlyJXmLZeN1SeJ59HbPWhydRw3O19Afii1mauhFMXjSOGb8bB25u7 ipPggOwCfkgU2U9MZizd5jnfYCGhdFLkMuSBS46c= Date: Tue, 23 Aug 2022 08:22:03 +0200 From: Greg KH To: lily Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org Subject: Re: [PATCH v1] drivers/tty/serial: check the return value of uart_port_check() Message-ID: References: <20220823055739.1451419-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823055739.1451419-1-floridsleeves@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2022 at 10:57:39PM -0700, lily wrote: > uart_port_check() can return NULL pointer. Check its return value > before dereference it. Also, how did you find this issue? > > Signed-off-by: Li Zhong Also, your From: name does not match this one, so I can't take the patch even if it is ok :( Please do initial kernel work in drivers/staging/ to get issues like this fixed up before moving to other portions of the kernel so that basic email problems do not bother other subsystem maintainers. thanks, greg k-h