Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bernard Zhao <bernard@vivo.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Eric Yang <Eric.Yang2@amd.com>,
        Michael Strauss <michael.strauss@amd.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>, Melissa Wen <mwen@igalia.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     zhaojunkui2008@126.com, Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drm/amd: fix potential memory leak
Date:   Mon, 22 Aug 2022 23:35:24 -0700
Message-Id: <20220823063546.11499-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ECkGCgwNMvetFLaAxHm9ZHMLAFavJENmWq/f9hWTRCcUAii6fk6t6A+kypVm?=
 =?us-ascii?Q?/MsU1uTBr2CPIjb1KTBdfT3AiLPqPPuAg2O0w+HAbduuJew8KgRDucYa1Rgr?=
 =?us-ascii?Q?QgAq48sbd5hlzDskr4v/5PEoIh3jthjvoq4ijWS0G7L2udz/r/tG0I6GlUX0?=
 =?us-ascii?Q?cghWChlizflekW3LejfHFKmYfMefFvvtuZaTsYtDXXy+7tpVGfvaF1lDcu3k?=
 =?us-ascii?Q?xSk5hdZ3+VSvS9JweJXrf3MbCMcNDsx52XXr0YGgcEJLABl1Qjf2vI77BjCR?=
 =?us-ascii?Q?gs/9G5nD19sEcIYTmx88TtPkVmkVnujcr/w75dvfgmPsrdyKpaISur3hmT5R?=
 =?us-ascii?Q?guUYIgsfdbqSvD0zP+DKyi9Z/c0zDyJpT2u9xwZlQhr0hQvCdeoBhx/gHzas?=
 =?us-ascii?Q?1RGViZRwbenSqiuxw873OooolYOXYAy0lMY/WkL2EyYBRFCvN0Pkj6OgA/lX?=
 =?us-ascii?Q?1PWEqqZJJriUlfMNvo5keoqkEVDYCUlydr9vqn5jvqlhKiAzl7tV7LiG0vdO?=
 =?us-ascii?Q?NPNi3auvPze8tze+40Eni3POc6APZLApFHzlYQ/DlP9kRHPwpHJM6xBowhJO?=
 =?us-ascii?Q?EXGUJgDE3mcHtchyxyeTn+F1diTCNKi2UY/UYvXf/0RsKS+pzVCdZmdeyMHs?=
 =?us-ascii?Q?t0CdD5srVByDkvT+8gpvfcWPQ6J/Ffd+Ht9Iqlp4hOehrjHfS89eLbblnE+C?=
 =?us-ascii?Q?FPj6GnigUWbTnFeijsN1+2ScRn0k32Up+QIE7y4MCKZxdF/DqdZdhRUV7WTR?=
 =?us-ascii?Q?ZlhF3au3LpR9fDdwK94Iwrv5kiQ4TbKvAemyyYw1DmpSS7X622pxF4XjeWOm?=
 =?us-ascii?Q?gGApP2HHOLdu1I5YK6qi+wx4s5WXVqvyXTLgA9oqZ07rFDjqi7qDteSx+UX/?=
 =?us-ascii?Q?Yl+l1bpG3TfJ+UFHsEl+bk0QP20abrP1rFci2JB0KDFe69nOO3zuNRKoj9TR?=
 =?us-ascii?Q?MO7Tpdy59Y5DdXw37WOkzUKDn1k/TleM/jDaMdcvmm2Tu6K1cWhWojUPo1+F?=
 =?us-ascii?Q?ZxaFrcLCZ7E5GsL25emkx8S7R3NJ7NE7UXY66+fK2gTHpD9QSUXubtBPWqrL?=
 =?us-ascii?Q?kYI8fBv1nDvGLkz064F6Iiw1gHNXMXB9d19PKHHryxNWSuj8uO4iBcpIGChm?=
 =?us-ascii?Q?KPIHbwbspVz6SxyXbo9aEFfpx6/IWIXX5E8KydTGsMEVhA5QLaqGg+l/zPgr?=
 =?us-ascii?Q?T7zbMr3UYgyVPlvwjuy7tErA10DbAgZNGZts2nOwHhKyV2k7mTGIHxV8c6tC?=
 =?us-ascii?Q?fcYS4P2AgIPighUfRcQ3nV6ANutc7ai8wUv0CXZ2AGnvqQB5OazgxJotJ9xR?=
 =?us-ascii?Q?WqAA6Z2Cq3LQJfjHn+SdO45KoYmqqoMwRVrR/wxDWNOv9HL2wl/5MWrCKjye?=
 =?us-ascii?Q?mK0Q/0E8tBwNCpv2BGZRwRAeB2DuirjmI3HSWpGTvL7cQl8l8aKJJUoNZ5+I?=
 =?us-ascii?Q?M5rEK1RZrBPxw2URjXdvTmvp5mg7UiVYhpjybHTvJSgIp+yJXRc3GOMLS/7/?=
 =?us-ascii?Q?m6tB3CMH5X+BnT2y0gSLTmmnVGkTGcYZ4UHql1/pSnBzcz6Jr45C6di6rrYH?=
 =?us-ascii?Q?T3hN7MYG1Qo2NDMh5b8SqLTXn83Av9kfhWD75i4S?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ecdd4f-083e-4df1-650f-08da84d1be89
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 06:36:00.8619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3MQvWH+2lviSWfbYCwOa1+Qr8vlBLrN04eZiniW5ylXAd2hxJHED6nsscMSLfMP9pTo/7XdsQEXYoHMckkn0yQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5027
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch fix potential memory leak (clk_src) when function run
into last return NULL.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..c7bb76a2a8c2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	kfree(clk_src);
 	return NULL;
 }
 
-- 
2.33.1