Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bernard Zhao <bernard@vivo.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Eric Yang <Eric.Yang2@amd.com>,
        Michael Strauss <michael.strauss@amd.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>, Melissa Wen <mwen@igalia.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     zhaojunkui2008@126.com, Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drm/amd: fix potential memory leak
Date:   Mon, 22 Aug 2022 23:49:56 -0700
Message-Id: <20220823065001.16872-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xtpYPKqDF5St+bbx0Z7y60WFycyVJOdRuDprDf4rt/wDY+FFmsI/LGBGggJV?=
 =?us-ascii?Q?XEjmfs1pyNlN3Pc8GEU/WIhmEkAYZP/COo4F3WIFgVUrmt+adMOH0JatSs2z?=
 =?us-ascii?Q?NmfuLMtL1hyDRZwyW2hkdlAztnRXMWZosmvKuzelGsbmlSjkJCmuPoP9y/rn?=
 =?us-ascii?Q?PvGcHrOE7Y0v61X5ipRtG8iEoC/UtplZercpNBwa3qNQ7fdb9LewtmMH14Yn?=
 =?us-ascii?Q?Bp67oD9dz/pE3ajg4i6JBAfJDyPTRXiJtnqPHPj7uUvxkFc4DP7AeMrgl0CD?=
 =?us-ascii?Q?nyEMej7HUiA1yiqtxV+5Tu6c1qO8sRxxYVWcNMxKYg6XiooZ6tnjEcCxH1Jh?=
 =?us-ascii?Q?EInzZ5Qjx+Az2yEkRT2hYgQUETMo9pdZzzxxRwgFDek/k9ZN5QpHmspnXxMh?=
 =?us-ascii?Q?1tHOfA4Nk2oJYvHDh+8F7i9AUWPRM2mTNiSCF7/A9s8+7ulyKifFilJF0BB3?=
 =?us-ascii?Q?i6TGlhCfIgnxfj9F/rGsiB9BmfgutS8NSyLutCyYnq5UWAtLUg0dRHOfD7oA?=
 =?us-ascii?Q?BNWrVkjkw6wKBPfbw232l1OKSd466aD3N92HaEsN4HAbxBVWxA43VZHm3fMT?=
 =?us-ascii?Q?Mipzc+YM7nhXNPZOFFCiHnavHqMKGgNxONZyt/UQzDnhlKyc7XHdtQxej08w?=
 =?us-ascii?Q?GNjFjvO5HjnyoS452cxj92ZYZ9b5E8qJSqIVUEdp4XVaiA2JvGRdfTABL+rF?=
 =?us-ascii?Q?NlE5+QyyAt6b7vwValfaHh/eXSmEPQAq4JIhVxqD3xyybkWCUPAyw6RTu/a3?=
 =?us-ascii?Q?nMZ7eUAipYmwdp8QSR8GXrSSJ55XysYIeC+Jqz1cQqjZ1zCjcjn2yqLoEAJN?=
 =?us-ascii?Q?mH+r6G13LZ/eSoISYoKsLw8mG2pC6g04C6yJZNbpcu8ZX66nDPgHwmx+H7wS?=
 =?us-ascii?Q?3bzC36Vo2CZ2knVeJ98hOFzi/rofyErBbnvMrRV0SYMr2s9qJySzeXc7DOvm?=
 =?us-ascii?Q?bo2XakkS2ojgH5Oz44uEB0TQX0mFDKTNvmFuj9edwcKG7bRP/hFRIXTm1FcK?=
 =?us-ascii?Q?QFIBkjn5pAJTeeXozynfqhKPtsHIFBqgmokxpCkS/Mk91dNqjCtmmgTH2dAP?=
 =?us-ascii?Q?FGFHfNRiXbs77lRFjl7IU+55+vqr7bdERiQGrju0b+p7zRSLdGbZ2zS0Dteu?=
 =?us-ascii?Q?YOYzzRmoSoXZ7t3elFsb89MSHNK8kG6p0mzYqstow23lWDpZkCD9yJ/ex54j?=
 =?us-ascii?Q?q6v+E+GLCc5mfOFZCT1EXqFlBPMzdn0S2FZCLRVlpHSLMfkeG5zANZ7kc5jt?=
 =?us-ascii?Q?Lh+D13gt6xuwtMFQqg3icDwuYseEpeUrBRcrKVgYRBV0oitQdrnKVchTUnvb?=
 =?us-ascii?Q?Ten64N0CVhCnOTrO2Hok8iGXD+bMSTCkQKWvDrYZqs1urjBGlFR7LxkbsoJP?=
 =?us-ascii?Q?l5VYIBmwtLmlEcTBrUd/tY3IIiq3aymzgELH1/1c2R82wphmkRp1DU69grF7?=
 =?us-ascii?Q?cdkls1egBcbh3Xa8XMzLYUIaYxAuu5g3SRB2spR9/z97K5bR8lLCF4AMQzpn?=
 =?us-ascii?Q?mPtgMakz52isR5IHDzIjp2JK2twOJklzJQblZ0iGlwP3rQdMpIusTiMvZA4p?=
 =?us-ascii?Q?iAZ2u3DvVMC+J+l/4svLAvxuRFD4NuAgBO3EwsGk?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0284e37d-a9f4-4aef-c2de-08da84d3bf16
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 06:50:20.6970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qbD12c8tRZxlAxD8jtRsfKKPwO0xI7DV6OIglPA8JGISdvfu0i9SZ3h7ItlHgHInvmUM2Mi+/UnS5m8bK0Fn3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4269
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch fix potential memory leak (clk_src) when function run
into last return NULL.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..76f263846c6b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	free(clk_src);
 	return NULL;
 }
 
-- 
2.33.1