Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy
References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
Date:   Tue, 23 Aug 2022 09:09:33 +0200
In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> (Wolfram
        Sang's message of "Thu, 18 Aug 2022 23:00:34 +0200")
Message-ID: <m34jy38mhe.fsf@t19.piap.pl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEhlTVFhK2hWWmFoRzlFb05QRjRzUXVCTTgzT25WYWdQZEg2ZDZuK2hOazd0?=
 =?utf-8?B?TUVMMVJ2YkMwR3lQSk53MkNWMDhpZHZjQ1dCRFllOGxKbDJWdnJtWjA0ejlI?=
 =?utf-8?B?Wm5xZkFpMGs0T3Q2OW9NREhxcjkyYXRoZEtaamFaano2bE9RL0UzVTEyV3hE?=
 =?utf-8?B?YjVKWEo4dE5GRlJGTWFZN01pZi9sT2ZNbE1nLzNmcFBiTFNxTXJEc3M1NXlI?=
 =?utf-8?B?Q1oxRFh2T3I5QjdOQWExOThvWGZoU2VRcVkxNGlXR295d0Q2K0hOYlpqWm1q?=
 =?utf-8?B?OUlkd0Z5QytsRDExZkdiMy9yVFhGQmZ5bG1KM1FHZVJYRHloc3hNQzR2Y2dm?=
 =?utf-8?B?SWhCY1AvQ3JQZm4xV1pOWHBzY04xUENFcWNWQ0FTcnZ0RGdlQXhNZldNRCt2?=
 =?utf-8?B?ZnBTejRFZnBpd2s5VVZlL0xZWjEvOTVGY1ZJUi9DZFNMcDQ5SE5QaUhlZC9Z?=
 =?utf-8?B?b2c5OWc4TDBiYzR2R1RmMm9QOWdlVUlGUVp2Wmp6UHlKZFZkc1lFVURYdW5v?=
 =?utf-8?B?QXh1TTBPQnZlWmZtV3VsS0x1NDF1b3hqV3NnTmV4UFRSdUlJc2pubGRIRVJU?=
 =?utf-8?B?WWhoZG82RExxSU5PSENSSVV3eXBaMDMyMG96dXEvNjhEYk4rdTBBdStVandL?=
 =?utf-8?B?MEhWeWhObkZXUi9sMlNUcU5uZTRKUTNOdENhalppczQ0YXpuTlR3R3BSYUp1?=
 =?utf-8?B?MTF0MmZMWjdUK2NHMUVmcDlSb2lwQktHR3NtMFFodHc4MWV0bHlrODJKT1Fr?=
 =?utf-8?B?cFJCVC84RDVSMzM2MXJrdDZ2a2xYRkYyNlMyY2Q3RmszQkhaL2E3c253NW5i?=
 =?utf-8?B?aWN6c1d3QkJxSC9uTHhGZVNQcnVPektVSVdSeWtVMVZ1czd3OVI3c1Zza0pi?=
 =?utf-8?B?RHgrdXUvd1BiWFI2U0dFRS90YTN0bFRzQTRNZEFGZ1VSN0xtUS9JQTIrYTBp?=
 =?utf-8?B?T2tSUlNMWHJjOU9SeWh6bTlkenN3UEo5QnJYZUs5dm1SRHp5Smp6ODVCQUJI?=
 =?utf-8?B?MCttNkNtSzVoNDRZejhEbEtOMHJlS29adEhpOERIUzZZQnIwZVM2clMxVU0v?=
 =?utf-8?B?VFFabDhtT0Ztdkp0aGU2U0hHU0h5amZlcml5dXBYcEtFWXBJTm5VR2ZVbkZJ?=
 =?utf-8?B?Z0lxN2pONzE3NDBDV0JhTzBiZEZuSXg2ZkppR0lMOENYS3Q5VUlJMFdrYnFr?=
 =?utf-8?B?WDBrZ0VTZDNsOCt2M2l4d1ZKbWdwRE55ZXdQN2RVZ0RHZ2Rvb2FkZkQ4eGdx?=
 =?utf-8?B?MzZkNy9zWEY0MndBdE5pM0x5SG9mZHlYbXR2UlRaSHQ2aUJEUlE0MkVQUkJ4?=
 =?utf-8?B?S2pXVmdwVTlwcElDQnVLNkdjSGV0bkJTdFNoUFlOSjhBMkhDM1VqWEVPRGQ0?=
 =?utf-8?B?dVgra2JIZWdDT250OXd0QVVkSVN4M2RFTFBMdytFWk1hZmk3RUphQnZRY2Rx?=
 =?utf-8?B?U3E3UnB2ODRiNmF1TjlJYWIzK2NhcEtjZkN4RUR6TWlNVXN4RTdEc1F6NjFs?=
 =?utf-8?B?QkJLU2Fjenl4SGhabGk1MGNXWXB3eDNUZGRLVkQrN1YzSVd4M2dZa3BiUzVV?=
 =?utf-8?B?UUdoMmdaTVNCajRRNG03QmlLNGJveERFdmFlNjZKcm9RaCtNdW84MElEcXBW?=
 =?utf-8?B?VjZEa2luYldCK3BFRURsWXlsSmxDSzFSOFZERDdtZmdpOW11Q0ppYitIdkpo?=
 =?utf-8?B?eDdYcFQrSjJ1cFBiM2xKQ2k1ZENwdGxoN25pRkViUEZKR3BHYUR4YWlLbnBE?=
 =?utf-8?B?L3J3R0RhYkJPb3c3QnRiN3V0VmYzMXBTWnNQR1FJTXNhZlpBVC9xcFc3a0dI?=
 =?utf-8?B?RUdqUmY4UEhmUXc4d0haSjY5OVFNQU51K0p6Q0JJQ0NLRHovS1RYTDhiVUt0?=
 =?utf-8?B?QUNHTVRNWE1MQnZRL25NN0QvV25VQ2VHQmhHZTE0L0h1TkdwU2xCUSs3TCtn?=
 =?utf-8?B?Mmp2RGVqVzduYlI3bHptR3l2N0hhbWdoRWtkUkJwZ1hWamVEYTRBTDBudWZ5?=
 =?utf-8?B?ZCtiZHIveXVRSklxQnEycGFoZHRzWUozcS82L2NOYmd4SlR3eWprSXhSK0tN?=
 =?utf-8?B?eFJjRXdta3hoVUdERVVZc0o0aCs5NGdQdXpXWDJPQ3hoYzQzdlRpMzVOSFcx?=
 =?utf-8?B?bTZlVndsdHIwK045d09xY3d0RkJVMzdKdVVWVnlsVExKMGpCM3F4TG1FRXZG?=
 =?utf-8?Q?E0+OMN/ox+LmKx6lzz6asNf1DcaDr0DbGPFwVX/1gPo7?=
X-OriginatorOrg: piap.pl
X-MS-Exchange-CrossTenant-Network-Message-Id: 59930e7b-ee3a-4950-ce0b-08da84d66f15
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0685.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 07:09:34.9007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3e05b101-c6fe-47e5-82e1-c6a410bb95c0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OEiIMCAW++QoJKjgF9zC2p8lTJMGQVeFGfT7H+NtV1/YSgXFRSe6p5kfykWLtFW3fGpOYMUB7a76YwLzNCuSrWqSXs06N8TX6gBSBlMLxn1vP/QALVdT3l8cuCiD2Eop8HU5s9TTlxH36DdicaQXSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P193MB2021
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Wolfram Sang <wsa+renesas@sang-engineering.com> writes:

> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.

Looks good to me (IXP4xx Ethernet).
Acked-by: Krzysztof Ha=C5=82asa <khalasa@piap.pl>

> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -999,11 +999,11 @@ static void ixp4xx_get_drvinfo(struct net_device *d=
ev,
>  {
>  	struct port *port =3D netdev_priv(dev);
> =20
> -	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
> +	strscpy(info->driver, DRV_NAME, sizeof(info->driver));
>  	snprintf(info->fw_version, sizeof(info->fw_version), "%u:%u:%u:%u",
>  		 port->firmware[0], port->firmware[1],
>  		 port->firmware[2], port->firmware[3]);
> -	strlcpy(info->bus_info, "internal", sizeof(info->bus_info));
> +	strscpy(info->bus_info, "internal", sizeof(info->bus_info));
>  }
> =20

--=20
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa