Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 01:08:31 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Chao Gao <chao.gao@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Kai Huang <kai.huang@intel.com>, Will Deacon <will@kernel.org>
Subject: Re: [RFC PATCH 12/18] KVM: Do processor compatibility check on cpu
 online and resume
Message-ID: <20220823080831.GE2147148@ls.amr.corp.intel.com>
References: <cover.1660974106.git.isaku.yamahata@intel.com>
 <60f9ec74499c673c474e9d909c2f3176bc6711c3.1660974106.git.isaku.yamahata@intel.com>
 <YwSGsbpuJ5cdNmDG@gao-cwp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YwSGsbpuJ5cdNmDG@gao-cwp>
Precedence: bulk

On Tue, Aug 23, 2022 at 03:50:09PM +0800,
Chao Gao <chao.gao@intel.com> wrote:

> >diff --git a/virt/kvm/kvm_arch.c b/virt/kvm/kvm_arch.c
> >index 2ed8de0591c9..20971f43df95 100644
> >--- a/virt/kvm/kvm_arch.c
> >+++ b/virt/kvm/kvm_arch.c
> >@@ -99,9 +99,15 @@ __weak int kvm_arch_del_vm(int usage_count)
> > 
> > __weak int kvm_arch_online_cpu(unsigned int cpu, int usage_count)
> > {
> >-	if (usage_count)
> >-		return __hardware_enable();
> >-	return 0;
> >+	int r;
> >+
> >+	if (!usage_count)
> >+		return 0;
> >+
> >+	r = kvm_arch_check_processor_compat();
> >+	if (r)
> >+		return r;
> 
> I think kvm_arch_check_processor_compat() should be called even when
> usage_count is 0. Otherwise, compatibility checks may be missing on some
> CPUs if no VM is running when those CPUs becomes online.

Oh, right. Compatibility check should be done unconditionally.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>