Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3284637rwa; Tue, 23 Aug 2022 02:00:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR6SZYKu97CRovOHbLrKc1Tqpp5aDcBu8pI0ay4E4EGVXmIKQH7EQmE2rhd4bnW16eD3LYEy X-Received: by 2002:a17:907:6e0c:b0:73d:8b64:5c3 with SMTP id sd12-20020a1709076e0c00b0073d8b6405c3mr4287983ejc.297.1661245218466; Tue, 23 Aug 2022 02:00:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661245218; cv=none; d=google.com; s=arc-20160816; b=hjtKse9DNLr+4+HQ9p/PmfwZ+selF7wGrDmNKH3sXarKD/hWYTo7VksmmJnzl6hii+ 3XBIrToEb85Q7FWgf9T7KcdYtQaK+fjVq4P0qSadLdO1MIZjV/T8U+s7SXmCulWY8F1U WRQmaqdX11Rx8c2fhjFnu7f0pJZmh7RT4t9JUD43OBgsEhFYai/5glZxu5I6smeR3VX4 EFgdXSHuYjFlPg4P0rBn9utF4Pb5PMgXzGMk6bRCg/6bYU4FqVI/J6vvwoo/Fa+sOmCP pvyc5tWoqqWPd5CBCpUlx6P+yFyqM56eM590p045HtBqUQsBm9LFhkx6PjwQkBX697K7 9Drw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GsPCstnd8MSK37ly/fTWkEjW7NMThjKYcYchPzUBSMc=; b=avGx6bD/NP8TXs/dgu/cCDjTmMoLDg/MLtMFzLsGp1RhD1IoBVJjqpTS92W+cU8oxa s0OTgyKZe5od7ZkX6SsaABLlRNuBKNZ0LREYo1qr/uN4rRg6fvAyPQVNlIDKBj9rCld9 nH6WbE9tVfUHyOU9n234POTYfg647qCUYlbMQvSeJ9yl8Oo678e4HqxHWCY5NMGRLGFy u7c0dbI05o30WnQKedt4jgcbK04i63FCL07rKLcplN88DJOIEm2YX86IWu7IcmtE4skf Tx+QoT1I0G6ovVtiPhh8wN6Fg59OPrXfCPHrulEMYpecMbTgJFNALhD2px4hujrCgQa+ 51ig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k18-20020a17090666d200b0072f4b12916fsi9967924ejp.395.2022.08.23.01.59.52; Tue, 23 Aug 2022 02:00:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240039AbiHWIDc (ORCPT + 99 others); Tue, 23 Aug 2022 04:03:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241509AbiHWICy (ORCPT ); Tue, 23 Aug 2022 04:02:54 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0195659E8 for ; Tue, 23 Aug 2022 01:02:52 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQOrt-0002w5-OU; Tue, 23 Aug 2022 10:02:37 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oQOrs-001Svk-Gk; Tue, 23 Aug 2022 10:02:36 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oQOrp-00ALYn-63; Tue, 23 Aug 2022 10:02:33 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v3 08/17] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Date: Tue, 23 Aug 2022 10:02:22 +0200 Message-Id: <20220823080231.2466017-9-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220823080231.2466017-1-o.rempel@pengutronix.de> References: <20220823080231.2466017-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This issue was detected after adding regmap register access validation. KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103". So, avoid writing to it. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz9477.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 313a17a989839..54514c9e6e003 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -193,6 +193,11 @@ int ksz9477_reset_switch(struct ksz_device *dev) ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32); + /* KSZ9893 compatible chips do not support refclk configuration */ + if (dev->chip_id == KSZ9893_CHIP_ID || + dev->chip_id == KSZ8563_CHIP_ID) + return 0; + data8 = SW_ENABLE_REFCLKO; if (dev->synclko_disable) data8 = 0; -- 2.30.2